[jira] [Commented] (HDFS-13481) TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently

2018-05-02 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461788#comment-16461788
 ] 

Hudson commented on HDFS-13481:
---

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14115 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14115/])
HDFS-13481. TestRollingFileSystemSinkWithHdfs#testFlushThread: test (templedf: 
rev 87c23ef643393c39e8353ca9f495b0c8f97cdbd9)
* (edit) 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/RollingFileSystemSinkTestBase.java


> TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently
> -
>
> Key: HDFS-13481
> URL: https://issues.apache.org/jira/browse/HDFS-13481
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs
>Affects Versions: 3.0.1
>Reporter: Gabor Bota
>Assignee: Gabor Bota
>Priority: Major
> Fix For: 3.2.0, 3.1.1, 3.0.3
>
> Attachments: HDFS-13481.001.patch
>
>
> The test fails very rarely on a laptop, but very commonly during Jenkins runs.
> {noformat}
> Error Message
>   Flush thread did not run within 10 seconds
> Stacktrace
> java.lang.AssertionError: Flush thread did not run within 10 seconds
>   at 
> org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs.testFlushThread(TestRollingFileSystemSinkWithHdfs.java:291)
> {noformat}
> According to my test, this breaks about 0.3% locally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-13481) TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently

2018-05-02 Thread Daniel Templeton (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461418#comment-16461418
 ] 

Daniel Templeton commented on HDFS-13481:
-

LGTM +1.  If there are no other comments by end of day, I'll commit it.

> TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently
> -
>
> Key: HDFS-13481
> URL: https://issues.apache.org/jira/browse/HDFS-13481
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs
>Affects Versions: 3.0.1
>Reporter: Gabor Bota
>Assignee: Gabor Bota
>Priority: Major
> Attachments: HDFS-13481.001.patch
>
>
> The test fails very rarely on a laptop, but very commonly during Jenkins runs.
> {noformat}
> Error Message
>   Flush thread did not run within 10 seconds
> Stacktrace
> java.lang.AssertionError: Flush thread did not run within 10 seconds
>   at 
> org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs.testFlushThread(TestRollingFileSystemSinkWithHdfs.java:291)
> {noformat}
> According to my test, this breaks about 0.3% locally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-13481) TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently

2018-04-19 Thread genericqa (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444346#comment-16444346
 ] 

genericqa commented on HDFS-13481:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 30m 
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 51s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 27m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 27m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 29s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m  
9s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
40s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}128m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b |
| JIRA Issue | HDFS-13481 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12919812/HDFS-13481.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux e8b9d9ab6d54 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 351e509 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23997/testReport/ |
| Max. process+thread count | 1348 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/23997/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently
> -
>
>

[jira] [Commented] (HDFS-13481) TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently

2018-04-19 Thread Gabor Bota (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444096#comment-16444096
 ] 

Gabor Bota commented on HDFS-13481:
---

Patch tested: When the patch was applied, there were no failures in 4000 runs 
of TestRollingFileSystemSinkWithHdfs.

> TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently
> -
>
> Key: HDFS-13481
> URL: https://issues.apache.org/jira/browse/HDFS-13481
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs
>Affects Versions: 3.0.1
>Reporter: Gabor Bota
>Assignee: Gabor Bota
>Priority: Major
> Attachments: HDFS-13481.001.patch
>
>
> The test fails very rarely on a laptop, but very commonly during Jenkins runs.
> {noformat}
> Error Message
>   Flush thread did not run within 10 seconds
> Stacktrace
> java.lang.AssertionError: Flush thread did not run within 10 seconds
>   at 
> org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs.testFlushThread(TestRollingFileSystemSinkWithHdfs.java:291)
> {noformat}
> According to my test, this breaks about 0.3% locally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-13481) TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently

2018-04-19 Thread Gabor Bota (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443989#comment-16443989
 ] 

Gabor Bota commented on HDFS-13481:
---

It seems like changing the 
org.apache.hadoop.metrics2.impl.MetricsConfig#QUEUE_CAPACITY_KEY value to 2 
(the default is 1) fixes the issue. The default value is 1, and sometimes 
org/apache/hadoop/metrics2/impl/MetricsSinkAdapter's queue can not accept an 
additional element, so RollingFileSystemSink#testFlushThread 
RollingFileSystemSink is not able to flush the dropped element.

I will provide a patch soon.

> TestRollingFileSystemSinkWithHdfs#testFlushThread: test failed intermittently
> -
>
> Key: HDFS-13481
> URL: https://issues.apache.org/jira/browse/HDFS-13481
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: hdfs
>Affects Versions: 3.0.1
>Reporter: Gabor Bota
>Assignee: Gabor Bota
>Priority: Major
>
> The test fails very rarely on a laptop, but very commonly during Jenkins runs.
> {noformat}
> Error Message
>   Flush thread did not run within 10 seconds
> Stacktrace
> java.lang.AssertionError: Flush thread did not run within 10 seconds
>   at 
> org.apache.hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs.testFlushThread(TestRollingFileSystemSinkWithHdfs.java:291)
> {noformat}
> According to my test, this breaks about 0.3% locally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org