[jira] [Commented] (HDFS-13598) Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
[
https://issues.apache.org/jira/browse/HDFS-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488361#comment-16488361
]
Hudson commented on HDFS-13598:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14278 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14278/])
HDFS-13598. Reduce unnecessary byte-to-string transform operation in (yqlin:
rev 7a87add4ea4c317aa9377d1fc8e43fb5e7418a46)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodesInPath.java
> Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
> --
>
> Key: HDFS-13598
> URL: https://issues.apache.org/jira/browse/HDFS-13598
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Yiqun Lin
>Assignee: Gabor Bota
>Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HDFS-13598.001.patch
>
>
> Every time we invoke {{INodesInPath#toString()}}, we will trigger one time
> byte-to-string transform operation.
> {code:java}
> private String toString(boolean vaildateObject) {
> if (vaildateObject) {
> validate();
> }
> final StringBuilder b = new StringBuilder(getClass().getSimpleName())
> .append(": path = ").append(DFSUtil.byteArray2PathString(path))
> .append("\n inodes = ");
> ...
> }
> {code}
> But actually we only need to do at most one time. In {{INodesInPath}}, it has
> defined one String type variable named {{pathname}} for storing the path
> string value. Here we can use {{getPath()}} to replace
> {{DFSUtil.byteArray2PathString(path)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13598) Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
[
https://issues.apache.org/jira/browse/HDFS-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488342#comment-16488342
]
Yiqun Lin commented on HDFS-13598:
--
Failed unit test is not related. LGTM, +1.
> Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
> --
>
> Key: HDFS-13598
> URL: https://issues.apache.org/jira/browse/HDFS-13598
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Yiqun Lin
>Assignee: Gabor Bota
>Priority: Minor
> Attachments: HDFS-13598.001.patch
>
>
> Every time we invoke {{INodesInPath#toString()}}, we will trigger one time
> byte-to-string transform operation.
> {code:java}
> private String toString(boolean vaildateObject) {
> if (vaildateObject) {
> validate();
> }
> final StringBuilder b = new StringBuilder(getClass().getSimpleName())
> .append(": path = ").append(DFSUtil.byteArray2PathString(path))
> .append("\n inodes = ");
> ...
> }
> {code}
> But actually we only need to do at most one time. In {{INodesInPath}}, it has
> defined one String type variable named {{pathname}} for storing the path
> string value. Here we can use {{getPath()}} to replace
> {{DFSUtil.byteArray2PathString(path)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13598) Reduce unnecessary byte-to-string transform operation in INodesInPath#toString
[
https://issues.apache.org/jira/browse/HDFS-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487698#comment-16487698
]
genericqa commented on HDFS-13598:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 18s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 24s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 35s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.TestReencryptionWithKMS |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDFS-13598 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12924759/HDFS-13598.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 178af8c18a10 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / f61e3e7 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/24284/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/24284/testReport/ |
| Max. process+thread count | 3119 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
