[jira] [Commented] (HDFS-13911) HDFS - Inconsistency in get and put syntax if filename/dirname contains space
[ https://issues.apache.org/jira/browse/HDFS-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698845#comment-16698845 ] Vinayakumar B commented on HDFS-13911: -- +1 > HDFS - Inconsistency in get and put syntax if filename/dirname contains space > - > > Key: HDFS-13911 > URL: https://issues.apache.org/jira/browse/HDFS-13911 > Project: Hadoop HDFS > Issue Type: Bug > Components: fs >Affects Versions: 3.1.1 >Reporter: vivek kumar >Assignee: Ayush Saxena >Priority: Minor > Attachments: HDFS-13911-01.patch, HDFS-13911-02.patch > > > Inconsistency in get and put syntax if file/fdir name contains space. > While copying file/dir from local to HDFS, space needs to be represented with > %20. However, the same representation does not work for copying file to > Local. Expectaion is to have same syntax for both get and put. > test:/ # mkdir /opt/ > test:/ # mkdir /opt/test\ space > test:/ # vi /opt/test\ space/test\ file.txt > test:/ # ll /opt/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:37 test file.txt > test:/ # > *test:/ # hadoop fs -put /opt/test\ space/ /tmp/* > *put: unexpected URISyntaxException* > test:/ # > *test:/ # hadoop fs -put /opt/test%20space/ /tmp/* > test:/ # > test:/ # hadoop fs -ls /tmp > drwxr-xr-x - user1 hadoop 0 2018-09-12 18:38 /tmp/test space > test:/ # > *test:/ # hadoop fs -get /tmp/test%20space /srv/* > *get: `/tmp/test%20space': No such file or directory* > test:/ # > *test:/ # hadoop fs -get /tmp/test\ space /srv/* > test:/ # ll /srv/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:39 test file.txt -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13911) HDFS - Inconsistency in get and put syntax if filename/dirname contains space
[
https://issues.apache.org/jira/browse/HDFS-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698197#comment-16698197
]
Hadoop QA commented on HDFS-13911:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 23s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 17s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
53s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 88m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f |
| JIRA Issue | HDFS-13911 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12949419/HDFS-13911-02.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux ad3f3e9f423f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / a8302e3 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/25627/testReport/ |
| Max. process+thread count | 1464 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/25627/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> HDFS - Inconsistency in get and put syntax if filename/dirname contains space
> -
>
>
[jira] [Commented] (HDFS-13911) HDFS - Inconsistency in get and put syntax if filename/dirname contains space
[ https://issues.apache.org/jira/browse/HDFS-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698159#comment-16698159 ] Ayush Saxena commented on HDFS-13911: - Thanx [~vinayrpet] for the review!!! Have uploaded patch with a test covering the said issue. Pls Review :) > HDFS - Inconsistency in get and put syntax if filename/dirname contains space > - > > Key: HDFS-13911 > URL: https://issues.apache.org/jira/browse/HDFS-13911 > Project: Hadoop HDFS > Issue Type: Bug > Components: fs >Affects Versions: 3.1.1 >Reporter: vivek kumar >Assignee: Ayush Saxena >Priority: Minor > Attachments: HDFS-13911-01.patch, HDFS-13911-02.patch > > > Inconsistency in get and put syntax if file/fdir name contains space. > While copying file/dir from local to HDFS, space needs to be represented with > %20. However, the same representation does not work for copying file to > Local. Expectaion is to have same syntax for both get and put. > test:/ # mkdir /opt/ > test:/ # mkdir /opt/test\ space > test:/ # vi /opt/test\ space/test\ file.txt > test:/ # ll /opt/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:37 test file.txt > test:/ # > *test:/ # hadoop fs -put /opt/test\ space/ /tmp/* > *put: unexpected URISyntaxException* > test:/ # > *test:/ # hadoop fs -put /opt/test%20space/ /tmp/* > test:/ # > test:/ # hadoop fs -ls /tmp > drwxr-xr-x - user1 hadoop 0 2018-09-12 18:38 /tmp/test space > test:/ # > *test:/ # hadoop fs -get /tmp/test%20space /srv/* > *get: `/tmp/test%20space': No such file or directory* > test:/ # > *test:/ # hadoop fs -get /tmp/test\ space /srv/* > test:/ # ll /srv/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:39 test file.txt -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13911) HDFS - Inconsistency in get and put syntax if filename/dirname contains space
[ https://issues.apache.org/jira/browse/HDFS-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686432#comment-16686432 ] Vinayakumar B commented on HDFS-13911: -- [~ayushtkn], Thanks for the patch. I think change should fix the above said issue. Please include one test verifying the fix. > HDFS - Inconsistency in get and put syntax if filename/dirname contains space > - > > Key: HDFS-13911 > URL: https://issues.apache.org/jira/browse/HDFS-13911 > Project: Hadoop HDFS > Issue Type: Bug > Components: fs >Affects Versions: 3.1.1 >Reporter: vivek kumar >Assignee: Ayush Saxena >Priority: Minor > Attachments: HDFS-13911-01.patch > > > Inconsistency in get and put syntax if file/fdir name contains space. > While copying file/dir from local to HDFS, space needs to be represented with > %20. However, the same representation does not work for copying file to > Local. Expectaion is to have same syntax for both get and put. > test:/ # mkdir /opt/ > test:/ # mkdir /opt/test\ space > test:/ # vi /opt/test\ space/test\ file.txt > test:/ # ll /opt/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:37 test file.txt > test:/ # > *test:/ # hadoop fs -put /opt/test\ space/ /tmp/* > *put: unexpected URISyntaxException* > test:/ # > *test:/ # hadoop fs -put /opt/test%20space/ /tmp/* > test:/ # > test:/ # hadoop fs -ls /tmp > drwxr-xr-x - user1 hadoop 0 2018-09-12 18:38 /tmp/test space > test:/ # > *test:/ # hadoop fs -get /tmp/test%20space /srv/* > *get: `/tmp/test%20space': No such file or directory* > test:/ # > *test:/ # hadoop fs -get /tmp/test\ space /srv/* > test:/ # ll /srv/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:39 test file.txt -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-13911) HDFS - Inconsistency in get and put syntax if filename/dirname contains space
[
https://issues.apache.org/jira/browse/HDFS-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627495#comment-16627495
]
Hadoop QA commented on HDFS-13911:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 32s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 14m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
1m 58s{color} | {color:green} patch has no errors when building and testing our
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
27s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HDFS-13911 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12941215/HDFS-13911-01.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 7ab43e5cf769 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 26c94a0 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/25138/testReport/ |
| Max. process+thread count | 1353 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/25138/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> HDFS - Inconsistency in get and put syntax
[jira] [Commented] (HDFS-13911) HDFS - Inconsistency in get and put syntax if filename/dirname contains space
[ https://issues.apache.org/jira/browse/HDFS-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626840#comment-16626840 ] Ayush Saxena commented on HDFS-13911: - Thanx [~vivek.kumar] for reporting the issue.I agree to the fact that what goes in should also come out. I think to do so they are two approaches either we sort the put command to take it without %20 and don't throw URIException in case we use just space or We can add in the get command to decode %20 and stuffs similarly as it is done in put command. :) > HDFS - Inconsistency in get and put syntax if filename/dirname contains space > - > > Key: HDFS-13911 > URL: https://issues.apache.org/jira/browse/HDFS-13911 > Project: Hadoop HDFS > Issue Type: Bug > Components: fs >Affects Versions: 3.1.1 >Reporter: vivek kumar >Assignee: Ayush Saxena >Priority: Minor > > Inconsistency in get and put syntax if file/fdir name contains space. > While copying file/dir from local to HDFS, space needs to be represented with > %20. However, the same representation does not work for copying file to > Local. Expectaion is to have same syntax for both get and put. > test:/ # mkdir /opt/ > test:/ # mkdir /opt/test\ space > test:/ # vi /opt/test\ space/test\ file.txt > test:/ # ll /opt/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:37 test file.txt > test:/ # > *test:/ # hadoop fs -put /opt/test\ space/ /tmp/* > *put: unexpected URISyntaxException* > test:/ # > *test:/ # hadoop fs -put /opt/test%20space/ /tmp/* > test:/ # > test:/ # hadoop fs -ls /tmp > drwxr-xr-x - user1 hadoop 0 2018-09-12 18:38 /tmp/test space > test:/ # > *test:/ # hadoop fs -get /tmp/test%20space /srv/* > *get: `/tmp/test%20space': No such file or directory* > test:/ # > *test:/ # hadoop fs -get /tmp/test\ space /srv/* > test:/ # ll /srv/test\ space/ > total 4 > -rw-r--r-- 1 root root 7 Sep 12 18:39 test file.txt -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
