[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889147#comment-16889147 ] Hudson commented on HDFS-14577: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16957 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16957/]) HDFS-14577. RBF: FederationUtil#newInstance should allow constructor (ayushsaxena: rev 6282c02d7d377f2da6026eb26f90db0386480ec0) * (edit) hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/FederationUtil.java * (add) hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestFederationUtil.java > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14577-HDFS-13891.001.patch, HDFS-14577.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888447#comment-16888447 ] Íñigo Goiri commented on HDFS-14577: [^HDFS-14577.001.patch] LGTM. The failed unit tests are already being tracked. +1 > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch, HDFS-14577.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[
https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888283#comment-16888283
]
Hadoop QA commented on HDFS-14577:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 11s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 23s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 40s{color}
| {color:red} hadoop-hdfs-rbf in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 75m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup |
| | hadoop.hdfs.server.federation.security.TestRouterHttpDelegationToken |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.8 Server=18.09.8 Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-14577 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12975187/HDFS-14577.001.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 50a2d8848ebe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9838a47 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/27256/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/27256/testReport/ |
| Max. process+thread count | 1603 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U:
hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output |
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888241#comment-16888241 ] Ayush Saxena commented on HDFS-14577: - Thanx [~elgoiri] I have put the same patch again to trigger Jenkins against trunk. Guess can push if the report stays clean. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch, HDFS-14577.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888224#comment-16888224 ] Íñigo Goiri commented on HDFS-14577: I think this is separate enough and can go in this JIRA. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888080#comment-16888080 ] Ayush Saxena commented on HDFS-14577: - So what we can do, Should we do as part of the JIRA's that are going to use it, Or do we push this? > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886279#comment-16886279 ] Íñigo Goiri commented on HDFS-14577: [^HDFS-14577-HDFS-13891.001.patch] is good. The only issue is that this needs to be merged to trunk now. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886134#comment-16886134 ] Ayush Saxena commented on HDFS-14577: - v001 LGTM +1 [~elgoiri] any further comments bq. I plan to first use it for HDFS-14090 and later in another Jira to refactor RouterSecurityManager. Maybe after this [~crh] you can push both the said tasks. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[
https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870543#comment-16870543
]
Hadoop QA commented on HDFS-14577:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-13891 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
23s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
51s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 59s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
21s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} HDFS-13891 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 1s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 28m 21s{color}
| {color:red} hadoop-hdfs-rbf in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 94m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hdfs.server.federation.router.TestRouterWithSecureStartup |
| | hadoop.hdfs.server.federation.security.TestRouterHttpDelegationToken |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-14577 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972008/HDFS-14577-HDFS-13891.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 3e4b94d9553a 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-13891 / 02597b6 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/PreCommit-HDFS-Build/27044/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/27044/testReport/ |
| Max. process+thread count | 1585 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U:
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868743#comment-16868743 ] Ayush Saxena commented on HDFS-14577: - Nopes, Not allowed now. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868730#comment-16868730 ] Íñigo Goiri commented on HDFS-14577: Thanks [~ayushtkn] for checking. [~brahmareddy], given HDFS-13891 will be merged soon. How do we do this? Do we keep merging? > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868643#comment-16868643 ] Ayush Saxena commented on HDFS-14577: - Well isolation is, if it is completely unrelated, HDFS-14090 has the use of this util, it could be used simply. Mostly we are did like that. But I don't pose any objections to doing it seperately. The code seems correct to me. [~elgoiri] over to you. :) > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867800#comment-16867800 ] CR Hota commented on HDFS-14577: [~ayushtkn] Thanks for the review. Plan to use this change to generate FairnessManager and also SecurityManager for routers. Created this Jira to explain the context and isolate this change. Once done, I plan to first use it for HDFS-14090 and later in another Jira to refactor RouterSecurityManager. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867522#comment-16867522 ] Ayush Saxena commented on HDFS-14577: - The code change seems quite straightforward. But I can't comment about its usability without seeing the related code where it will be used. Usually we make the utils or changes to the utils, where they are used. To basically avoid chances of these being left unused. > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866142#comment-16866142 ] Íñigo Goiri commented on HDFS-14577: It sounds reasonable. [~ayushtkn], do you mind taking a look? > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866001#comment-16866001 ] CR Hota commented on HDFS-14577: [~elgoiri] Thanks for the review. ReflectionUtils is quite diverged from FederationUtil. One might need conf to create the object itself. Yes setConf is present but that is after the object creation. Also this is something that can be done by the developer itself, after the instance reference is given back. The use cases are to create FairnessManager and also SecurityManager which need just the conf object and standardize pluggable object creation. May be at some point we may look to deprecate FederationUtil and enhance ReflectionUtil to help create all objects (nnresolver, statestore resolver, fairness, security). > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865980#comment-16865980 ] Íñigo Goiri commented on HDFS-14577: It seems reasonable. My only concern is with the consitency with ReflecitonUtils. Over there, they try to use setConf(). Can we double check the signature for those? BTW, where do you want to use this? > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[ https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865969#comment-16865969 ] CR Hota commented on HDFS-14577: [~elgoiri] Could you please help take a look? > RBF: FederationUtil#newInstance should allow constructor without context > > > Key: HDFS-14577 > URL: https://issues.apache.org/jira/browse/HDFS-14577 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: CR Hota >Assignee: CR Hota >Priority: Major > Attachments: HDFS-14577-HDFS-13891.001.patch > > > FederationUtil#newInstance either works for empty constructor or constructor > with conf and context class. More use cases are coming along where conf is > the only param needed to construct objects. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14577) RBF: FederationUtil#newInstance should allow constructor without context
[
https://issues.apache.org/jira/browse/HDFS-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865959#comment-16865959
]
Hadoop QA commented on HDFS-14577:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-13891 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
19s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
45s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 21s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
8s{color} | {color:green} HDFS-13891 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} HDFS-13891 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 46s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 25m
45s{color} | {color:green} hadoop-hdfs-rbf in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 89m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | HDFS-14577 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972008/HDFS-14577-HDFS-13891.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 971f6e2bf7a0 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-13891 / caa285b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/26974/testReport/ |
| Max. process+thread count | 1035 (vs. ulimit of 1) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U:
hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/26974/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> RBF: FederationUtil#newInstance should allow constructor without context
>
