[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923945#comment-16923945 ] Chen Zhang commented on HDFS-14784: --- Thanks [~crh] for the review and [~elgoiri] for pushing this Jira forward. I'll update HDFS-14609 soon. > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923919#comment-16923919 ] Íñigo Goiri commented on HDFS-14784: Thanks [~zhangchen] for the patch and [~crh] for the review. Committed to trunk. Let's try to get done with HDFS-14609 now; those failed unit tests are killing me. > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923918#comment-16923918 ] Hudson commented on HDFS-14784: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17236 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/17236/]) HDFS-14784. Add more methods to WebHdfsTestUtil to support tests outside (inigoiri: rev 494d75eb2b699bf46b86c2af8e3c7587329cddf4) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsTokens.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/WebHdfsTestUtil.java > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Fix For: 3.3.0 > > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923916#comment-16923916 ] Íñigo Goiri commented on HDFS-14784: I removed one of the [^HDFS-14784.002.patch] as they were added to trigger Yetus. +1 form my side too. Committing to trunk. > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923845#comment-16923845 ] CR Hota commented on HDFS-14784: [~elgoiri] Thanks for pointing out. +1 for 002.patch > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch, > HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923835#comment-16923835 ] Íñigo Goiri commented on HDFS-14784: [~crh] are you ok with it then? Do you mind giving an official +1? > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch, > HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923827#comment-16923827 ] CR Hota commented on HDFS-14784: [~zhangchen] Thanks for the latest patch. Looks good to me too. Yes, maybe it's an overkill to add a test for the wrapper. When we use the function, we will obviously add the test which will anyways automatically use it. > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch, > HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923195#comment-16923195 ] Hadoop QA commented on HDFS-14784: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 33s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 8s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}105m 1s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 36s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}173m 17s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.tools.TestDFSZKFailoverController | | | hadoop.hdfs.server.datanode.TestDataNodeLifeline | \\ \\ || Subsystem || Report/Notes || | Docker | Client=18.09.7 Server=18.09.7 Image:yetus/hadoop:bdbca0e53b4 | | JIRA Issue | HDFS-14784 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979502/HDFS-14784.002.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 2aa20dcc4c78 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / f347c34 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/27787/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/27787/testReport/ | | Max. process+thread count | 3020 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/27787/console | |
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923068#comment-16923068 ] Íñigo Goiri commented on HDFS-14784: That Yetus run took a while :) The changes look good and the fix too. [~crh] do you mind checking again? > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch, > HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923055#comment-16923055 ] Hadoop QA commented on HDFS-14784: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 39s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 33s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 21s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 24s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 47s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 26s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}163m 3s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA | | | hadoop.hdfs.TestRollingUpgrade | \\ \\ || Subsystem || Report/Notes || | Docker | Client=18.09.7 Server=18.09.7 Image:yetus/hadoop:bdbca0e53b4 | | JIRA Issue | HDFS-14784 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979502/HDFS-14784.002.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux e074e435514f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / ae28747 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/27784/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/27784/testReport/ | | Max. process+thread count | 2849 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/27784/console | | Powered by |
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923001#comment-16923001 ] Chen Zhang commented on HDFS-14784: --- Jenkins build not triggered, re-submit patch v2 to trigger Jenkins build > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch, > HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919837#comment-16919837 ] Hadoop QA commented on HDFS-14784: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 9s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m 2s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 15m 45s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 24s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}104m 9s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 46s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}175m 18s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.TestDecommissionWithStriped | | | hadoop.hdfs.TestFileCreationClient | | | hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy | | | hadoop.hdfs.TestAclsEndToEnd | | | hadoop.hdfs.TestAppendSnapshotTruncate | | | hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy | | | hadoop.hdfs.TestFileConcurrentReader | | | hadoop.hdfs.server.mover.TestStorageMover | | | hadoop.hdfs.TestFileAppendRestart | | | hadoop.hdfs.TestDFSStripedInputStream | | | hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy | | | hadoop.hdfs.server.balancer.TestBalancer | | | hadoop.hdfs.TestMaintenanceState | | | hadoop.hdfs.TestReconstructStripedFile | | | hadoop.hdfs.TestUnsetAndChangeDirectoryEcPolicy | | | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy | | | hadoop.hdfs.TestFileChecksum | | | hadoop.hdfs.TestHDFSFileSystemContract | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4 | | JIRA Issue | HDFS-14784 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12978987/HDFS-14784.002.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux bb3071222
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919659#comment-16919659 ] Chen Zhang commented on HDFS-14784: --- Thanks [~crh] for your review, the purpose of adding \{{WebHdfsFileSystem#convertJsonToDelegationToken}} is to make \{{JsonUtilClient#toDelegationToken()}} can be accessed out of package, so I just replace the usage of \{{JsonUtilClient#toDelegationToken()}} in \{{TestWebHdfsTokens}} with \{{WebHdfsFileSystem#convertJsonToDelegationToken}}, so we can test the new added method in current tests. Actually I do want to add a new test for this method, but it's a little complicate, because we have to authenticate by kerberos first to getDelegationToken from a secure cluster, or add a NoAuthFilter like we did in \{{TestRouterHttpDelegationToken}}, I think it's not worth to do these things for testing a wrapper method. > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch, HDFS-14784.002.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919003#comment-16919003 ] CR Hota commented on HDFS-14784: [~zhangchen] Thanks for working on this. Overall patch looks fine. Is it possible to add a test for WebHdfsFileSystem#convertJsonToDelegationToken ? This is the new method we added here. > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917963#comment-16917963 ] Íñigo Goiri commented on HDFS-14784: [~crh] do you mind taking a look? > Add more methods to WebHdfsTestUtil to support tests outside of package > --- > > Key: HDFS-14784 > URL: https://issues.apache.org/jira/browse/HDFS-14784 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Chen Zhang >Assignee: Chen Zhang >Priority: Major > Attachments: HDFS-14784.001.patch > > > Before HDFS-14434, we can access a secure cluster by WebHDFS using user.name > parameter and {{PseudoAuthenticationHandler}} without kerberos > authentication, it's quite useful for some test situation. > HDFS-14434 ignores user.name query parameter in secure WebHDFS when we using > WebHdfsFileSystem, so the only way to use user.name parameter is to access by > URL. > This Jira try to add more methods to WebHdfsTestUtil to support UT out of > package to test WebHDFS in customize way. > More background and discuss, see HDFS-14609. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14784) Add more methods to WebHdfsTestUtil to support tests outside of package
[ https://issues.apache.org/jira/browse/HDFS-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917351#comment-16917351 ] Hadoop QA commented on HDFS-14784: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 46m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 34s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 16s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}118m 50s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 37s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}205m 35s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.TestFSImage | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4 | | JIRA Issue | HDFS-14784 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12978701/HDFS-14784.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux c5f7fd4183d0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 0883ce1 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/27694/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/27694/testReport/ | | Max. process+thread count | 3453 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/27694/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | T