[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948636#comment-16948636 ] Hadoop QA commented on HDFS-14900: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 32m 50s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 5s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} hadolint {color} | {color:green} 0m 2s{color} | {color:green} There were no new hadolint issues. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 18s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 44s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 32s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 60m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.2 Server=19.03.2 Image:yetus/hadoop:1dde3efb91e | | JIRA Issue | HDFS-14900 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12982674/HDFS-14900.003.patch | | Optional Tests | dupname asflicense hadolint shellcheck shelldocs | | uname | Linux c946231da983 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / a031388 | | maven | version: Apache Maven 3.3.9 | | shellcheck | v0.4.6 | | Max. process+thread count | 413 (vs. ulimit of 5500) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/28055/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch, HDFS-14900.002.patch, > HDFS-14900.003.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948573#comment-16948573 ] Hadoop QA commented on HDFS-14900: -- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HDFS-Build/28055/console in case of problems. > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch, HDFS-14900.002.patch, > HDFS-14900.003.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948572#comment-16948572 ] Masatake Iwasaki commented on HDFS-14900: - I need to fix Dockerfile too. attached 003. > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch, HDFS-14900.002.patch, > HDFS-14900.003.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948569#comment-16948569 ] Ayush Saxena commented on HDFS-14900: - guess this won’t solve HADOOP-16648? > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch, HDFS-14900.002.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948564#comment-16948564 ] Masatake Iwasaki commented on HDFS-14900: - attached 002 fixing only BUILDING.txt. > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch, HDFS-14900.002.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948471#comment-16948471 ] Vinayakumar B commented on HDFS-14900: -- Lets not make it skip libhdfspp build silently when "-Pnative" is specifically given. It would be a behavior change in the build. Adding back the protobuf library to build environment does solve the issue. Please keep build environment change alone. > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947589#comment-16947589 ] Hadoop QA commented on HDFS-14900: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 50s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 9s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 50s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 3m 2s{color} | {color:red} root in trunk failed. {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m 59s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 52m 7s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m 2s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} cc {color} | {color:red} 14m 2s{color} | {color:red} root generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2) {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 14m 2s{color} | {color:red} root generated 893 new + 951 unchanged - 0 fixed = 1844 total (was 951) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 14m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 16s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}116m 7s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 58s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}229m 13s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks | | | hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots | | | hadoop.hdfs.server.datanode.TestDataNodeUUID | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.yarn.webapp.TestWebApp | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.3 Server=19.03.3 Image:yetus/hadoop:1dde3efb91e | | JIRA Issue | HDFS-14900 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12982538/HDFS-14900.001.patch | | Optional Tests | dupname asflicense compile cc mvnsite javac unit | | uname | Linux ba7a9c2596cd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 1d27930 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | compile | https://builds.apache.org/job/PreCommit-HDFS-Build/28040/artifact/out/branch-compile-root.txt | | cc | https://builds.apache.org/job/PreCommit-HDFS-Build/28040/artifact/out/diff-compile-cc-root.txt | | javac | https://builds.apache.org/job/PreCommit-HDFS-Build/28040/artifact/out/diff-compile-javac-root.txt | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/28040/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build
[jira] [Commented] (HDFS-14900) Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf
[ https://issues.apache.org/jira/browse/HDFS-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947424#comment-16947424 ] Masatake Iwasaki commented on HDFS-14900: - I attached 001 fixing BUILDING.txt and CMakeList.txt. It makes build of libhdfspp skipped if libprotobuf is not found since only libhdfspp requires libprotobuf. > Fix requirements of BUILDING.txt for libhdfspp which depends on libprotobuf > --- > > Key: HDFS-14900 > URL: https://issues.apache.org/jira/browse/HDFS-14900 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Masatake Iwasaki >Assignee: Masatake Iwasaki >Priority: Major > Attachments: HDFS-14900.001.patch > > > HADOOP-16558 removed protocol buffers from build requirements but libhdfspp > requires libprotobuf and libprotoc. {{-Pnative}} build fails if protocol > buffers is not installed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org