[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109006#comment-17109006 ] Hudson commented on HDFS-15356: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #18261 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/18261/]) HDFS-15356. Unify configuration `dfs.ha.allow.stale.reads` to (ayushsaxena: rev 178336f8a8bb291eb355bede729082f2f0382216) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Fix For: 3.4.0 > > Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch, > HDFS-15356.003.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108999#comment-17108999 ] Ayush Saxena commented on HDFS-15356: - Committed to trunk. Thanx [~hexiaoqiao] for the contribution!!! > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch, > HDFS-15356.003.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108994#comment-17108994 ] Ayush Saxena commented on HDFS-15356: - v003 LGTM +1 > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch, > HDFS-15356.003.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108945#comment-17108945
]
Hadoop QA commented on HDFS-15356:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 21m
35s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
12s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 17m
56s{color} | {color:red} branch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
3s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 15m
53s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 90m 30s{color}
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 51s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://builds.apache.org/job/PreCommit-HDFS-Build/29300/artifact/out/Dockerfile
|
| JIRA Issue | HDFS-15356 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13003108/HDFS-15356.003.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle xml |
| uname | Linux cbacc87a6af4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / ac4a2e11d98 |
|
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108921#comment-17108921 ] Ayush Saxena commented on HDFS-15356: - Thanx [~hexiaoqiao] for the patch. LGTM. Will commit by EOD, if Jenkins has no complains. > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch, > HDFS-15356.003.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108876#comment-17108876 ] Xiaoqiao He commented on HDFS-15356: Thanks [~ayushtkn], v003 try to fix the missing character. Thanks again. > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch, > HDFS-15356.003.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108532#comment-17108532
]
Ayush Saxena commented on HDFS-15356:
-
{{dfs.ha.allow.stale.read}} "s" is missing in the end. The original
configuration was {{dfs.ha.allow.stale.reads}}
> Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
> ---
>
> Key: HDFS-15356
> URL: https://issues.apache.org/jira/browse/HDFS-15356
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
>Reporter: Xiaoqiao He
>Assignee: Xiaoqiao He
>Priority: Major
> Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch
>
>
> Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys
> and give the default value and notice at hdfs-default.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108527#comment-17108527
]
Hadoop QA commented on HDFS-15356:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 23m
23s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
19s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 18m
17s{color} | {color:red} branch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
4s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
2s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 17m
58s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}129m 22s{color}
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}206m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://builds.apache.org/job/PreCommit-HDFS-Build/29286/artifact/out/Dockerfile
|
| JIRA Issue | HDFS-15356 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13003042/HDFS-15356.002.patch |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle xml |
| uname | Linux 2a60d3b98cdc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / ac4a2e11d98 |
| Default
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108511#comment-17108511
]
Hadoop QA commented on HDFS-15356:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 22m
31s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
25s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 18m
33s{color} | {color:red} branch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
16s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
14s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 45s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 1 new + 477 unchanged - 0 fixed = 478 total (was 477) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 16m
23s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}128m 42s{color}
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
49s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}204m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
| | hadoop.hdfs.TestLeaseRecoveryStriped |
| | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
| | hadoop.hdfs.server.namenode.TestStartup |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://builds.apache.org/job/PreCommit-HDFS-Build/29285/artifact/out/Dockerfile
|
| JIRA Issue | HDFS-15356 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13003024/HDFS-15356.001.patch |
| Optional Tests | dupname asflicense compile
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108355#comment-17108355 ] Xiaoqiao He commented on HDFS-15356: Thanks [~ayushtkn], v002 try to fix checkstyle. > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch, HDFS-15356.002.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108349#comment-17108349 ] Ayush Saxena commented on HDFS-15356: - Thanx [~hexiaoqiao] for confirming. I have retriggered the build. Can you check the checkstyle can’t be fixed.. > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108339#comment-17108339 ] Xiaoqiao He commented on HDFS-15356: Hi [~ayushtkn], This is introduced by HDFS-2693 with a long history. I am not sure why this changes broken so many unit tests failed due to OOM as Jenkins reported. Maybe it is not related to this PR. > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[
https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108276#comment-17108276
]
Hadoop QA commented on HDFS-15356:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 20m
59s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
23s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 16m
37s{color} | {color:red} branch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
1s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 49s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch
generated 1 new + 477 unchanged - 0 fixed = 478 total (was 477) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red} 14m
10s{color} | {color:red} patch has errors when building and testing our client
artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}111m 24s{color}
| {color:red} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}181m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestDFSStorageStateRecovery |
| | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
| | hadoop.hdfs.TestFileChecksumCompositeCrc |
| | hadoop.hdfs.TestErasureCodingExerciseAPIs |
| | hadoop.hdfs.TestErasureCodingPolicies |
| | hadoop.hdfs.TestDecommissionWithStriped |
| | hadoop.hdfs.TestDistributedFileSystemWithECFileWithRandomECPolicy |
| | hadoop.hdfs.TestReconstructStripedFile |
| | hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy |
| | hadoop.hdfs.TestDFSStripedInputStream |
| | hadoop.hdfs.TestDFSStripedOutputStream |
| |
[jira] [Commented] (HDFS-15356) Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys
[ https://issues.apache.org/jira/browse/HDFS-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108188#comment-17108188 ] Ayush Saxena commented on HDFS-15356: - +1, Pending Jenkins. [~hexiaoqiao] can you link the related Jira too, where it got added. > Unify configuration `dfs.ha.allow.stale.reads` to DFSConfigKeys > --- > > Key: HDFS-15356 > URL: https://issues.apache.org/jira/browse/HDFS-15356 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs >Reporter: Xiaoqiao He >Assignee: Xiaoqiao He >Priority: Major > Attachments: HDFS-15356.001.patch > > > Unify to Define configuration key `dfs.ha.allow.stale.reads` in DFSConfigKeys > and give the default value and notice at hdfs-default.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
