[jira] [Commented] (HDFS-17161) Adding test for StripedBlockReader#createBlockReader leaks socket on IOException
[ https://issues.apache.org/jira/browse/HDFS-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759136#comment-17759136 ] ASF GitHub Bot commented on HDFS-17161: --- tonyPan123 commented on PR #5956: URL: https://github.com/apache/hadoop/pull/5956#issuecomment-1693815051 Thanks a lot for replying. Yeah, IOException could be thrown in BlockReaderRemote.newBlockReader in StripedBlockReader as illustrated in case HDFS-13039. > Adding test for StripedBlockReader#createBlockReader leaks socket on > IOException > > > Key: HDFS-17161 > URL: https://issues.apache.org/jira/browse/HDFS-17161 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, erasure-coding >Affects Versions: 3.3.6 >Reporter: Haoze Wu >Priority: Major > Labels: pull-request-available > > In [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], it is > proposed a situation in which an IOException during > StripedBlockReader#createBlockReader has potential to leak the socket. > However, in [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], > the test patch is still missed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17161) Adding test for StripedBlockReader#createBlockReader leaks socket on IOException
[ https://issues.apache.org/jira/browse/HDFS-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759025#comment-17759025 ] ASF GitHub Bot commented on HDFS-17161: --- Hexiaoqiao commented on PR #5956: URL: https://github.com/apache/hadoop/pull/5956#issuecomment-1693273115 Thanks @tonyPan123 for your contribution. But I am confused if this could be happen one production cluster. Here you depend on inject logic, do you mean that build connection will throw exceptions? > Adding test for StripedBlockReader#createBlockReader leaks socket on > IOException > > > Key: HDFS-17161 > URL: https://issues.apache.org/jira/browse/HDFS-17161 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, erasure-coding >Affects Versions: 3.3.6 >Reporter: Haoze Wu >Priority: Major > Labels: pull-request-available > > In [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], it is > proposed a situation in which an IOException during > StripedBlockReader#createBlockReader has potential to leak the socket. > However, in [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], > the test patch is still missed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17161) Adding test for StripedBlockReader#createBlockReader leaks socket on IOException
[
https://issues.apache.org/jira/browse/HDFS-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755505#comment-17755505
]
ASF GitHub Bot commented on HDFS-17161:
---
hadoop-yetus commented on PR #5956:
URL: https://github.com/apache/hadoop/pull/5956#issuecomment-1682117418
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 14m 19s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 44m 45s | | trunk passed |
| +1 :green_heart: | compile | 1m 27s | | trunk passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | compile | 1m 19s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 1m 17s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 29s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 12s | | trunk passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 40s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 28s | | trunk passed |
| +1 :green_heart: | shadedclient | 39m 53s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javac | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 13s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 1m 13s | | the patch passed |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/1/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 1m 1s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 3 unchanged -
0 fixed = 9 total (was 3) |
| +1 :green_heart: | mvnsite | 1m 20s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 59s | | the patch passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 28s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 24s | | the patch passed |
| +1 :green_heart: | shadedclient | 37m 59s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 226m 15s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 56s | | The patch does not
generate ASF License warnings. |
| | | 388m 33s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5956 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux d3aa8279a157 4.15.0-212-generic #223-Ubuntu SMP Tue May 23
13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / aa9c54677f107d2cb8daf7783e9d10f10c5fb900 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/1/testReport/ |
| Max. process+thread count | 3170 (vs.
[jira] [Commented] (HDFS-17161) Adding test for StripedBlockReader#createBlockReader leaks socket on IOException
[
https://issues.apache.org/jira/browse/HDFS-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755503#comment-17755503
]
ASF GitHub Bot commented on HDFS-17161:
---
hadoop-yetus commented on PR #5956:
URL: https://github.com/apache/hadoop/pull/5956#issuecomment-1682114560
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 3m 28s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 45m 10s | | trunk passed |
| +1 :green_heart: | compile | 1m 29s | | trunk passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | compile | 1m 20s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 1m 17s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 31s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 14s | | trunk passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 41s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 26s | | trunk passed |
| +1 :green_heart: | shadedclient | 36m 5s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 15s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javac | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 16s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 1m 16s | | the patch passed |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/2/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 1m 5s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/2/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 3 unchanged -
0 fixed = 9 total (was 3) |
| +1 :green_heart: | mvnsite | 1m 22s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 56s | | the patch passed with JDK
Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 33s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 35s | | the patch passed |
| +1 :green_heart: | shadedclient | 38m 3s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 227m 3s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 53s | | The patch does not
generate ASF License warnings. |
| | | 376m 49s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestObserverNode |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5956/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5956 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux ad1bc585f255 4.15.0-212-generic #223-Ubuntu SMP Tue May 23
13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / aa9c54677f107d2cb8daf7783e9d10f10c5fb900 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
[jira] [Commented] (HDFS-17161) Adding test for StripedBlockReader#createBlockReader leaks socket on IOException
[ https://issues.apache.org/jira/browse/HDFS-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755359#comment-17755359 ] ASF GitHub Bot commented on HDFS-17161: --- tonyPan123 opened a new pull request, #5956: URL: https://github.com/apache/hadoop/pull/5956 …s socket on IOException ### Description of PR In [HDFS-13039](https://issues.apache.org/jira/browse/HDFS-13039), it is proposed a situation in which an IOException during StripedBlockReader#createBlockReader has potential to leak the socket. However, in [HDFS-13039](https://issues.apache.org/jira/browse/HDFS-13039), the test patch is still missed. Then in this case, we add a unit test to reproduce that. From the test results, when the patch in HDFS-13039 is removed, the test would failed while the test could pass when the patch is added back. Any comments and suggestions would be appreciated. ### How was this patch tested? The case itself is about a unit test ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Adding test for StripedBlockReader#createBlockReader leaks socket on > IOException > > > Key: HDFS-17161 > URL: https://issues.apache.org/jira/browse/HDFS-17161 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode, erasure-coding >Affects Versions: 3.3.6 >Reporter: Haoze Wu >Priority: Major > > In [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], it is > proposed a situation in which an IOException during > StripedBlockReader#createBlockReader has potential to leak the socket. > However, in [HDFS-13039|https://issues.apache.org/jira/browse/HDFS-13039], > the test patch is still missed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
