[jira] [Commented] (HDFS-17359) EC: recheck failed streamers should only after flushing all packets.
[
https://issues.apache.org/jira/browse/HDFS-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813306#comment-17813306
]
ASF GitHub Bot commented on HDFS-17359:
---
hfutatzhanghb commented on PR #6503:
URL: https://github.com/apache/hadoop/pull/6503#issuecomment-1921573095
> Merged. Thanks for your contribution! @hfutatzhanghb
Sir, thanks a lot for your reviewing and merging ~
> EC: recheck failed streamers should only after flushing all packets.
>
>
> Key: HDFS-17359
> URL: https://issues.apache.org/jira/browse/HDFS-17359
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ec
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.3.9, 3.4.1, 3.5.0
>
>
> In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
> {code:java}
> Set newFailed = checkStreamers();
> if (newFailed.size() == 0) {
> return;
> } if (isNeedFlushAllPackets) {
> // for healthy streamers, wait till all of them have fetched the new
> block
> // and flushed out all the enqueued packets.
> flushAllInternals();
> }
> // recheck failed streamers again after the flush
> newFailed = checkStreamers(); {code}
> We should better move the re-check logic into if condition to reduce useless
> invocation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17359) EC: recheck failed streamers should only after flushing all packets.
[
https://issues.apache.org/jira/browse/HDFS-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813269#comment-17813269
]
ASF GitHub Bot commented on HDFS-17359:
---
tasanuma merged PR #6503:
URL: https://github.com/apache/hadoop/pull/6503
> EC: recheck failed streamers should only after flushing all packets.
>
>
> Key: HDFS-17359
> URL: https://issues.apache.org/jira/browse/HDFS-17359
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ec
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Minor
> Labels: pull-request-available
>
> In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
> {code:java}
> Set newFailed = checkStreamers();
> if (newFailed.size() == 0) {
> return;
> } if (isNeedFlushAllPackets) {
> // for healthy streamers, wait till all of them have fetched the new
> block
> // and flushed out all the enqueued packets.
> flushAllInternals();
> }
> // recheck failed streamers again after the flush
> newFailed = checkStreamers(); {code}
> We should better move the re-check logic into if condition to reduce useless
> invocation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17359) EC: recheck failed streamers should only after flushing all packets.
[
https://issues.apache.org/jira/browse/HDFS-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813270#comment-17813270
]
ASF GitHub Bot commented on HDFS-17359:
---
tasanuma commented on PR #6503:
URL: https://github.com/apache/hadoop/pull/6503#issuecomment-1921517899
Merged. Thanks for your contribution! @hfutatzhanghb
> EC: recheck failed streamers should only after flushing all packets.
>
>
> Key: HDFS-17359
> URL: https://issues.apache.org/jira/browse/HDFS-17359
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ec
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Minor
> Labels: pull-request-available
>
> In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
> {code:java}
> Set newFailed = checkStreamers();
> if (newFailed.size() == 0) {
> return;
> } if (isNeedFlushAllPackets) {
> // for healthy streamers, wait till all of them have fetched the new
> block
> // and flushed out all the enqueued packets.
> flushAllInternals();
> }
> // recheck failed streamers again after the flush
> newFailed = checkStreamers(); {code}
> We should better move the re-check logic into if condition to reduce useless
> invocation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17359) EC: recheck failed streamers should only after flushing all packets.
[
https://issues.apache.org/jira/browse/HDFS-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811306#comment-17811306
]
ASF GitHub Bot commented on HDFS-17359:
---
hadoop-yetus commented on PR #6503:
URL: https://github.com/apache/hadoop/pull/6503#issuecomment-1912178649
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 3s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 41m 47s | | trunk passed |
| +1 :green_heart: | compile | 0m 58s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 52s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | checkstyle | 0m 31s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 58s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 47s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 42s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 37s | | trunk passed |
| +1 :green_heart: | shadedclient | 34m 3s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 45s | | the patch passed |
| +1 :green_heart: | compile | 0m 52s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 52s | | the patch passed |
| +1 :green_heart: | compile | 0m 44s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | javac | 0m 44s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 19s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 46s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 35s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 34s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 38s | | the patch passed |
| +1 :green_heart: | shadedclient | 33m 54s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 26s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not
generate ASF License warnings. |
| | | 130m 20s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6503/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6503 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 138005f070ab 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / bde7710e7d1ffcd087c5a2f7068725f393aa338a |
| Default Java | Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6503/1/testReport/ |
| Max. process+thread count | 683 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client U:
hadoop-hdfs-project/hadoop-hdfs-client |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6503/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This
[jira] [Commented] (HDFS-17359) EC: recheck failed streamers should only after flushing all packets.
[
https://issues.apache.org/jira/browse/HDFS-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811257#comment-17811257
]
ASF GitHub Bot commented on HDFS-17359:
---
hfutatzhanghb opened a new pull request, #6503:
URL: https://github.com/apache/hadoop/pull/6503
### Description of PR
Refer to HDFS-17359
In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
```java
Set newFailed = checkStreamers();
if (newFailed.size() == 0) {
return;
}if (isNeedFlushAllPackets) {
// for healthy streamers, wait till all of them have fetched the new
block
// and flushed out all the enqueued packets.
flushAllInternals();
}
// recheck failed streamers again after the flush
newFailed = checkStreamers();
```
We should better move the re-check logic into if condition to reduce useless
invocation.
> EC: recheck failed streamers should only after flushing all packets.
>
>
> Key: HDFS-17359
> URL: https://issues.apache.org/jira/browse/HDFS-17359
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ec
>Reporter: farmmamba
>Assignee: farmmamba
>Priority: Minor
>
> In method DFSStripedOutputStream#checkStreamerFailures, we have below codes:
> {code:java}
> Set newFailed = checkStreamers();
> if (newFailed.size() == 0) {
> return;
> } if (isNeedFlushAllPackets) {
> // for healthy streamers, wait till all of them have fetched the new
> block
> // and flushed out all the enqueued packets.
> flushAllInternals();
> }
> // recheck failed streamers again after the flush
> newFailed = checkStreamers(); {code}
> We should better move the re-check logic into if condition to reduce useless
> invocation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
