[jira] [Commented] (HDFS-17426) Remove Invalid FileSystemECReadStats logic in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-17426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829358#comment-17829358
]
ASF GitHub Bot commented on HDFS-17426:
---
haiyang1987 commented on PR #6628:
URL: https://github.com/apache/hadoop/pull/6628#issuecomment-2011103924
Thanks @ZanderXu for your review and merge~
> Remove Invalid FileSystemECReadStats logic in DFSInputStream
>
>
> Key: HDFS-17426
> URL: https://issues.apache.org/jira/browse/HDFS-17426
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haiyang Hu
>Assignee: Haiyang Hu
>Priority: Major
> Labels: pull-request-available
>
> When read the replication file, the following logic will be called when
> _readingWithStrategy_ and _actualGetFromOneDataNode_ logic in
> DFSInputStream.java
> {code:java}
> if (readStatistics.getBlockType() == BlockType.STRIPED) {
> dfsClient.updateFileSystemECReadStats(nread);
> }
> {code}
> This is invalid call, can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17426) Remove Invalid FileSystemECReadStats logic in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-17426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829353#comment-17829353
]
ASF GitHub Bot commented on HDFS-17426:
---
ZanderXu commented on PR #6628:
URL: https://github.com/apache/hadoop/pull/6628#issuecomment-2011080558
Merged.
> Remove Invalid FileSystemECReadStats logic in DFSInputStream
>
>
> Key: HDFS-17426
> URL: https://issues.apache.org/jira/browse/HDFS-17426
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haiyang Hu
>Assignee: Haiyang Hu
>Priority: Major
> Labels: pull-request-available
>
> When read the replication file, the following logic will be called when
> _readingWithStrategy_ and _actualGetFromOneDataNode_ logic in
> DFSInputStream.java
> {code:java}
> if (readStatistics.getBlockType() == BlockType.STRIPED) {
> dfsClient.updateFileSystemECReadStats(nread);
> }
> {code}
> This is invalid call, can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17426) Remove Invalid FileSystemECReadStats logic in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-17426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829352#comment-17829352
]
ASF GitHub Bot commented on HDFS-17426:
---
ZanderXu merged PR #6628:
URL: https://github.com/apache/hadoop/pull/6628
> Remove Invalid FileSystemECReadStats logic in DFSInputStream
>
>
> Key: HDFS-17426
> URL: https://issues.apache.org/jira/browse/HDFS-17426
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haiyang Hu
>Assignee: Haiyang Hu
>Priority: Major
> Labels: pull-request-available
>
> When read the replication file, the following logic will be called when
> _readingWithStrategy_ and _actualGetFromOneDataNode_ logic in
> DFSInputStream.java
> {code:java}
> if (readStatistics.getBlockType() == BlockType.STRIPED) {
> dfsClient.updateFileSystemECReadStats(nread);
> }
> {code}
> This is invalid call, can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17426) Remove Invalid FileSystemECReadStats logic in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-17426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827459#comment-17827459
]
ASF GitHub Bot commented on HDFS-17426:
---
haiyang1987 commented on PR #6628:
URL: https://github.com/apache/hadoop/pull/6628#issuecomment-1999322553
> LGTM.
>
> These logics are unused for Contiguous Block Reading.
Thanks @ZanderXu for your review.
> Remove Invalid FileSystemECReadStats logic in DFSInputStream
>
>
> Key: HDFS-17426
> URL: https://issues.apache.org/jira/browse/HDFS-17426
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haiyang Hu
>Assignee: Haiyang Hu
>Priority: Major
> Labels: pull-request-available
>
> When read the replication file, the following logic will be called when
> _readingWithStrategy_ and _actualGetFromOneDataNode_ logic in
> DFSInputStream.java
> {code:java}
> if (readStatistics.getBlockType() == BlockType.STRIPED) {
> dfsClient.updateFileSystemECReadStats(nread);
> }
> {code}
> This is invalid call, can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17426) Remove Invalid FileSystemECReadStats logic in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-17426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827386#comment-17827386
]
ASF GitHub Bot commented on HDFS-17426:
---
hadoop-yetus commented on PR #6628:
URL: https://github.com/apache/hadoop/pull/6628#issuecomment-1999003625
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 44m 25s | | trunk passed |
| +1 :green_heart: | compile | 1m 1s | | trunk passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 |
| +1 :green_heart: | compile | 0m 54s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | checkstyle | 0m 34s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 59s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 52s | | trunk passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 |
| +1 :green_heart: | javadoc | 0m 44s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| -1 :x: | spotbugs | 2m 41s |
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6628/1/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html)
| hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs
warnings. |
| +1 :green_heart: | shadedclient | 34m 15s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | | the patch passed |
| +1 :green_heart: | compile | 0m 51s | | the patch passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 |
| +1 :green_heart: | javac | 0m 51s | | the patch passed |
| +1 :green_heart: | compile | 0m 46s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | javac | 0m 46s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 22s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 48s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 37s | | the patch passed with JDK
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 |
| +1 :green_heart: | javadoc | 0m 35s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 2m 35s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 5s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 27s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 37s | | The patch does not
generate ASF License warnings. |
| | | 133m 32s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6628/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6628 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 3040c65960d7 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9
15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c17c8e36a0d8b3e4c343f3c7607354d1285e834a |
| Default Java | Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6628/1/testReport/ |
| Max. process+thread count | 631 (vs. ulimit of 5500) |
| modules | C:
[jira] [Commented] (HDFS-17426) Remove Invalid FileSystemECReadStats logic in DFSInputStream
[
https://issues.apache.org/jira/browse/HDFS-17426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827345#comment-17827345
]
ASF GitHub Bot commented on HDFS-17426:
---
haiyang1987 opened a new pull request, #6628:
URL: https://github.com/apache/hadoop/pull/6628
### Description of PR
https://issues.apache.org/jira/browse/HDFS-17426
When read the replication file, the following logic will be called when
`readingWithStrategy` and `actualGetFromOneDataNode` logic in
`DFSInputStream.java`
```
if (readStatistics.getBlockType() == BlockType.STRIPED) {
dfsClient.updateFileSystemECReadStats(nread);
}
```
This is invalid call, can remove it.
> Remove Invalid FileSystemECReadStats logic in DFSInputStream
>
>
> Key: HDFS-17426
> URL: https://issues.apache.org/jira/browse/HDFS-17426
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haiyang Hu
>Assignee: Haiyang Hu
>Priority: Major
>
> When read the replication file, the following logic will be called when
> _readingWithStrategy_ and _actualGetFromOneDataNode_ logic in
> DFSInputStream.java
> {code:java}
> if (readStatistics.getBlockType() == BlockType.STRIPED) {
> dfsClient.updateFileSystemECReadStats(nread);
> }
> {code}
> This is invalid call, can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
