[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-15 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837348#comment-17837348
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

goiri merged PR #6727:
URL: https://github.com/apache/hadoop/pull/6727




> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Affects Versions: 3.5.0
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837048#comment-17837048
 ] 

Xiping Zhang commented on HDFS-17465:
-

[~goiri]   Hi, this is an obvious logical problem, the failure of the use case 
has nothing to do with it, can you help to merge  it?

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Affects Versions: 3.5.0
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837030#comment-17837030
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

zhangxiping1 commented on code in PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#discussion_r1565052852


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java:
##
@@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) {
   public void releasePermit(String nsId) {
 if (contains(nsId)) {
   super.releasePermit(nsId);
+} else {
+  super.releasePermit(DEFAULT_NS);
 }

Review Comment:
   yes, thank you for your reply,the effect is the same. : )





> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836937#comment-17836937
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

hadoop-yetus commented on PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#issuecomment-2054000539

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 33s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  45m 34s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 38s |  |  trunk passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  compile  |   0m 36s |  |  trunk passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | +1 :green_heart: |  checkstyle  |   0m 27s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 40s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 42s |  |  trunk passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  trunk passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | -1 :x: |  spotbugs  |   1m 21s | 
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6727/1/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf-warnings.html)
 |  hadoop-hdfs-project/hadoop-hdfs-rbf in trunk has 1 extant spotbugs 
warnings.  |
   | +1 :green_heart: |  shadedclient  |  34m  7s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 32s |  |  the patch passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  javac  |   0m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 27s |  |  the patch passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | +1 :green_heart: |  javac  |   0m 27s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   0m 33s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  the patch passed with JDK 
Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  the patch passed with JDK 
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06  |
   | +1 :green_heart: |  spotbugs  |   1m 20s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  34m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |  29m 11s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 38s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 159m  5s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6727/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/6727 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux c32de0b16bf5 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 
15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / b2b6b60c22e4e45abdb2cc8ad1c1715bd9aca8c3 |
   | Default Java | Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6727/1/testReport/ |
   | Max. process+thread count | 3446 (vs. ulimit of 5500) |
   | modules |

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836921#comment-17836921
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

KeeProMise commented on code in PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#discussion_r1564577262


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java:
##
@@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) {
   public void releasePermit(String nsId) {
 if (contains(nsId)) {
   super.releasePermit(nsId);
+} else {
+  super.releasePermit(DEFAULT_NS);
 }

Review Comment:
   hi, LGTM. Personal opinion, whether it can be written like this.
   ```java
   if (contains(nsId)) {
  super.releasePermit(nsId);
  return;
   }
   super.releasePermit(DEFAULT_NS);
   ```





> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836915#comment-17836915
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

KeeProMise commented on code in PR #6727:
URL: https://github.com/apache/hadoop/pull/6727#discussion_r1564577262


##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java:
##
@@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) {
   public void releasePermit(String nsId) {
 if (contains(nsId)) {
   super.releasePermit(nsId);
+} else {
+  super.releasePermit(DEFAULT_NS);
 }

Review Comment:
   Personal opinion, whether it can be written like this.
   ```java
   if (contains(nsId)) {
  super.releasePermit(nsId);
  return;
   }
   super.releasePermit(DEFAULT_NS);
   ```





> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Jian Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836914#comment-17836914
 ] 

Jian Zhang commented on HDFS-17465:
---

[~zhangxiping] hi, The code of our own cluster is a little different from the 
community code, so we did not find this problem. But this bug really needs to 
be fixed, thanks.

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836908#comment-17836908
 ] 

Xiping Zhang commented on HDFS-17465:
-

[~Keepromise]   hi , will your cluster trigger this issue as well? 

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png, image-2024-04-14-16-23-18-499.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread Xiping Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836907#comment-17836907
 ] 

Xiping Zhang commented on HDFS-17465:
-

!image-2024-04-14-16-07-32-362.png!

Permit should not always be released here. Maximum permit count exceeded

 

> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
>  Labels: pull-request-available
> Attachments: image-2024-04-14-15-39-59-531.png, 
> image-2024-04-14-16-07-32-362.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Commented] (HDFS-17465) RBF: Use ProportionRouterRpcFairnessPolicyController get “java.Lang. Error: Maximum permit count exceeded”

2024-04-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/HDFS-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836905#comment-17836905
 ] 

ASF GitHub Bot commented on HDFS-17465:
---

zhangxiping1 opened a new pull request, #6727:
URL: https://github.com/apache/hadoop/pull/6727

   …“'ava.Lang. Error: Maximum permit count exceeded'
   
   
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> RBF: Use ProportionRouterRpcFairnessPolicyController get  “java.Lang. Error: 
> Maximum permit count exceeded”
> ---
>
> Key: HDFS-17465
> URL: https://issues.apache.org/jira/browse/HDFS-17465
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: rbf
>Reporter: Xiping Zhang
>Assignee: Xiping Zhang
>Priority: Blocker
> Attachments: image-2024-04-14-15-39-59-531.png
>
>
> !image-2024-04-14-15-39-59-531.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org