[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088582#comment-13088582 ] Hadoop QA commented on HDFS-2277: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491184/HDFS-2277-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1135//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1135//artifact/trunk/target/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1135//console This message is automatically generated. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089153#comment-13089153 ] Eli Collins commented on HDFS-2277: --- The code that uses build/ivy/lib needs to be updated to use target as well right? Otherwise looks great. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089162#comment-13089162 ] Eric Yang commented on HDFS-2277: - The current maven structure has bin scripts located in hadoop-hdfs/src/main/bin, and dependent jar files are not downloaded to target directory. It doesn't seem possible to run directly from the source directory anymore after the maven structure change. If community agrees, I will remove CLASSPATH construction for running from source directory. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089163#comment-13089163 ] Eli Collins commented on HDFS-2277: --- Yea, all the code that allows for running from source directories is really out of date now. I think we should remove all the related code entirely from common and hdfs (can do that in a separate jira). Shame to lose this feature but as you point out it's not a quick fix given the current state, we can file a separate jira to add it back if running from dev tarballs becomes too painful. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089166#comment-13089166 ] Ravi Prakash commented on HDFS-2277: It is a great convenience running from source directory for a more efficient dev cycle. I was able to do so by manually copying the classpath generated by mvn dependency:build-classpath into classpath. I don't know how much effort it is to include this feature programatically. So I don't vote either way. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089169#comment-13089169 ] Eli Collins commented on HDFS-2277: --- Filed HADOOP-7572 to restore running the daemons from source trees. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089168#comment-13089168 ] Ravi Prakash commented on HDFS-2277: If we are removing the ability to run hadoop from source perhaps we should have an umbrella JIRA to track this? I'm afraid I am not aware of one CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089170#comment-13089170 ] Aaron T. Myers commented on HDFS-2277: -- I would personally be fine not being able to run from source checkouts as long as setting HADOOP_COMMON_HOME and HADOOP_HDFS_HOME to distinct directories generated by mvn package -Pdist still works. Has that scenario been tested with this change? CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089171#comment-13089171 ] Eli Collins commented on HDFS-2277: --- This change doesn't break running from source directories (it's already broken), in my comment I suggested Eric fixup those classpaths while he was fixing these ones here. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089174#comment-13089174 ] Ravi Prakash commented on HDFS-2277: +1. I'm happy with the filed jira. A few more things need to go into enabling that feature so this jira is perhaps not the best place for that anyway. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089177#comment-13089177 ] Alejandro Abdelnur commented on HDFS-2277: -- 'mvn package -Pdist' creates the dist layout in 'target/module-version' You can set the *_HOME PATH to to the locations in 'target/module-version' 'target/module-version/bin' and you achieve the same result. And, on the plus side the scripts don't have to handle devel/dist mode, just dist mode. The overhead of running 'mvn package -Pdist' (if you don't do use -Psrc and -Pdocs) is minimal (a few seconds if). CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089186#comment-13089186 ] Ravi Prakash commented on HDFS-2277: Reposting Alejandro's comment without the messed up formatting. Thanks Alejandro! You're a lifesaver 'mvn package \-Pdist' creates the dist layout in 'target/module\-version' You can set the *_HOME PATH to to the locations in 'target/module\-version' 'target/module\-version/bin' and you achieve the same result. And, on the plus side the scripts don't have to handle devel/dist mode, just dist mode. The overhead of running 'mvn package -Pdist' (if you don't do use -Psrc and -Pdocs) is minimal (a few seconds if). CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2277) CLASSPATH for locating HDFS jar file is incorrect
[ https://issues.apache.org/jira/browse/HDFS-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089246#comment-13089246 ] Hadoop QA commented on HDFS-2277: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491299/HDFS-2277-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1145//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1145//artifact/trunk/target/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1145//console This message is automatically generated. CLASSPATH for locating HDFS jar file is incorrect - Key: HDFS-2277 URL: https://issues.apache.org/jira/browse/HDFS-2277 Project: Hadoop HDFS Issue Type: Bug Components: scripts Affects Versions: 0.23.0 Reporter: Eric Yang Assignee: Eric Yang Fix For: 0.23.0 Attachments: HDFS-2277-1.patch, HDFS-2277-2.patch, HDFS-2277.patch CLASSPATH for hdfs jar files should be set to HADOOP_PREFIX/share/hadoop/hdfs. Trunk code is looking for jar files in HADOOP_PREFIX/share/hadoop-hdfs. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
