[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532892#comment-14532892 ] Hudson commented on HDFS-2484: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2136 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2136/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532818#comment-14532818 ] Hudson commented on HDFS-2484: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #187 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/187/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532776#comment-14532776 ] Hudson commented on HDFS-2484: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #177 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/177/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532744#comment-14532744 ] Hudson commented on HDFS-2484: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2118 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2118/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532444#comment-14532444 ] Brahma Reddy Battula commented on HDFS-2484: [~shv] Please have look at following link.. https://wiki.apache.org/hadoop/2015MayBugBash > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532441#comment-14532441 ] Hudson commented on HDFS-2484: -- FAILURE: Integrated in Hadoop-Yarn-trunk #920 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/920/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532428#comment-14532428 ] Hudson commented on HDFS-2484: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #187 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/187/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531676#comment-14531676 ] Hudson commented on HDFS-2484: -- FAILURE: Integrated in Hadoop-trunk-Commit #7751 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7751/]) HDFS-2484. checkLease should throw FileNotFoundException when file does not exist. Contributed by Rakesh R. (shv: rev c75cfa29cfc527242837d80962688aa53c111e72) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLease.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531623#comment-14531623 ] Konstantin Shvachko commented on HDFS-2484: --- What is "BB2015-05-TBR" any way - some serial number, of what? > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-TBR > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529396#comment-14529396 ] Hadoop QA commented on HDFS-2484: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 34s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | javac | 7m 26s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 2m 14s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 33s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 3s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | native | 3m 15s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 171m 5s | Tests failed in hadoop-hdfs. | | | | 213m 44s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.namenode.TestFsck | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12730561/HDFS-2484.02.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / ffce9a3 | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10816/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10816/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10816/console | This message was automatically generated. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-RFC > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529302#comment-14529302 ] Konstantin Shvachko commented on HDFS-2484: --- +1 pending Jenkins. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-RFC > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529010#comment-14529010 ] Rakesh R commented on HDFS-2484: Thanks [~shv] for the comments. Attached another patch addressing the same. In unit tests, I've created another {{fileA}} to check the lease after its deletion. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-RFC > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch, > HDFS-2484.02.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528895#comment-14528895 ] Konstantin Shvachko commented on HDFS-2484: --- Hey Rakesh, your change looks good to me. - One improvement would be to move your test case under one of the existing tests rather than adding a new {{testLeaseWhenFileDoesntExists()}}. E.g., add the {{hflush()}} check at the end of {{testLease()}} after the directory is deleted. This will avoid re-spinning mini-cluster yet another time. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-RFC > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528351#comment-14528351 ] Rakesh R commented on HDFS-2484: It seems the test case failure {{hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate}} is not related to my patch. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Labels: BB2015-05-RFC > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526655#comment-14526655 ] Hadoop QA commented on HDFS-2484: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 55s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | javac | 7m 38s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 47s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 2m 14s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 35s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 7s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | native | 3m 23s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 165m 18s | Tests failed in hadoop-hdfs. | | | | 208m 58s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12730153/HDFS-2484.01.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / bb9ddef | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10778/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10778/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10778/console | This message was automatically generated. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Attachments: HDFS-2484.00.patch, HDFS-2484.01.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526455#comment-14526455 ] Hadoop QA commented on HDFS-2484: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 28s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 2m 11s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 35s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 4s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | native | 3m 14s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 166m 34s | Tests failed in hadoop-hdfs. | | | | 209m 24s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.TestFileCreation | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12730023/HDFS-2484.00.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / a319771 | | whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/10774/artifact/patchprocess/whitespace.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10774/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10774/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10774/console | This message was automatically generated. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko >Assignee: Rakesh R > Attachments: HDFS-2484.00.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525822#comment-14525822 ] Rakesh R commented on HDFS-2484: Thanks [~shv] for the details and that makes sense to me. I've attached patch with unit test, please have a look at it when you get a chance. {quote}if (isFileDeleted(file)) { I don't think this code path is ever triggered except probably when src is deleted while in a snapshot, which will be inconsistent with the regular case (deletion without a snapshot) {quote} Yes, I also feel the same. In my patch I haven't touch this validation part as I'm thinking this may be written to handle any special case which is unknown to me right now. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko > Attachments: HDFS-2484.00.patch > > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519728#comment-14519728 ] Konstantin Shvachko commented on HDFS-2484: --- Rakesh, if you look further down in {{checkLease()}} you see {code} if (isFileDeleted(file)) { throw new FileNotFoundException(src); } {code} I don't think this code path is ever triggered except probably when {{src}} is deleted while in a snapshot, which will be inconsistent with the regular case (deletion without a snapshot), as the latter will throw LeaseExpiredException. I am just saying {{FileNotFoundException}} is a more appropriate message for the client, since lease expiration is a consequence of file being deleted, so why not report just that. > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519015#comment-14519015 ] Rakesh R commented on HDFS-2484: Thanks [~shv] for reporting this. I could see {{FSNamesystem#checkLease}} has the following checks in branch-2 and trunk, does this validation satisfy your case? . [FSNamesystem#checkLease logic|https://github.com/apache/hadoop/blob/branch-2.7/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java#L3417] {code} if (inode == null) { Lease lease = leaseManager.getLease(holder); throw new LeaseExpiredException( "No lease on " + ident + ": File does not exist. " + (lease != null ? lease.toString() : "Holder " + holder + " does not have any open files.")); } {code} > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 0.22.0, 2.0.0-alpha >Reporter: Konstantin Shvachko > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2484) checkLease should throw FileNotFoundException when file does not exist
[ https://issues.apache.org/jira/browse/HDFS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132498#comment-13132498 ] Konstantin Shvachko commented on HDFS-2484: --- The exception is like this: {code} 2011-10-21 00:17:52,610 WARN org.apache.hadoop.fs.slive.CreateOp: Error with creating org.apache.hadoop.hdfs.server.namenode.LeaseExpiredException: No lease on /test/slive/slive/data/sl_dir_26/sl_file_5 File does not exist. Holder DFSClient_attempt_201110141824_0140_m_000164_0 does not have any open files. at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:1729) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:1720) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFileInternal(FSNamesystem.java:1775) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.completeFile(FSNamesystem.java:1758) at org.apache.hadoop.hdfs.server.namenode.NameNode.completeInternal(NameNode.java:953) at org.apache.hadoop.hdfs.server.namenode.NameNode.complete(NameNode.java:942) at sun.reflect.GeneratedMethodAccessor20.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.ipc.WritableRpcEngine$Server.call(WritableRpcEngine.java:349) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1482) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1478) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1153) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:1476) at org.apache.hadoop.ipc.Client.call(Client.java:1028) at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:198) at $Proxy1.complete(Unknown Source) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:84) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:59) at $Proxy1.complete(Unknown Source) at org.apache.hadoop.hdfs.DFSOutputStream.completeFile(DFSOutputStream.java:1518) at org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:1505) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:66) at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:91) at org.apache.hadoop.fs.slive.CreateOp.run(CreateOp.java:152) at org.apache.hadoop.fs.slive.ObserveableOp.run(ObserveableOp.java:63) at org.apache.hadoop.fs.slive.SliveMapper.runOperation(SliveMapper.java:136) at org.apache.hadoop.fs.slive.SliveMapper.map(SliveMapper.java:179) at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54) at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:389) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:322) at org.apache.hadoop.mapred.Child$4.run(Child.java:223) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:396) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1153) at org.apache.hadoop.mapred.Child.main(Child.java:217) {code} > checkLease should throw FileNotFoundException when file does not exist > -- > > Key: HDFS-2484 > URL: https://issues.apache.org/jira/browse/HDFS-2484 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.22.0, 0.24.0 >Reporter: Konstantin Shvachko > > When file is deleted during its creation {{FSNamesystem.checkLease(String > src, String holder)}} throws {{LeaseExpiredException}}. It would be more > informative if it thrown {{FileNotFoundException}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira