[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022605#comment-17022605 ] Wei-Chiu Chuang commented on HDFS-2538: --- I'm in favor of reducing the frequency of dots (posted my comments in HDFS-7175) > option to disable fsck dots > > > Key: HDFS-2538 > URL: https://issues.apache.org/jira/browse/HDFS-2538 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.2.0 >Reporter: Allen Wittenauer >Assignee: Mohammad Islam >Priority: Minor > Labels: newbie > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-2538-branch-0.20-security-204.patch, > HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, > HDFS-2538-branch-2.7.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, > HDFS-2538.3.patch > > > this patch turns the dots during fsck off by default and provides an option > to turn them back on if you have a fetish for millions and millions of dots > on your terminal. i haven't done any benchmarks, but i suspect fsck is now > 300% faster to boot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022564#comment-17022564 ] Stephen O'Donnell commented on HDFS-2538: - We (Cloudera) are seeing a lot of problems with this change recently, now clusters are starting to upgrade to the 3.x release branches. Users are finding fsck times out when it did not before, and understandably have no idea why. I think the simplest solution, is to switch the default back to printing the dots, but offer a -quiet option to suppress them for those who know what they are doing. As this will cause fsck to fail on large clusters, the quiet option seems kind of pointless, so I am even inclined to suggest we simply revert this change via a new Jira. Does anyone have any opinion on this approach (-quiet switch or complete revert)? I know there was some discussion in HDFS-7175, but no consensus was reached there. Perhaps a compromise is to reduce the frequency of the dots to reduce the overall output size. [~arpaga] [~weichiu] may have some thoughts here too? > option to disable fsck dots > > > Key: HDFS-2538 > URL: https://issues.apache.org/jira/browse/HDFS-2538 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.2.0 >Reporter: Allen Wittenauer >Assignee: Mohammad Islam >Priority: Minor > Labels: newbie > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-2538-branch-0.20-security-204.patch, > HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, > HDFS-2538-branch-2.7.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, > HDFS-2538.3.patch > > > this patch turns the dots during fsck off by default and provides an option > to turn them back on if you have a fetish for millions and millions of dots > on your terminal. i haven't done any benchmarks, but i suspect fsck is now > 300% faster to boot. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021982#comment-16021982 ] Konstantin Shvachko commented on HDFS-2538: --- Hey guys, I think if we reverse the default to print with dots, this is not incompatible. So let's keep it for now. Let me check with [~cwsteinbach] if he remembers the context behind HDFS-7175 before final decision. > option to disable fsck dots > > > Key: HDFS-2538 > URL: https://issues.apache.org/jira/browse/HDFS-2538 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 2.2.0 >Reporter: Allen Wittenauer >Assignee: Mohammad Kamrul Islam >Priority: Minor > Labels: newbie, release-blocker > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch, > HDFS-2538-branch-0.20-security-204.patch, > HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, > HDFS-2538-branch-2.7.patch > > > this patch turns the dots during fsck off by default and provides an option > to turn them back on if you have a fetish for millions and millions of dots > on your terminal. i haven't done any benchmarks, but i suspect fsck is now > 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020357#comment-16020357 ] Akira Ajisaka commented on HDFS-2538: - bq. shall we remove 2.7.4 from target version and releaseblocker from label..? I think yes. > option to disable fsck dots > > > Key: HDFS-2538 > URL: https://issues.apache.org/jira/browse/HDFS-2538 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 2.2.0 >Reporter: Allen Wittenauer >Assignee: Mohammad Kamrul Islam >Priority: Minor > Labels: newbie, release-blocker > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch, > HDFS-2538-branch-0.20-security-204.patch, > HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, > HDFS-2538-branch-2.7.patch > > > this patch turns the dots during fsck off by default and provides an option > to turn them back on if you have a fetish for millions and millions of dots > on your terminal. i haven't done any benchmarks, but i suspect fsck is now > 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[
https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019981#comment-16019981
]
Brahma Reddy Battula commented on HDFS-2538:
shall we remove {{2.7.4}} from target version and {{releaseblocker}} from
label..?
> option to disable fsck dots
>
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Allen Wittenauer
>Assignee: Mohammad Kamrul Islam
>Priority: Minor
> Labels: newbie, release-blocker
> Fix For: 3.0.0-alpha1
>
> Attachments: HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch,
> HDFS-2538-branch-0.20-security-204.patch,
> HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch,
> HDFS-2538-branch-2.7.patch
>
>
> this patch turns the dots during fsck off by default and provides an option
> to turn them back on if you have a fetish for millions and millions of dots
> on your terminal. i haven't done any benchmarks, but i suspect fsck is now
> 300% faster to boot.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015090#comment-16015090 ] Inigo Goiri commented on HDFS-2538: --- [~brahmareddy] mentions, this is an incompatible change and there was some controversy. [~shv], feel free to ignore and close the JIRA again but remove the 2.7.4 flag. > option to disable fsck dots > > > Key: HDFS-2538 > URL: https://issues.apache.org/jira/browse/HDFS-2538 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 2.2.0 >Reporter: Allen Wittenauer >Assignee: Mohammad Kamrul Islam >Priority: Minor > Labels: newbie, release-blocker > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch, > HDFS-2538-branch-0.20-security-204.patch, > HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, > HDFS-2538-branch-2.7.patch > > > this patch turns the dots during fsck off by default and provides an option > to turn them back on if you have a fetish for millions and millions of dots > on your terminal. i haven't done any benchmarks, but i suspect fsck is now > 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004490#comment-16004490 ] Brahma Reddy Battula commented on HDFS-2538: [~shv] IMO we no need to backport this, since this incompatible change (even there is open broken jira HDFS-7175). As per versioning rule [here|http://hadoop.apache.org/versioning.html],I think, we should not add incompatible changes to dot and minor releases..? > option to disable fsck dots > > > Key: HDFS-2538 > URL: https://issues.apache.org/jira/browse/HDFS-2538 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 2.2.0 >Reporter: Allen Wittenauer >Assignee: Mohammad Kamrul Islam >Priority: Minor > Labels: newbie, release-blocker > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch, > HDFS-2538-branch-0.20-security-204.patch, > HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch > > > this patch turns the dots during fsck off by default and provides an option > to turn them back on if you have a fetish for millions and millions of dots > on your terminal. i haven't done any benchmarks, but i suspect fsck is now > 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154397#comment-14154397 ] Akira AJISAKA commented on HDFS-2538: - After HDFS-2538, fsck can fail by SocketTimeoutException. This issue is tracked by HDFS-7175. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Fix For: 3.0.0 Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064798#comment-14064798 ] Hudson commented on HDFS-2538: -- FAILURE: Integrated in Hadoop-Yarn-trunk #615 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/615/]) HDFS-2538. option to disable fsck dots. Contributed by Mohammad Kamrul Islam. (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1611220) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Fix For: 3.0.0 Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064905#comment-14064905 ] Hudson commented on HDFS-2538: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1834 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1834/]) HDFS-2538. option to disable fsck dots. Contributed by Mohammad Kamrul Islam. (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1611220) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Fix For: 3.0.0 Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064926#comment-14064926 ] Hudson commented on HDFS-2538: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1807 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1807/]) HDFS-2538. option to disable fsck dots. Contributed by Mohammad Kamrul Islam. (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1611220) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Fix For: 3.0.0 Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064398#comment-14064398 ] Hudson commented on HDFS-2538: -- FAILURE: Integrated in Hadoop-trunk-Commit #5895 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5895/]) HDFS-2538. option to disable fsck dots. Contributed by Mohammad Kamrul Islam. (aw: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1611220) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSck.java option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Fix For: 3.0.0 Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064536#comment-14064536 ] Allen Wittenauer commented on HDFS-2538: Failure came from YARN-2219. Nothing to worry about. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Fix For: 3.0.0 Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915118#comment-13915118 ] Jakob Homan commented on HDFS-2538: --- Anyone have concerns over the plan to make this backwards incompatible, apply to trunk and not apply to branch? That's my intention. Speak now, yadda, yadda. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[
https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915379#comment-13915379
]
Hadoop QA commented on HDFS-2538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631611/HDFS-2538.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6260//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6260//console
This message is automatically generated.
option to disable fsck dots
Key: HDFS-2538
URL: https://issues.apache.org/jira/browse/HDFS-2538
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.2.0
Reporter: Allen Wittenauer
Assignee: Mohammad Kamrul Islam
Priority: Minor
Labels: newbie
Attachments: HDFS-2538-branch-0.20-security-204.patch,
HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch,
HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch
this patch turns the dots during fsck off by default and provides an option
to turn them back on if you have a fetish for millions and millions of dots
on your terminal. i haven't done any benchmarks, but i suspect fsck is now
300% faster to boot.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915481#comment-13915481 ] Allen Wittenauer commented on HDFS-2538: As long as the patch goes in with the default off, it's fine. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch, HDFS-2538.3.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911818#comment-13911818 ] Akira AJISAKA commented on HDFS-2538: - The test failure is not related to the latest patch. bq. What could possibly break by removing the dots? Unfortunately, users may use the scripts to run fsck which assume that dots are output in the console. [~kamrul], can you please update the document also? The document is in hadoop-common-project/hadoop-common/src/site/apt/CommandsManual.apt.vm. I'm +1 once it is addressed. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911855#comment-13911855 ] Jakob Homan commented on HDFS-2538: --- I'm willing to do the silent default and mark as incompatible on trunk, but not back to a branch. If the consensus is to do so, we can patch trunk and leave the branch patch for those who wish it. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911886#comment-13911886 ] Akira AJISAKA commented on HDFS-2538: - I agree. I suppose it would be better to do the silent default and mark as incompatible on trunk, and add -quiet option in branch-2. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911897#comment-13911897 ] Jakob Homan commented on HDFS-2538: --- No, I don't want extra options and differing capabilities running around. If I commit an incompatible change on trunk, I don't want to apply a different patch to the branch. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911954#comment-13911954 ] Akira AJISAKA commented on HDFS-2538: - bq. If I commit an incompatible change on trunk, I don't want to apply a different patch to the branch. I understand that. Thank you, [~jghoman]. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch, HDFS-2538.2.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910640#comment-13910640 ] Akira AJISAKA commented on HDFS-2538: - The test failure is not related to the patch. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910651#comment-13910651 ] Jakob Homan commented on HDFS-2538: --- Line: 46: Need a dash in the option. Also, this does need to have the dots on by default for compatibility. Option should be -quiet or -noprogress to suppress them. option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910796#comment-13910796 ] Allen Wittenauer commented on HDFS-2538: bq. Also, this does need to have the dots on by default for compatibility. I humbly and respectfully disagree. The key question is compatibility against what? We're talking about command line output that I suspect the vast majority of people are filtering out and has *no* stability label that I'm aware of. What could possibly break by removing the dots? option to disable fsck dots Key: HDFS-2538 URL: https://issues.apache.org/jira/browse/HDFS-2538 Project: Hadoop HDFS Issue Type: Improvement Affects Versions: 2.2.0 Reporter: Allen Wittenauer Assignee: Mohammad Kamrul Islam Priority: Minor Labels: newbie Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch, HDFS-2538.1.patch this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[
https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910980#comment-13910980
]
Hadoop QA commented on HDFS-2538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630797/HDFS-2538.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6220//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6220//console
This message is automatically generated.
option to disable fsck dots
Key: HDFS-2538
URL: https://issues.apache.org/jira/browse/HDFS-2538
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.2.0
Reporter: Allen Wittenauer
Assignee: Mohammad Kamrul Islam
Priority: Minor
Labels: newbie
Attachments: HDFS-2538-branch-0.20-security-204.patch,
HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch,
HDFS-2538.1.patch, HDFS-2538.2.patch
this patch turns the dots during fsck off by default and provides an option
to turn them back on if you have a fetish for millions and millions of dots
on your terminal. i haven't done any benchmarks, but i suspect fsck is now
300% faster to boot.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-2538) option to disable fsck dots
[
https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909172#comment-13909172
]
Hadoop QA commented on HDFS-2538:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630407/HDFS-2538.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6211//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6211//console
This message is automatically generated.
option to disable fsck dots
Key: HDFS-2538
URL: https://issues.apache.org/jira/browse/HDFS-2538
Project: Hadoop HDFS
Issue Type: Improvement
Affects Versions: 2.2.0
Reporter: Allen Wittenauer
Assignee: Mohammad Kamrul Islam
Priority: Minor
Labels: newbie
Attachments: HDFS-2538-branch-0.20-security-204.patch,
HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch,
HDFS-2538.1.patch
this patch turns the dots during fsck off by default and provides an option
to turn them back on if you have a fetish for millions and millions of dots
on your terminal. i haven't done any benchmarks, but i suspect fsck is now
300% faster to boot.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
