[jira] [Commented] (HDFS-3735) [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting
[
https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469181#comment-13469181
]
Hadoop QA commented on HDFS-3735:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12547669/HDFS-3735-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3264//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3264//console
This message is automatically generated.
[ NNUI -- NNJspHelper.java ] Last three fields not considered for display
data in sorting
--
Key: HDFS-3735
URL: https://issues.apache.org/jira/browse/HDFS-3735
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 2.0.0-alpha, 2.0.1-alpha
Reporter: Brahma Reddy Battula
Priority: Minor
Attachments: HDFS-3735-1.patch, HDFS-3735.patch
Live datanode list is not correctly sorted for columns Block Pool Used (GB),
Block Pool Used (%) and Failed Volumes. Read comments for more details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3735) [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting
[
https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13464584#comment-13464584
]
Hadoop QA commented on HDFS-3735:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12546285/HDFS-3735.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3242//console
This message is automatically generated.
[ NNUI -- NNJspHelper.java ] Last three fields not considered for display
data in sorting
--
Key: HDFS-3735
URL: https://issues.apache.org/jira/browse/HDFS-3735
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 2.0.0-alpha, 2.0.1-alpha
Reporter: Brahma Reddy Battula
Priority: Minor
Attachments: HDFS-3735.patch
Live datanode list is not correctly sorted for columns Block Pool Used (GB),
Block Pool Used (%) and Failed Volumes. Read comments for more details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3735) [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting
[ https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461733#comment-13461733 ] Brahma Reddy Battula commented on HDFS-3735: Hey Suresh And Raju, Please review the patch...I really forgot this issue..sorry for late response.. [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting -- Key: HDFS-3735 URL: https://issues.apache.org/jira/browse/HDFS-3735 Project: Hadoop HDFS Issue Type: Bug Components: name-node Affects Versions: 2.0.0-alpha, 2.0.1-alpha Reporter: Brahma Reddy Battula Priority: Minor Attachments: HDFS-3735.patch Live datanode list is not correctly sorted for columns Block Pool Used (GB), Block Pool Used (%) and Failed Volumes. Read comments for more details. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3735) [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting
[
https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427150#comment-13427150
]
Brahma Reddy Battula commented on HDFS-3735:
Hi Suresh,
Thanks for taking look,I have fixed and verified manually.It's working fine.
Added following in *JspHelper.java*
method : NodeComapare
{code}
} else if (field.equals(bpused)) {
sortField = FIELD_BP_USED;
}else if (field.equals(pcbpused)) {
sortField = FIELD_PERCENT_BP_USED;
}else if (field.equals(volfails)) {
sortField = FIELD_FAILED_VOL;
}
{code}
method : compare
{code}
case FIELD_BP_USED:
dlong = d1.getBlockPoolUsed() - d2.getBlockPoolUsed();
ret = (dlong 0) ? -1 : ((dlong 0) ? 1 : 0);
break;
case FIELD_PERCENT_BP_USED:
ddbl =((d1.getBlockPoolUsedPercent())-
(d2.getBlockPoolUsedPercent()));
ret = (ddbl 0) ? -1 : ((ddbl 0) ? 1 : 0);
break;
case FIELD_FAILED_VOL:
ret = d1.getVolumeFailures() - d2.getVolumeFailures();
break;
{code}
Will post the patch once testcase written(need to write).
[ NNUI -- NNJspHelper.java ] Last three fields not considered for display
data in sorting
--
Key: HDFS-3735
URL: https://issues.apache.org/jira/browse/HDFS-3735
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 2.0.0-alpha, 2.0.1-alpha
Reporter: Brahma Reddy Battula
Priority: Minor
Live datanode list is not correctly sorted for columns Block Pool Used (GB),
Block Pool Used (%) and Failed Volumes. Read comments for more details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3735) [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting
[
https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13427400#comment-13427400
]
Raju commented on HDFS-3735:
Hey Brahma,
{code}
case FIELD_FAILED_VOL:
ret = d1.getVolumeFailures() - d2.getVolumeFailures();
break;
{code}
Since we are using this code in comparator its good to return -1,0 or 1 as its
return value. Even without that with current fix it will work. But in general
the mentioned values are returned.
[ NNUI -- NNJspHelper.java ] Last three fields not considered for display
data in sorting
--
Key: HDFS-3735
URL: https://issues.apache.org/jira/browse/HDFS-3735
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 2.0.0-alpha, 2.0.1-alpha
Reporter: Brahma Reddy Battula
Priority: Minor
Live datanode list is not correctly sorted for columns Block Pool Used (GB),
Block Pool Used (%) and Failed Volumes. Read comments for more details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3735) [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting
[ https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426197#comment-13426197 ] Suresh Srinivas commented on HDFS-3735: --- Brahma, can you please keep the description of the jira short and add the details in a comment later. Your analysis seems to be correct. Please post a patch, I will review it and commit it. [ NNUI -- NNJspHelper.java ] Last three fields not considered for display data in sorting -- Key: HDFS-3735 URL: https://issues.apache.org/jira/browse/HDFS-3735 Project: Hadoop HDFS Issue Type: Bug Components: name-node Affects Versions: 2.0.0-alpha, 2.0.1-alpha Reporter: Brahma Reddy Battula Priority: Minor Live datanode list is not correctly sorted for columns Block Pool Used (GB), Block Pool Used (%) and Failed Volumes. Read comments for more details. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
