[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634617#comment-14634617
]
Vinayakumar B commented on HDFS-6300:
-
Thanks [~atm] for the heads-up. I have resolved HDFS-4505 as duplicate.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634192#comment-14634192
]
Aaron T. Myers commented on HDFS-6300:
--
Given these recent fixes, do we think that HDFS-4505 is now obsolete and should
therefore be closed?
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543523#comment-14543523
]
Hudson commented on HDFS-6300:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #927 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/927/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543579#comment-14543579
]
Hudson commented on HDFS-6300:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #196 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/196/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543854#comment-14543854
]
Hudson commented on HDFS-6300:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #185 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/185/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543816#comment-14543816
]
Hudson commented on HDFS-6300:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2125 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2125/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541761#comment-14541761
]
Hadoop QA commented on HDFS-6300:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 58s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 41s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 18s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 6s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 21s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 166m 40s | Tests failed in hadoop-hdfs. |
| | | 210m 19s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.tracing.TestTraceAdmin |
| | hadoop.hdfs.TestDFSRename |
| | hadoop.tools.TestHdfsConfigFields |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732507/HDFS-6300-006.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / e82067b |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10951/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10951/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10951/console |
This message was automatically generated.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541678#comment-14541678
]
Hadoop QA commented on HDFS-6300:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 33s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 32s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 49s | There were no new checkstyle
issues. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 7s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 165m 35s | Tests failed in hadoop-hdfs. |
| | | 206m 49s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.tools.TestHdfsConfigFields |
| | hadoop.tracing.TestTraceAdmin |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732492/HDFS-6300-005.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / fcd0702 |
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/10949/artifact/patchprocess/whitespace.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10949/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10949/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10949/console |
This message was automatically generated.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541788#comment-14541788
]
Vinayakumar B commented on HDFS-6300:
-
+1 for latest patch.
Will commit soon.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541867#comment-14541867
]
Hudson commented on HDFS-6300:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7814 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7814/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541824#comment-14541824
]
Rakesh R commented on HDFS-6300:
Thank you [~szetszwo], [~aw] for reviews. Thank you [~vinayrpet] for reviewing
and committing the changes!
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542380#comment-14542380
]
Tsz Wo Nicholas Sze commented on HDFS-6300:
---
Expectation of create with overwrite on open file was changed in HDFS-3755.
Before this, NN used to throw AlreadyBeingCreatedException. So there was no
problem.
[~vinayrpet], thanks for tracing the cause and committing the patch.
[~rakeshr], thanks for the great work!
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542157#comment-14542157
]
Hudson commented on HDFS-6300:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542112#comment-14542112
]
Hudson commented on HDFS-6300:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/])
HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed
by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Fix For: 2.7.1
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541442#comment-14541442
]
Rakesh R commented on HDFS-6300:
I think its good to merge two test cases under one unit test, it would avoid
start another cluster again. Attached the modified patch to the jira.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541515#comment-14541515
]
Vinayakumar B commented on HDFS-6300:
-
Latest patch looks good.
One nit in test.
{code{// release lease so that another balancer would run
assertTrue(Failed to run first balancer!,
fs.exists(Balancer.BALANCER_ID_PATH));{code}
comment is irrelevant here.
+1 once addressed.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541543#comment-14541543
]
Hadoop QA commented on HDFS-6300:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 59s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 38s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 46s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 13s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 6s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 20s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 142m 49s | Tests failed in hadoop-hdfs. |
| | | 186m 24s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.tracing.TestTraceAdmin |
| | hadoop.tools.TestHdfsConfigFields |
| | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
| | hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade |
| Timed out tests | org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732476/HDFS-6300-004.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / fcd0702 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10946/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10946/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10946/console |
This message was automatically generated.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541567#comment-14541567
]
Rakesh R commented on HDFS-6300:
Thanks [~vinayrpet]. Attached another patch addressing the comments.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300-005.patch,
HDFS-6300-006.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6300) Prevent multiple balancers from running simultaneously
[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541302#comment-14541302
]
Rakesh R commented on HDFS-6300:
Thanks [~szetszwo]. Attached another patch addressing the previous comments.
Also, I've tried one more test case to simulate the case where another balancer
successfully performs {{append}} operation and gone ahead with balancing.
Kindly review the patch again.
Prevent multiple balancers from running simultaneously
--
Key: HDFS-6300
URL: https://issues.apache.org/jira/browse/HDFS-6300
Project: Hadoop HDFS
Issue Type: Bug
Components: balancer mover
Reporter: Rakesh R
Assignee: Rakesh R
Priority: Critical
Labels: BB2015-05-RFC
Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
HDFS-6300-003.patch, HDFS-6300-004.patch, HDFS-6300.patch
Javadoc of Balancer.java says, it will not allow to run second balancer if
the first one is in progress. But I've noticed multiple can run together and
balancer.id implementation is not safe guarding.
{code}
* liAnother balancer is running. Exiting...
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
