[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031550#comment-14031550 ] Hudson commented on HDFS-6330: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #583 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/583/]) HDFS-6330. Move mkdirs() to FSNamesystem. Contributed by Haohui Mai. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1602484) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsLimits.java Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.5.0 Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch, HDFS-6330.003.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031574#comment-14031574 ] Hudson commented on HDFS-6330: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1774 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1774/]) HDFS-6330. Move mkdirs() to FSNamesystem. Contributed by Haohui Mai. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1602484) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsLimits.java Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.5.0 Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch, HDFS-6330.003.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031594#comment-14031594 ] Hudson commented on HDFS-6330: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1801 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1801/]) HDFS-6330. Move mkdirs() to FSNamesystem. Contributed by Haohui Mai. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1602484) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsLimits.java Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.5.0 Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch, HDFS-6330.003.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030988#comment-14030988 ] Hudson commented on HDFS-6330: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5702 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5702/]) HDFS-6330. Move mkdirs() to FSNamesystem. Contributed by Haohui Mai. (wheat9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1602484) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsLimits.java Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.5.0 Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch, HDFS-6330.003.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029640#comment-14029640 ] Jing Zhao commented on HDFS-6330: - +1 Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch, HDFS-6330.003.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029643#comment-14029643 ] Haohui Mai commented on HDFS-6330: -- Thanks [~jingzhao] for the review. I'll commit it later today if there is no more comments. Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch, HDFS-6330.003.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[ https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028073#comment-14028073 ] Haohui Mai commented on HDFS-6330: -- The v2 patch addresses Jing's comments. Move mkdirs() to FSNamesystem - Key: HDFS-6330 URL: https://issues.apache.org/jira/browse/HDFS-6330 Project: Hadoop HDFS Issue Type: Sub-task Components: namenode Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch, HDFS-6330.002.patch Currently mkdir() automatically creates all ancestors for a directory. This is implemented in FSDirectory, by calling unprotectedMkdir() along the path. This jira proposes to move the function to FSNamesystem to simplify the primitive that FSDirectory needs to provide. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[
https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028350#comment-14028350
]
Hadoop QA commented on HDFS-6330:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12649835/HDFS-6330.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7084//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7084//console
This message is automatically generated.
Move mkdirs() to FSNamesystem
-
Key: HDFS-6330
URL: https://issues.apache.org/jira/browse/HDFS-6330
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch,
HDFS-6330.002.patch
Currently mkdir() automatically creates all ancestors for a directory. This
is implemented in FSDirectory, by calling unprotectedMkdir() along the path.
This jira proposes to move the function to FSNamesystem to simplify the
primitive that FSDirectory needs to provide.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[
https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028586#comment-14028586
]
Haohui Mai commented on HDFS-6330:
--
The v3 patch updates the comments of {{addSymlink()}}. [~daryn], do you have
any more comments?
Move mkdirs() to FSNamesystem
-
Key: HDFS-6330
URL: https://issues.apache.org/jira/browse/HDFS-6330
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch,
HDFS-6330.002.patch, HDFS-6330.003.patch
Currently mkdir() automatically creates all ancestors for a directory. This
is implemented in FSDirectory, by calling unprotectedMkdir() along the path.
This jira proposes to move the function to FSNamesystem to simplify the
primitive that FSDirectory needs to provide.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[
https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028765#comment-14028765
]
Hadoop QA commented on HDFS-6330:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12649947/HDFS-6330.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7091//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7091//console
This message is automatically generated.
Move mkdirs() to FSNamesystem
-
Key: HDFS-6330
URL: https://issues.apache.org/jira/browse/HDFS-6330
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch,
HDFS-6330.002.patch, HDFS-6330.003.patch
Currently mkdir() automatically creates all ancestors for a directory. This
is implemented in FSDirectory, by calling unprotectedMkdir() along the path.
This jira proposes to move the function to FSNamesystem to simplify the
primitive that FSDirectory needs to provide.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6330) Move mkdirs() to FSNamesystem
[
https://issues.apache.org/jira/browse/HDFS-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025730#comment-14025730
]
Jing Zhao commented on HDFS-6330:
-
The patch looks good to me. Some minors:
# Let's use this chance to remove the empty javadoc of FSDirectory#normalizePath
# The following change may be unnecessary?
{code}
- blockManager.getDatanodeManager().clearPendingCachingCommands();
- blockManager.getDatanodeManager().setShouldSendCachingCommands(false);
- // Don't want to keep replication queues when not in Active.
- blockManager.clearQueues();
+ if (blockManager != null) {
+blockManager.getDatanodeManager().clearPendingCachingCommands();
+blockManager.getDatanodeManager().setShouldSendCachingCommands(false);
+// Don't want to keep replication queues when not in Active.
+blockManager.clearQueues();
+ }
{code}
# Nit: Some lines exceed the 80 character limit (e.g., mkdirsRecursively and
addSymlink).
# We may need to update the log information in mkdirsRecursively since it's no
longer a FSDirectory call.
Move mkdirs() to FSNamesystem
-
Key: HDFS-6330
URL: https://issues.apache.org/jira/browse/HDFS-6330
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6330.000.patch, HDFS-6330.001.patch
Currently mkdir() automatically creates all ancestors for a directory. This
is implemented in FSDirectory, by calling unprotectedMkdir() along the path.
This jira proposes to move the function to FSNamesystem to simplify the
primitive that FSDirectory needs to provide.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
