[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041851#comment-14041851
]
Hudson commented on HDFS-6562:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5757 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5757/])
HDFS-6562. Refactor rename() in FSDirectory. Contributed by Haohui Mai.
(wheat9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1605016)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Priority: Minor
Fix For: 2.5.0
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch, HDFS-6562.007.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041990#comment-14041990
]
Hudson commented on HDFS-6562:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #593 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/593/])
HDFS-6562. Refactor rename() in FSDirectory. Contributed by Haohui Mai.
(wheat9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1605016)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Priority: Minor
Fix For: 2.5.0
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch, HDFS-6562.007.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042144#comment-14042144
]
Hudson commented on HDFS-6562:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1784 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1784/])
HDFS-6562. Refactor rename() in FSDirectory. Contributed by Haohui Mai.
(wheat9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1605016)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Priority: Minor
Fix For: 2.5.0
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch, HDFS-6562.007.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042228#comment-14042228
]
Hudson commented on HDFS-6562:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1811 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1811/])
HDFS-6562. Refactor rename() in FSDirectory. Contributed by Haohui Mai.
(wheat9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1605016)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Priority: Minor
Fix For: 2.5.0
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch, HDFS-6562.007.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041065#comment-14041065
]
Jing Zhao commented on HDFS-6562:
-
The new patch looks pretty good to me. +1
[~szetszwo], do you also want to take a look at the patch?
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041422#comment-14041422
]
Tsz Wo Nicholas Sze commented on HDFS-6562:
---
Patch looks good. Some comments:
- Before the patch, the first if-statement below thows to an exception. But it
will return false after the patch.
{code}
-if (srcInode.isSymlink()
-dst.equals(srcInode.asSymlink().getSymlinkString())) {
- throw new FileAlreadyExistsException(
- Cannot rename symlink +src+ to its target +dst);
-}
-
-// dst cannot be directory or a file under src
-if (dst.startsWith(src)
-dst.charAt(src.length()) == Path.SEPARATOR_CHAR) {
- NameNode.stateChangeLog.warn(DIR* FSDirectory.unprotectedRenameTo:
- + failed to rename + src + to + dst
- + because destination starts with src);
+
+try {
+ validateRenameDestination(src, dst, srcInode);
+} catch (IOException ignored) {
return false;
}
{code}
- prepare() should be combined with the RenameOperation constructor. Then all
the fields except srcChild can be changed to final.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041440#comment-14041440
]
Haohui Mai commented on HDFS-6562:
--
Uploaded v6 patch to address [~szetszwo]'s comments.
The changes about the symlinks are intentional. Please correct me if I'm wrong,
but it looks to me that the old rename prefers to returning {{false}} instead
of throwing exceptions. We can change this behavior without introducing
backward compatibility issues since symlink is only available in trunk.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041507#comment-14041507
]
Tsz Wo Nicholas Sze commented on HDFS-6562:
---
Thanks for the explanation. Returning false sounds good.
For the new patch,
- There are two srcChild = srcIIP.getLastINode() in the RenameOperation
constructor.
- The field srcRefDstSnapshot can be changed to final.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041656#comment-14041656
]
Hadoop QA commented on HDFS-6562:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12652097/HDFS-6562.007.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7218//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7218//console
This message is automatically generated.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Priority: Minor
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch,
HDFS-6562.005.patch, HDFS-6562.006.patch, HDFS-6562.007.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040064#comment-14040064
]
Haohui Mai commented on HDFS-6562:
--
Thanks [~jingzhao] and [~daryn] for the reviews. Uploaded v4 patch to address
the comments.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040100#comment-14040100
]
Hadoop QA commented on HDFS-6562:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651854/HDFS-6562.004.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7201//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7201//console
This message is automatically generated.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039426#comment-14039426
]
Daryn Sharp commented on HDFS-6562:
---
Are you sure this can't be a {{SnapshotAccessControlException}} (which seems
more appropriate) or tunneled out more cleanly?
{noformat}
+} catch (IOException e) {
+ // XXX: The client expects an exception in this case,
+ // and we can't subclass this exception due to backward compatibility
+ String msg = e.getMessage();
+ if (msg.contains( is snapshottable and already has snapshots)) {
{noformat}
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039444#comment-14039444
]
Jing Zhao commented on HDFS-6562:
-
Thanks for the refactoring, Haohui! Just finished reviewing the changes for the
old rename. Some comments:
# Maybe we can let checkSnapshot throw a SnapshotException instead of the
current general IOException. In this way for the old version rename, we do not
need to check the exception msg when validating the rename source.
# Maybe we can rename RenameTransaction to RenameOperation?
# In RenameTransaction, the initialization of srcChildName, isSrcInSnapshot, and
scrChildIsReference can be moved into the constructor so that they can still
be declared as final.
# Since we no longer have INode replacement, we do not need to replace the last
inode of the srcIIP. Simply calling srcChild.recordModification should be good
enough.
{code}
if (isSrcInSnapshot) {
srcChild = srcChild.recordModification(srcIIP.getLatestSnapshotId());
srcIIP.setLastINode(srcChild);
}
{code}
# Similarly I guess we do not need the following code any more:
{code}
if (dstParent.getParent() == null) {
// src and dst file/dir are in the same directory, and the dstParent has
// been replaced when we removed the src. Refresh the dstIIP and
// dstParent.
dstIIP = getINodesInPath4Write(dst, false);
}
{code}
And in removeLastINode(INodesInPath), we can remove the following code:
{code}
INodeDirectory newParent = last.getParent();
if (parent != newParent) {
iip.setINode(-2, newParent);
}
{code}
Will continue reviewing the new rename.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039474#comment-14039474
]
Jing Zhao commented on HDFS-6562:
-
Comments for the remaining changes:
# I guess we can even put srcParent as a final field in RenameTransaction since
we will not replace the parent INode anymore.
# Can we have a validateOverwrite method to cover all the checks when rename
destination exists (the checks in the if (dstInode != null) section)?
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038212#comment-14038212
]
Hadoop QA commented on HDFS-6562:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651524/HDFS-6562.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7181//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/7181//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7181//console
This message is automatically generated.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038457#comment-14038457
]
Hadoop QA commented on HDFS-6562:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651588/HDFS-6562.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7186//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7186//console
This message is automatically generated.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch,
HDFS-6562.002.patch, HDFS-6562.003.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory
[
https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036814#comment-14036814
]
Hadoop QA commented on HDFS-6562:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651291/HDFS-6562.000.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7169//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/7169//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7169//console
This message is automatically generated.
Refactor rename() in FSDirectory
Key: HDFS-6562
URL: https://issues.apache.org/jira/browse/HDFS-6562
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-6562.000.patch
Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}.
Both implementation shares quite a bit of common code.
This jira proposes to clean up these two variants and extract the common code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
