[jira] [Commented] (HDFS-6938) Cleanup javac warnings in FSNamesystem.java

2014-08-26 Thread Charles Lamb (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110798#comment-14110798
 ] 

Charles Lamb commented on HDFS-6938:


Since the diffs are only fixing unused imports and fields, no unit tests are 
necessary.


 Cleanup javac warnings in FSNamesystem.java
 ---

 Key: HDFS-6938
 URL: https://issues.apache.org/jira/browse/HDFS-6938
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Charles Lamb
Assignee: Charles Lamb
 Attachments: HDFS-6938.001.patch


 Clean up some unused code/compiler warnings post fs-encryption merge.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HDFS-6938) Cleanup javac warnings in FSNamesystem.java

2014-08-25 Thread Konstantin Shvachko (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109668#comment-14109668
 ] 

Konstantin Shvachko commented on HDFS-6938:
---

+1 looks good.

 Cleanup javac warnings in FSNamesystem.java
 ---

 Key: HDFS-6938
 URL: https://issues.apache.org/jira/browse/HDFS-6938
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Charles Lamb
Assignee: Charles Lamb
 Attachments: HDFS-6938.001.patch


 Clean up some unused code/compiler warnings post fs-encryption merge.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HDFS-6938) Cleanup javac warnings in FSNamesystem.java

2014-08-25 Thread Charles Lamb (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109725#comment-14109725
 ] 

Charles Lamb commented on HDFS-6938:


Thanks for the review [~shv].

Would you mind committing it? I'm not a committer.

Thanks.


 Cleanup javac warnings in FSNamesystem.java
 ---

 Key: HDFS-6938
 URL: https://issues.apache.org/jira/browse/HDFS-6938
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Charles Lamb
Assignee: Charles Lamb
 Attachments: HDFS-6938.001.patch


 Clean up some unused code/compiler warnings post fs-encryption merge.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HDFS-6938) Cleanup javac warnings in FSNamesystem.java

2014-08-25 Thread Haohui Mai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109870#comment-14109870
 ] 

Haohui Mai commented on HDFS-6938:
--

Submitting the patch to Jenkins.

 Cleanup javac warnings in FSNamesystem.java
 ---

 Key: HDFS-6938
 URL: https://issues.apache.org/jira/browse/HDFS-6938
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Charles Lamb
Assignee: Charles Lamb
 Attachments: HDFS-6938.001.patch


 Clean up some unused code/compiler warnings post fs-encryption merge.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HDFS-6938) Cleanup javac warnings in FSNamesystem.java

2014-08-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110021#comment-14110021
 ] 

Hadoop QA commented on HDFS-6938:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12664191/HDFS-6938.001.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The test build failed in 
hadoop-hdfs-project/hadoop-hdfs 

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/7757//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7757//console

This message is automatically generated.

 Cleanup javac warnings in FSNamesystem.java
 ---

 Key: HDFS-6938
 URL: https://issues.apache.org/jira/browse/HDFS-6938
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: namenode
Affects Versions: 3.0.0
Reporter: Charles Lamb
Assignee: Charles Lamb
 Attachments: HDFS-6938.001.patch


 Clean up some unused code/compiler warnings post fs-encryption merge.



--
This message was sent by Atlassian JIRA
(v6.2#6252)