[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149043#comment-14149043
]
Hudson commented on HDFS-7118:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #692 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/692/])
HDFS-7118. Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename. Contributed by Chris Nauroth. (cnauroth:
rev e0b1dc514f1b9e26b21d97ece0d94cd9c827fc59)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 2.6.0
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149183#comment-14149183
]
Hudson commented on HDFS-7118:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1883 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1883/])
HDFS-7118. Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename. Contributed by Chris Nauroth. (cnauroth:
rev e0b1dc514f1b9e26b21d97ece0d94cd9c827fc59)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 2.6.0
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149263#comment-14149263
]
Hudson commented on HDFS-7118:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1908 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1908/])
HDFS-7118. Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename. Contributed by Chris Nauroth. (cnauroth:
rev e0b1dc514f1b9e26b21d97ece0d94cd9c827fc59)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 2.6.0
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147536#comment-14147536
]
Hadoop QA commented on HDFS-7118:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671147/HDFS-7118.1.patch
against trunk revision 428a766.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8195//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8195//console
This message is automatically generated.
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147869#comment-14147869
]
Chris Nauroth commented on HDFS-7118:
-
The test failures are unrelated and tracked elsewhere.
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147910#comment-14147910
]
Suresh Srinivas commented on HDFS-7118:
---
+1 for the patch. [~cnauroth], thanks for doing this.
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147997#comment-14147997
]
Hudson commented on HDFS-7118:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6107 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6107/])
HDFS-7118. Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename. Contributed by Chris Nauroth. (cnauroth:
rev e0b1dc514f1b9e26b21d97ece0d94cd9c827fc59)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 2.6.0
Attachments: HDFS-7118.1.patch
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146767#comment-14146767
]
jay vyas commented on HDFS-7118:
Is this a hadoop common issue, or a HDFS specific issue?
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146784#comment-14146784
]
Chris Nauroth commented on HDFS-7118:
-
Hi, [~jayunit100]. In this case, it's an HDFS-specific issue. HDFS currently
calls {{java.io.File#renameTo}} in a few places, which doesn't propagate full
error details. We already implemented {{NativeIO#renameTo}} in hadoop-common a
while back to address similar issues. I don't anticipate any hadoop-common
changes as part of this. I think we'll just change HDFS code to call what
already exists in Common.
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Sub-task
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7118) Improve diagnostics on storage directory rename operations by using NativeIO#renameTo in Storage#rename.
[
https://issues.apache.org/jira/browse/HDFS-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143519#comment-14143519
]
Chris Nauroth commented on HDFS-7118:
-
See HDFS-4428 and HDFS-6499 for similar enhancements.
Improve diagnostics on storage directory rename operations by using
NativeIO#renameTo in Storage#rename.
Key: HDFS-7118
URL: https://issues.apache.org/jira/browse/HDFS-7118
Project: Hadoop HDFS
Issue Type: Improvement
Components: journal-node, namenode
Reporter: Chris Nauroth
Assignee: Chris Nauroth
If a file rename fails, {{NativeIO#renameTo}} includes more information about
the root cause than a plain {{java.io.File#renameTo}}. The native code can
throw an exception with a detailed error message and the {{errno}} on *nix or
the value of {{GetLastError}} on Windows. This issue proposes to use
{{NativeIO#renameTo}} inside or in place of {{Storage#rename}} to help
improve diagnostics. The method falls back to {{java.io.File#renameTo}} if
native code is not loaded, so this change would not introduce a compatibility
problem for deployments running without native code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
