[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14323843#comment-14323843
]
Hudson commented on HDFS-7790:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319865#comment-14319865
]
Hudson commented on HDFS-7790:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #103 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/103/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319899#comment-14319899
]
Hudson commented on HDFS-7790:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #837 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/837/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320141#comment-14320141
]
Hudson commented on HDFS-7790:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2035 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2035/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320236#comment-14320236
]
Hudson commented on HDFS-7790:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #104 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/104/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14320281#comment-14320281
]
Hudson commented on HDFS-7790:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2054 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2054/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319062#comment-14319062
]
Hadoop QA commented on HDFS-7790:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698504/HDFS-7790.001.patch
against trunk revision 83be450.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.hdfs.server.namenode.TestBackupNode
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9561//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9561//console
This message is automatically generated.
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319423#comment-14319423
]
Hudson commented on HDFS-7790:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7098 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7098/])
HDFS-7790. Do not create optional fields in DFSInputStream unless they are
needed (cmccabe) (cmccabe: rev 871cb56152e6039ff56c6fabfcd45451029471c3)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Fix For: 2.7.0
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
[
https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319122#comment-14319122
]
Aaron T. Myers commented on HDFS-7790:
--
Patch looks good to me, and I'm confident that the test failures are unrelated.
+1.
Do not create optional fields in DFSInputStream unless they are needed
--
Key: HDFS-7790
URL: https://issues.apache.org/jira/browse/HDFS-7790
Project: Hadoop HDFS
Issue Type: Improvement
Components: dfsclient
Affects Versions: 2.3.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HDFS-7790.001.patch
{{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}}
are only used some of the time, and they are always used under the positional
lock. Let's create them on demand to save memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
