[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021950#comment-15021950 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2568 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2568/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021654#comment-15021654 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021542#comment-15021542 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1435 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1435/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021507#comment-15021507 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2640 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2640/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021468#comment-15021468 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #710 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/710/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021462#comment-15021462 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #699 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/699/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021452#comment-15021452 ] Hudson commented on HDFS-7897: -- FAILURE: Integrated in Hadoop-trunk-Commit #8854 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8854/]) HDFS-7897. Shutdown metrics when stopping JournalNode. Contributed by (wheat9: rev a4bd54f9d776f39080b41913afa455f8c0f6e46d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021435#comment-15021435 ] Haohui Mai commented on HDFS-7897: -- +1. Ran the test locally and they passed. Committing. > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Labels: BB2015-05-TBR > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521202#comment-14521202 ] zhouyingchao commented on HDFS-7897: Any updates regarding this simple patch? > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[ https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350003#comment-14350003 ] zhouyingchao commented on HDFS-7897: I tried the patch on my computer with the two failed case reported by robot, both of them finish successfully. The failure should not be related with the patch. > Shutdown metrics when stopping JournalNode > -- > > Key: HDFS-7897 > URL: https://issues.apache.org/jira/browse/HDFS-7897 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: zhouyingchao >Assignee: zhouyingchao > Attachments: HDFS-7897-001.patch > > > In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue > is found when reading the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7897) Shutdown metrics when stopping JournalNode
[
https://issues.apache.org/jira/browse/HDFS-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349981#comment-14349981
]
Hadoop QA commented on HDFS-7897:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12702960/HDFS-7897-001.patch
against trunk revision 952640f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9762//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9762//console
This message is automatically generated.
> Shutdown metrics when stopping JournalNode
> --
>
> Key: HDFS-7897
> URL: https://issues.apache.org/jira/browse/HDFS-7897
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: zhouyingchao
>Assignee: zhouyingchao
> Attachments: HDFS-7897-001.patch
>
>
> In JournalNode.stop(), the metrics system is forgotten to shutdown. The issue
> is found when reading the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
