[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511073#comment-14511073 ] Hudson commented on HDFS-8215: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511035#comment-14511035 ] Hudson commented on HDFS-8215: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510930#comment-14510930 ] Hudson commented on HDFS-8215: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/907/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510891#comment-14510891 ] Hudson commented on HDFS-8215: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510872#comment-14510872 ] Hudson commented on HDFS-8215: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510855#comment-14510855 ] Hudson commented on HDFS-8215: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510348#comment-14510348 ] Takanobu Asanuma commented on HDFS-8215: Thank you very much for the review and the commit, Nicholas! > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509845#comment-14509845 ] Hudson commented on HDFS-8215: -- FAILURE: Integrated in Hadoop-trunk-Commit #7654 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7654/]) HDFS-8215. Refactor NamenodeFsck#check method. Contributed by Takanobu Asanuma (szetszwo: rev ef4e9963b25d7d2e30f1071ddcaa9d92a7fe70f3) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Refactor NamenodeFsck#check method > -- > > Key: HDFS-8215 > URL: https://issues.apache.org/jira/browse/HDFS-8215 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Takanobu Asanuma >Assignee: Takanobu Asanuma >Priority: Minor > Attachments: HDFS-8215.1.patch > > > This method is very long, approximately 230 lines. Splitting this method into > smaller methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8215) Refactor NamenodeFsck#check method
[
https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509704#comment-14509704
]
Hadoop QA commented on HDFS-8215:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 33s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 6m 55s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 6s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 175m 16s | Tests failed in hadoop-hdfs. |
| | | 222m 44s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestDFSClientRetries |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727591/HDFS-8215.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 189a63a |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10360/artifact/patchprocess/checkstyle-result-diff.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10360/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10360/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10360/console |
This message was automatically generated.
> Refactor NamenodeFsck#check method
> --
>
> Key: HDFS-8215
> URL: https://issues.apache.org/jira/browse/HDFS-8215
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
> Attachments: HDFS-8215.1.patch
>
>
> This method is very long, approximately 230 lines. Splitting this method into
> smaller methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
