[jira] [Commented] (HDFS-8227) BlockCollection should return Block instead of BlockInfoContiguous in the interfaces
[
https://issues.apache.org/jira/browse/HDFS-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510594#comment-14510594
]
Vinayakumar B commented on HDFS-8227:
-
I think these code cleanups are already done in HDFS-7285 branch to support
both continuous and striped blocks. So once HDFS-7285 is merged to trunk, then
thats enough IMO.
> BlockCollection should return Block instead of BlockInfoContiguous in the
> interfaces
>
>
> Key: HDFS-8227
> URL: https://issues.apache.org/jira/browse/HDFS-8227
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-8227.000.patch
>
>
> Currently the {{BlockCollection}} interface returns {{BlockInfoContiguous}}
> objects in multiple calls.
> In order to decouple block manager and the namespace, the interface should
> return the {{Block}} instead of {{BlockInfoContiguous}} objects, where the
> latter contain information like the locations of DN.
> This jira proposes to clean up the interface and to return the {{Block}}
> objects directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8227) BlockCollection should return Block instead of BlockInfoContiguous in the interfaces
[
https://issues.apache.org/jira/browse/HDFS-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510029#comment-14510029
]
Tsz Wo Nicholas Sze commented on HDFS-8227:
---
Should INodeFile and other file related class keep using BlockInfoContiguous?
> BlockCollection should return Block instead of BlockInfoContiguous in the
> interfaces
>
>
> Key: HDFS-8227
> URL: https://issues.apache.org/jira/browse/HDFS-8227
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-8227.000.patch
>
>
> Currently the {{BlockCollection}} interface returns {{BlockInfoContiguous}}
> objects in multiple calls.
> In order to decouple block manager and the namespace, the interface should
> return the {{Block}} instead of {{BlockInfoContiguous}} objects, where the
> latter contain information like the locations of DN.
> This jira proposes to clean up the interface and to return the {{Block}}
> objects directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8227) BlockCollection should return Block instead of BlockInfoContiguous in the interfaces
[
https://issues.apache.org/jira/browse/HDFS-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508695#comment-14508695
]
Hadoop QA commented on HDFS-8227:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 1s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 8 new or modified test files. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 47s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 5s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 5m 34s | The applied patch generated 3
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 9s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 19s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 164m 21s | Tests passed in hadoop-hdfs.
|
| | | 212m 1s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| | Redundant nullcheck of snapshotBlocks, which is known to be non-null in
org.apache.hadoop.hdfs.server.namenode.INodeFile.isBlockInLatestSnapshot(Block)
Redundant null check at INodeFile.java:is known to be non-null in
org.apache.hadoop.hdfs.server.namenode.INodeFile.isBlockInLatestSnapshot(Block)
Redundant null check at INodeFile.java:[line 922] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727538/HDFS-8227.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 18eb5e7 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10356/artifact/patchprocess/checkstyle-result-diff.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/10356/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10356/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10356/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10356/console |
This message was automatically generated.
> BlockCollection should return Block instead of BlockInfoContiguous in the
> interfaces
>
>
> Key: HDFS-8227
> URL: https://issues.apache.org/jira/browse/HDFS-8227
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-8227.000.patch
>
>
> Currently the {{BlockCollection}} interface returns {{BlockInfoContiguous}}
> objects in multiple calls.
> In order to decouple block manager and the namespace, the interface should
> return the {{Block}} instead of {{BlockInfoContiguous}} objects, where the
> latter contain information like the locations of DN.
> This jira proposes to clean up the interface and to return the {{Block}}
> objects directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8227) BlockCollection should return Block instead of BlockInfoContiguous in the interfaces
[
https://issues.apache.org/jira/browse/HDFS-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508484#comment-14508484
]
Haohui Mai commented on HDFS-8227:
--
The patch only changes the interface -- it casts the {{Block}} objects back to
{{BlockInfoContiguous}} when the users of the interface indeed needs the
{{BlockInfoContiguous}} objects.
> BlockCollection should return Block instead of BlockInfoContiguous in the
> interfaces
>
>
> Key: HDFS-8227
> URL: https://issues.apache.org/jira/browse/HDFS-8227
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Haohui Mai
>Assignee: Haohui Mai
> Attachments: HDFS-8227.000.patch
>
>
> Currently the {{BlockCollection}} interface returns {{BlockInfoContiguous}}
> objects in multiple calls.
> In order to decouple block manager and the namespace, the interface should
> return the {{Block}} instead of {{BlockInfoContiguous}} objects, where the
> latter contain information like the locations of DN.
> This jira proposes to clean up the interface and to return the {{Block}}
> objects directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
