[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525321#comment-14525321
]
Hudson commented on HDFS-8276:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2131 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2131/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525302#comment-14525302
]
Hudson commented on HDFS-8276:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #182 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/182/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525289#comment-14525289
]
Hudson commented on HDFS-8276:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2113 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2113/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525276#comment-14525276
]
Hudson commented on HDFS-8276:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #172 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/172/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525221#comment-14525221
]
Hudson commented on HDFS-8276:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #915 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/915/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525204#comment-14525204
]
Hudson commented on HDFS-8276:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #181 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/181/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524275#comment-14524275
]
Hudson commented on HDFS-8276:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #7715 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7715/])
HDFS-8276. LazyPersistFileScrubber should be disabled if scrubber interval
configured zero. (Contributed by Surendra Singh Lilhore) (arp: rev
64d30a61867e5cb0a2acaa7ae4fa4d3eb3be8edd)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Fix For: 2.8.0
>
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522922#comment-14522922
]
Hadoop QA commented on HDFS-8276:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 29s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 31s | The applied patch generated 1
new checkstyle issues (total was 359, now 358). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 3s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 163m 47s | Tests failed in hadoop-hdfs. |
| | | 205m 39s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12729474/HDFS-8276_1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1b3b9e5 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10502/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10502/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10502/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10502/console |
This message was automatically generated.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522011#comment-14522011
]
Arpit Agarwal commented on HDFS-8276:
-
Yes failed tests are likely due to HDFS-8300. Let's wait till that is resolved
and resubmit the Jenkins runs. Thanks.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521996#comment-14521996
]
surendra singh lilhore commented on HDFS-8276:
--
Thanks [~arpitagarwal] for review Failed test cases and findbug not
related to this patch.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521950#comment-14521950
]
Hadoop QA commented on HDFS-8276:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 33s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 5m 25s | There were no new checkstyle
issues. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 7s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 238m 53s | Tests failed in hadoop-hdfs. |
| | | 284m 45s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| | Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived
from an Exception, even though it is named as such At DataStreamer.java:from
an Exception, even though it is named as such At DataStreamer.java:[lines
177-201] |
| Failed unit tests | hadoop.hdfs.server.datanode.TestBlockRecovery |
| | hadoop.hdfs.TestDFSClientRetries |
| | hadoop.hdfs.TestQuota |
| | hadoop.cli.TestHDFSCLI |
| | hadoop.hdfs.TestClose |
| | hadoop.hdfs.TestCrcCorruption |
| | hadoop.hdfs.TestMultiThreadedHflush |
| | hadoop.hdfs.TestFileLengthOnClusterRestart |
| | hadoop.hdfs.TestDFSOutputStream |
| | hadoop.hdfs.server.namenode.TestDeleteRace |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation |
| Timed out tests |
org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache |
| | org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
| | org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery |
| | org.apache.hadoop.hdfs.TestDataTransferProtocol |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12729474/HDFS-8276_1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / de9404f |
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/10477/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10477/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10477/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10477/console |
This message was automatically generated.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521804#comment-14521804
]
Arpit Agarwal commented on HDFS-8276:
-
Thanks for the update and adding a test case.
We can simplify the test case later - just assert that the scrubber object is
null e.g.
{{assertThat(cluster.getFsNameSystem().lazyPersistFileScrubber, is(null));}}
+1 pending Jenkins.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521416#comment-14521416
]
surendra singh lilhore commented on HDFS-8276:
--
Thanks [~arpitagarwal] for review.
Attached new patch, added test case. Please review.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521414#comment-14521414
]
surendra singh lilhore commented on HDFS-8276:
--
Failed test cases and find bugs are not related to this jira.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch, HDFS-8276_1.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521152#comment-14521152
]
Hadoop QA commented on HDFS-8276:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 7m 43s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 7s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 224m 19s | Tests failed in hadoop-hdfs. |
| | | 272m 48s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| | Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived
from an Exception, even though it is named as such At DataStreamer.java:from
an Exception, even though it is named as such At DataStreamer.java:[lines
177-201] |
| Failed unit tests | hadoop.hdfs.TestFileLengthOnClusterRestart |
| | hadoop.cli.TestHDFSCLI |
| | hadoop.hdfs.TestMultiThreadedHflush |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation |
| | hadoop.hdfs.TestDFSOutputStream |
| | hadoop.hdfs.TestQuota |
| | hadoop.hdfs.TestCrcCorruption |
| | hadoop.hdfs.TestClose |
| | hadoop.hdfs.server.datanode.TestBlockRecovery |
| | hadoop.hdfs.TestDFSClientRetries |
| | hadoop.hdfs.server.namenode.TestDeleteRace |
| Timed out tests | org.apache.hadoop.hdfs.TestDataTransferProtocol |
| | org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache |
| | org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery |
| | org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12729099/HDFS-8276.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / aa22450 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10468/artifact/patchprocess/checkstyle-result-diff.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/10468/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10468/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10468/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10468/console |
This message was automatically generated.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenod
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520834#comment-14520834
]
Arpit Agarwal commented on HDFS-8276:
-
Thanks for fixing this [~surendrasingh]. Just a nitpick, there should be spaces
between the {{else}} and the braces on line 1176. +1 with that fixed.
Also see if you want to add a unit test. It should be fairly simple.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520817#comment-14520817
]
surendra singh lilhore commented on HDFS-8276:
--
[~arpitagarwal] Please can you review this patch.
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8276) LazyPersistFileScrubber should be disabled if scrubber interval configured zero
[
https://issues.apache.org/jira/browse/HDFS-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518975#comment-14518975
]
surendra singh lilhore commented on HDFS-8276:
--
Attached patch, Please review
> LazyPersistFileScrubber should be disabled if scrubber interval configured
> zero
> ---
>
> Key: HDFS-8276
> URL: https://issues.apache.org/jira/browse/HDFS-8276
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 2.6.0
>Reporter: surendra singh lilhore
>Assignee: surendra singh lilhore
> Attachments: HDFS-8276.patch
>
>
> bq. but I think it is simple enough to change the meaning of the value so
> that zero means 'never scrub'. Let me post an updated patch.
> As discussed in [HDFS-6929|https://issues.apache.org/jira/browse/HDFS-6929],
> scrubber should be disable if
> *dfs.namenode.lazypersist.file.scrub.interval.sec* is zero.
> Currently namenode startup is failing if interval configured zero
> {code}
> 2015-04-27 23:47:31,744 ERROR
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem: FSNamesystem
> initialization failed.
> java.lang.IllegalArgumentException:
> dfs.namenode.lazypersist.file.scrub.interval.sec must be non-zero.
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:828)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
