[jira] [Commented] (HDFS-8552) Fix hdfs namenode CLI usage message and its document
[
https://issues.apache.org/jira/browse/HDFS-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577559#comment-14577559
]
Xiaoyu Yao commented on HDFS-8552:
--
I think we could consolidate the fix together, please update the title as
appropriate.
Fix hdfs namenode CLI usage message and its document
Key: HDFS-8552
URL: https://issues.apache.org/jira/browse/HDFS-8552
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.6.0
Reporter: Xiaoyu Yao
Assignee: Brahma Reddy Battula
Attachments: HDFS-8552.patch
The usage message from code does not match with the one documented.
1. java NameNode should be hdfs namenode
2. Many of options are not documented.
Usage message from code:
{code}
private static final String USAGE = Usage: java NameNode [
+ StartupOption.BACKUP.getName() + ] | \n\t[
+ StartupOption.CHECKPOINT.getName() + ] | \n\t[
+ StartupOption.FORMAT.getName() + [
+ StartupOption.CLUSTERID.getName() + cid ] [
+ StartupOption.FORCE.getName() + ] [
+ StartupOption.NONINTERACTIVE.getName() + ] ] | \n\t[
+ StartupOption.UPGRADE.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.UPGRADEONLY.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.ROLLBACK.getName() + ] | \n\t[
+ StartupOption.ROLLINGUPGRADE.getName() +
+ RollingUpgradeStartupOption.getAllOptionString() + ] | \n\t[
+ StartupOption.IMPORT.getName() + ] | \n\t[
+ StartupOption.INITIALIZESHAREDEDITS.getName() + ] | \n\t[
+ StartupOption.BOOTSTRAPSTANDBY.getName() + ] | \n\t[
+ StartupOption.RECOVER.getName() + [
+ StartupOption.FORCE.getName() + ] ] | \n\t[
+ StartupOption.METADATAVERSION.getName() + ]
+ ];
{code}
Usage from document:
hdfs namenode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade |rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [-force] ] |
[-metadataVersion ]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8552) Fix hdfs namenode CLI usage message and its document
[
https://issues.apache.org/jira/browse/HDFS-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577546#comment-14577546
]
Xiaoyu Yao commented on HDFS-8552:
--
You are right, I misread the usage strings in the original description and
issue 2 is not a problem. I will update it.
Fix hdfs namenode CLI usage message and its document
Key: HDFS-8552
URL: https://issues.apache.org/jira/browse/HDFS-8552
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.6.0
Reporter: Xiaoyu Yao
Assignee: Brahma Reddy Battula
Attachments: HDFS-8552.patch
The usage message from code does not match with the one documented.
1. java NameNode should be hdfs namenode
2. Many of options are not documented.
Usage message from code:
{code}
private static final String USAGE = Usage: java NameNode [
+ StartupOption.BACKUP.getName() + ] | \n\t[
+ StartupOption.CHECKPOINT.getName() + ] | \n\t[
+ StartupOption.FORMAT.getName() + [
+ StartupOption.CLUSTERID.getName() + cid ] [
+ StartupOption.FORCE.getName() + ] [
+ StartupOption.NONINTERACTIVE.getName() + ] ] | \n\t[
+ StartupOption.UPGRADE.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.UPGRADEONLY.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.ROLLBACK.getName() + ] | \n\t[
+ StartupOption.ROLLINGUPGRADE.getName() +
+ RollingUpgradeStartupOption.getAllOptionString() + ] | \n\t[
+ StartupOption.IMPORT.getName() + ] | \n\t[
+ StartupOption.INITIALIZESHAREDEDITS.getName() + ] | \n\t[
+ StartupOption.BOOTSTRAPSTANDBY.getName() + ] | \n\t[
+ StartupOption.RECOVER.getName() + [
+ StartupOption.FORCE.getName() + ] ] | \n\t[
+ StartupOption.METADATAVERSION.getName() + ]
+ ];
{code}
Usage from document:
hdfs namenode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade |rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [-force] ] |
[-metadataVersion ]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8552) Fix hdfs namenode CLI usage message and its document
[
https://issues.apache.org/jira/browse/HDFS-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576127#comment-14576127
]
Hadoop QA commented on HDFS-8552:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 56s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 33s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 14s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 14s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 160m 42s | Tests failed in hadoop-hdfs. |
| | | 207m 6s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestFileTruncate |
| | hadoop.hdfs.server.namenode.TestClusterId |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12738222/HDFS-8552.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / b61b489 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11260/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11260/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11260/console |
This message was automatically generated.
Fix hdfs namenode CLI usage message and its document
Key: HDFS-8552
URL: https://issues.apache.org/jira/browse/HDFS-8552
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.6.0
Reporter: Xiaoyu Yao
Assignee: Brahma Reddy Battula
Attachments: HDFS-8552.patch
The usage message from code does not match with the one documented.
1. java NameNode should be hdfs namenode
2. Many of options are not documented.
Usage message from code:
{code}
private static final String USAGE = Usage: java NameNode [
+ StartupOption.BACKUP.getName() + ] | \n\t[
+ StartupOption.CHECKPOINT.getName() + ] | \n\t[
+ StartupOption.FORMAT.getName() + [
+ StartupOption.CLUSTERID.getName() + cid ] [
+ StartupOption.FORCE.getName() + ] [
+ StartupOption.NONINTERACTIVE.getName() + ] ] | \n\t[
+ StartupOption.UPGRADE.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.UPGRADEONLY.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.ROLLBACK.getName() + ] | \n\t[
+ StartupOption.ROLLINGUPGRADE.getName() +
+ RollingUpgradeStartupOption.getAllOptionString() + ] | \n\t[
+ StartupOption.IMPORT.getName() + ] | \n\t[
+ StartupOption.INITIALIZESHAREDEDITS.getName() + ] | \n\t[
+ StartupOption.BOOTSTRAPSTANDBY.getName() + ] | \n\t[
+ StartupOption.RECOVER.getName() + [
+ StartupOption.FORCE.getName() + ] ] | \n\t[
+ StartupOption.METADATAVERSION.getName() + ]
+ ];
{code}
Usage from document:
hdfs namenode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade |rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[jira] [Commented] (HDFS-8552) Fix hdfs namenode CLI usage message and its document
[
https://issues.apache.org/jira/browse/HDFS-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576091#comment-14576091
]
Brahma Reddy Battula commented on HDFS-8552:
I think following one ( zkfc ) also, we need to fix..since code is from
common,I did not fix with this issue..
But I feel , fix can be given as part of this issue only since it's not major
change..what do you feel..? do want me to raise another jira..?
{code}
protected static final String USAGE =
Usage: java zkfc [ -formatZK [-force] [-nonInteractive] ];
{code}
Fix hdfs namenode CLI usage message and its document
Key: HDFS-8552
URL: https://issues.apache.org/jira/browse/HDFS-8552
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.6.0
Reporter: Xiaoyu Yao
Assignee: Brahma Reddy Battula
Attachments: HDFS-8552.patch
The usage message from code does not match with the one documented.
1. java NameNode should be hdfs namenode
2. Many of options are not documented.
Usage message from code:
{code}
private static final String USAGE = Usage: java NameNode [
+ StartupOption.BACKUP.getName() + ] | \n\t[
+ StartupOption.CHECKPOINT.getName() + ] | \n\t[
+ StartupOption.FORMAT.getName() + [
+ StartupOption.CLUSTERID.getName() + cid ] [
+ StartupOption.FORCE.getName() + ] [
+ StartupOption.NONINTERACTIVE.getName() + ] ] | \n\t[
+ StartupOption.UPGRADE.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.UPGRADEONLY.getName() +
[ + StartupOption.CLUSTERID.getName() + cid] +
[ + StartupOption.RENAMERESERVED.getName() + k-v pairs] ] |
\n\t[
+ StartupOption.ROLLBACK.getName() + ] | \n\t[
+ StartupOption.ROLLINGUPGRADE.getName() +
+ RollingUpgradeStartupOption.getAllOptionString() + ] | \n\t[
+ StartupOption.IMPORT.getName() + ] | \n\t[
+ StartupOption.INITIALIZESHAREDEDITS.getName() + ] | \n\t[
+ StartupOption.BOOTSTRAPSTANDBY.getName() + ] | \n\t[
+ StartupOption.RECOVER.getName() + [
+ StartupOption.FORCE.getName() + ] ] | \n\t[
+ StartupOption.METADATAVERSION.getName() + ]
+ ];
{code}
Usage from document:
hdfs namenode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade |rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [-force] ] |
[-metadataVersion ]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
