[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964673#comment-14964673
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #556 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/556/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964587#comment-14964587
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #1292 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1292/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964633#comment-14964633
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2504 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2504/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964860#comment-14964860
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2454 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2454/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964932#comment-14964932
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #517 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/517/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963503#comment-14963503
]
Chris Nauroth commented on HDFS-9208:
-
[~kihwal], thank you for the patch. I am +1 for making this change.
The test failures look unrelated, and I can't repro them locally. I also
manually tested {{hdfs dfs -copyFromLocal -p}} and {{hadoop distcp -pt}} with a
NameNode that has atime disabled. You can remove the now-unused import of
{{DFS_NAMENODE_ACCESSTIME_PRECISION_KEY}} to fix the Checkstyle warning. After
that, I think the patch will be ready.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Attachments: HDFS-9208.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964062#comment-14964062
]
Hadoop QA commented on HDFS-9208:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 18m 19s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 3s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 31s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 25s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 30s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 32s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 49m 12s | Tests failed in hadoop-hdfs. |
| | | 95m 46s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestDFSClientRetries |
| | hadoop.hdfs.web.TestWebHdfsFileSystemContract |
| | hadoop.hdfs.TestDecommission |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12767469/HDFS-9208.v2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6144e01 |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/13055/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/13055/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/13055/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/13055/console |
This message was automatically generated.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964495#comment-14964495
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8669 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8669/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14964479#comment-14964479
]
Hudson commented on HDFS-9208:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #571 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/571/])
HDFS-9208. Disabling atime may fail clients like distCp. (Kihwal Lee via (yliu:
rev 9cb5d353533e829e624b33fb26dd37c177e1e046)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSetTimes.java
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Fix For: 2.8.0
>
> Attachments: HDFS-9208.patch, HDFS-9208.v2.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961132#comment-14961132
]
Hadoop QA commented on HDFS-9208:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 20m 45s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 59s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 40s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 39s | The applied patch generated 1
new checkstyle issues (total was 14, now 15). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 42s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 53s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 41s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 69m 14s | Tests failed in hadoop-hdfs. |
| | | 121m 37s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestReplaceDatanodeOnFailure |
| | hadoop.hdfs.TestRecoverStripedFile |
| | hadoop.hdfs.TestCrcCorruption |
| | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12767090/HDFS-9208.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 52ac73f |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/13032/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/13032/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/13032/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/13032/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/13032/console |
This message was automatically generated.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Kihwal Lee
> Attachments: HDFS-9208.patch
>
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959496#comment-14959496
]
Mingliang Liu commented on HDFS-9208:
-
Hi [~kihwal], this is on my list this week but I'm not working on this
actively. Sorry for the delay. I need more context for the options.
I assign it back to you in case you're blocked.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Mingliang Liu
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959431#comment-14959431
]
Kihwal Lee commented on HDFS-9208:
--
[~liuml07] Are you actively working on this?
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Mingliang Liu
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948658#comment-14948658
]
Kihwal Lee commented on HDFS-9208:
--
Really #3 is the only option. I was wrong about atime being 0. When {{INode}}
is created, the atime and mtime are set to identical value. option 1) and 2)
are not possible.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Mingliang Liu
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is not -1, distCp fails when it tries to
> set the mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947503#comment-14947503
]
Kihwal Lee commented on HDFS-9208:
--
I also like option #3.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Mingliang Liu
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is 0, distCp fails when it tries to set the
> mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9208) Disabling atime may fail clients like distCp
[
https://issues.apache.org/jira/browse/HDFS-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947256#comment-14947256
]
Chris Nauroth commented on HDFS-9208:
-
Hello [~kihwal].
I had filed HADOOP-12390 related to this problem specifically for {{hdfs dfs
-put -p}}. I proposed fixing it at the application layer by supporting
additional flags for preserving specific attributes.
Instead of fixing it in applications, I think I prefer your option #3 here to
allow explicit changes to atime at the NameNode layer. I don't see any harm in
allowing that. A single fix at the NameNode layer would help all applications
that might suffer from this problem.
> Disabling atime may fail clients like distCp
>
>
> Key: HDFS-9208
> URL: https://issues.apache.org/jira/browse/HDFS-9208
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Kihwal Lee
>Assignee: Mingliang Liu
>
> When atime is disabled, {{setTimes()}} throws an exception if the passed-in
> atime is not -1. But since atime is 0, distCp fails when it tries to set the
> mtime and atime.
> There are several options:
> 1) make distCp check for 0 atime and call {{setTimes()}} with -1. I am not
> very enthusiastic about it.
> 2) make NN also accept 0 atime in addition to -1, when the atime support is
> disabled.
> 3) support setting mtime & atime regardless of the atime support. The main
> reason why atime is disabled is to avoid edit logging/syncing during
> {{getBlockLocations()}} read calls. Explicit setting can be allowed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
