[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146323#comment-15146323 ] caixiaofeng commented on HDFS-9413: --- 马克 > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.7.2 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008467#comment-15008467 ] Vinayakumar B commented on HDFS-9413: - During refactoring and consolidation of related FSNamesystem methods, these checks were missed. Since HDFS-7450, was only on branch-2.7 onwards, cherry-pick to 2.6 line not required. I have cherry-picked to branch-2.7 and branch-2.7.2 as well, considering one more RC will be cut for 2.7.2. > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.7.2 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006995#comment-15006995 ] Hudson commented on HDFS-9413: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #681 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/681/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007151#comment-15007151 ] Hudson commented on HDFS-9413: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1405 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1405/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006982#comment-15006982 ] Hudson commented on HDFS-9413: -- FAILURE: Integrated in Hadoop-trunk-Commit #8806 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8806/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007062#comment-15007062 ] Sangjin Lee commented on HDFS-9413: --- +1 on adding it to the 2.6.x release (it'd be 2.6.3). Please cherry pick it to branch-2.6. > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007321#comment-15007321 ] Hudson commented on HDFS-9413: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2610 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2610/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007389#comment-15007389 ] Hudson commented on HDFS-9413: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #608 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/608/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007269#comment-15007269 ] Hudson commented on HDFS-9413: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #669 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/669/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007182#comment-15007182 ] Hudson commented on HDFS-9413: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2545 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2545/]) HDFS-9413. getContentSummary() on standby should throw StandbyException. (mingma: rev 02653add98f34deedc27f4da2254d25e83e55b58) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestQuotasWithHA.java > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007875#comment-15007875 ] Brahma Reddy Battula commented on HDFS-9413: Thanks a lot [~mingma] for reviewing and committing this issue and thanks to others..I feel, this is good candidate for 2.7. > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Fix For: 2.8.0 > > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005821#comment-15005821 ] Vinayakumar B commented on HDFS-9413: - IMO This should go to 2.7.2 as well. Agree? > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004271#comment-15004271
]
Brahma Reddy Battula commented on HDFS-9413:
[~mingma] thanks a lot for taking a look into this issue..
bq.Is waitForLoadingFSImage needed given NameNodeRpcServer has checked via
checkNNStartup?
{{waitForLoadingFSImage}} Removed.. But I had seen some methods in FSNamesystem
has.
Example:.
{code}
private void closeFile(String path, INodeFile file) {
assert hasWriteLock();
waitForLoadingFSImage();
{code}
bq.Maybe you can just modify TestQuotasWithHA instead for the test case.
Updated.
Kindly Review..
> getContentSummary() on standby should throw StandbyException
>
>
> Key: HDFS-9413
> URL: https://issues.apache.org/jira/browse/HDFS-9413
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
>Priority: Critical
> Attachments: HDFS-9413-002.patch, HDFS-9413.patch
>
>
> Currently when we call getContentSummary() on standby it will not throw
> StandbyException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004294#comment-15004294 ] Daryn Sharp commented on HDFS-9413: --- +1 To this fix, but I defer to Ming to +1 final patch - don't have time to review because dealing with disastrous 2.7 deployment issues. This was actually one of them. > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Attachments: HDFS-9413-002.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004634#comment-15004634
]
Hadoop QA commented on HDFS-9413:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 55s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 40s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 59s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 44s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-hdfs-project/hadoop-hdfs (total was 248, now 248). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 58s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 27s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 88m 12s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 48s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s
{color} | {color:red} Patch generated 56 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 200m 4s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests |
hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 |
| | hadoop.hdfs.server.datanode.TestBlockScanner |
| | hadoop.hdfs.server.namenode.ha.TestDNFencing |
| | hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion |
| | hadoop.hdfs.security.TestDelegationTokenForProxyUser |
| | hadoop.hdfs.server.namenode.TestMetaSave |
| | hadoop.hdfs.server.datanode.TestBlockReplacement |
| | hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes |
| | hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits |
| |
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005145#comment-15005145
]
Brahma Reddy Battula commented on HDFS-9413:
[~mingma] Updated patch which will use {{HAUtil.setAllowStandbyReads(conf,
false);}} to make consistency in the testcase..
bq.Regarding why waitForLoadingFSImage is called in other places, perhaps you
can open a jira to discuss if we can remove those calls. It seems if
checkNNStartup returns true, the image has been loaded.
will raise separate issue for this..
> getContentSummary() on standby should throw StandbyException
>
>
> Key: HDFS-9413
> URL: https://issues.apache.org/jira/browse/HDFS-9413
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
>Priority: Critical
> Attachments: HDFS-9413-002.patch, HDFS-9413-003.patch, HDFS-9413.patch
>
>
> Currently when we call getContentSummary() on standby it will not throw
> StandbyException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005125#comment-15005125 ] Brahma Reddy Battula commented on HDFS-9413: Test failures are unrelated..Kindly review > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Attachments: HDFS-9413-002.patch, HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005129#comment-15005129
]
Ming Ma commented on HDFS-9413:
---
Nit: Maybe use {{HAUtil.setAllowStandbyReads(conf, false);}} in the new test
case? +1 once it is fixed.
Regarding why {{waitForLoadingFSImage}} is called in other places, perhaps you
can open a jira to discuss if we can remove those calls. It seems if
{{checkNNStartup}} returns true, the image has been loaded.
> getContentSummary() on standby should throw StandbyException
>
>
> Key: HDFS-9413
> URL: https://issues.apache.org/jira/browse/HDFS-9413
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
>Priority: Critical
> Attachments: HDFS-9413-002.patch, HDFS-9413.patch
>
>
> Currently when we call getContentSummary() on standby it will not throw
> StandbyException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005211#comment-15005211
]
Hadoop QA commented on HDFS-9413:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
22s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 8s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 40s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-hdfs-project/hadoop-hdfs (total was 248, now 248). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 13s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 75m 48s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 42s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 22s
{color} | {color:red} Patch generated 56 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 175m 8s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests |
hadoop.hdfs.server.datanode.TestBlockScanner |
| JDK v1.7.0_79 Failed junit tests | hadoop.hdfs.TestDFSClientFailover |
| | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.0 Server=1.7.0
Image:test-patch-base-hadoop-date2015-11-14 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12772348/HDFS-9413-003.patch |
| JIRA Issue | HDFS-9413 |
| Optional Tests | asflicense compile javac
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003365#comment-15003365
]
Ming Ma commented on HDFS-9413:
---
Thanks [~brahmareddy]. You bring up an interesting point, why getContentSummary
is allowed on Standby NN when stale read is disabled. {{TestQuotasWithHA}}
actually calls {{HAUtil.setAllowStandbyReads(conf, true);}} first.
* Is {{waitForLoadingFSImage}} needed given {{NameNodeRpcServer}} has checked
via {{checkNNStartup}}?
* Maybe you can just modify {{TestQuotasWithHA}} instead for the test case.
Otherwise, it looks good.
> getContentSummary() on standby should throw StandbyException
>
>
> Key: HDFS-9413
> URL: https://issues.apache.org/jira/browse/HDFS-9413
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
>Priority: Critical
> Attachments: HDFS-9413.patch
>
>
> Currently when we call getContentSummary() on standby it will not throw
> StandbyException.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[ https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000663#comment-15000663 ] Brahma Reddy Battula commented on HDFS-9413: Test failures are unrelated and checkstyle is because of file length..Kindly review the patch.. thanks > getContentSummary() on standby should throw StandbyException > > > Key: HDFS-9413 > URL: https://issues.apache.org/jira/browse/HDFS-9413 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Brahma Reddy Battula >Assignee: Brahma Reddy Battula >Priority: Critical > Attachments: HDFS-9413.patch > > > Currently when we call getContentSummary() on standby it will not throw > StandbyException. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-9413) getContentSummary() on standby should throw StandbyException
[
https://issues.apache.org/jira/browse/HDFS-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000489#comment-15000489
]
Hadoop QA commented on HDFS-9413:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 7s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 39s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 18s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-hdfs-project/hadoop-hdfs (total was 248, now 248). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 16s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 75m 56s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 41s {color}
| {color:red} hadoop-hdfs in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s
{color} | {color:red} Patch generated 56 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 177m 25s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests | hadoop.hdfs.TestBlockStoragePolicy |
| | hadoop.hdfs.TestDFSUpgradeFromImage |
| | hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock |
| | hadoop.hdfs.server.namenode.ha.TestDNFencing |
| | hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
| | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
| | hadoop.hdfs.security.TestDelegationTokenForProxyUser |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes |
| | hadoop.hdfs.TestEncryptionZones |
| | hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
|
| | hadoop.hdfs.web.TestWebHDFS |
| JDK v1.7.0_79 Failed junit tests |
hadoop.hdfs.server.namenode.ha.TestEditLogTailer |
| | hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot |
| |
