[ https://issues.apache.org/jira/browse/HDFS-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingliang Liu reopened HDFS-15546: ---------------------------------- > Remove duplicate initializeGenericKeys method when creating > DFSZKFailoverController > ----------------------------------------------------------------------------------- > > Key: HDFS-15546 > URL: https://issues.apache.org/jira/browse/HDFS-15546 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: jianghua zhu > Assignee: jianghua zhu > Priority: Major > Labels: pull-request-available > Attachments: HDFS-15546.001.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > When calling the DFSZKFailoverController#create() method, call > NameNode#initializeGenericKeys() twice. > First call: > DFSZKFailoverController#create() { > ... > NameNode.initializeGenericKeys(localNNConf, nsId, nnId); > ... > } > The second call: > NNHAServiceTarget construction method: > NNHAServiceTarget() { > ... > NameNode.initializeGenericKeys(targetConf, nsId, nnId); > ... > } > In fact, the parameters passed in the two calls are the same. Here you can > remove the first call without affecting the program itself. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org