[jira] [Updated] (HDDS-1476) Fix logIfNeeded logic in EndPointStateMachine
[
https://issues.apache.org/jira/browse/HDDS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-1476:
-
Affects Version/s: 0.4.0
> Fix logIfNeeded logic in EndPointStateMachine
> -
>
> Key: HDDS-1476
> URL: https://issues.apache.org/jira/browse/HDDS-1476
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
>Affects Versions: 0.4.0
>Reporter: Bharat Viswanadham
>Assignee: Siddharth Wagle
>Priority: Major
> Labels: newbie, pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java}
> public void E(Exception ex) {
> LOG.trace("Incrementing the Missed count. Ex : {}", ex);
> this.incMissed();
> if (this.getMissedCount() % getLogWarnInterval(conf) ==
> 0) {
> LOG.error(
> "Unable to communicate to SCM server at {} for past {} seconds.",
> this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
> TimeUnit.MILLISECONDS.toSeconds(
> this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
> }
> }{code}
> This method will be called when any exception occur in stateMachine to log an
> exception. But to not log aggresively we have this
> ozone.scm.heartbeat.log.warn.interval.count property to control logging.
>
> There is a small issue here, we don't log the exception first time when it
> occurred. So, we need to log for the first time and then increment the
> missingCount.
>
> Fix is to move the this.incMissed() to end of the method so that we log it
> for the first time exception occurred and after that every
> log.warn.interval.count exceptions happened.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-1476) Fix logIfNeeded logic in EndPointStateMachine
[
https://issues.apache.org/jira/browse/HDDS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-1476:
-
Resolution: Fixed
Fix Version/s: 0.5.0
Status: Resolved (was: Patch Available)
Thank You [~swagle] for the contribution and [~arpitagarwal] for the review.
I have committed this to the trunk.
> Fix logIfNeeded logic in EndPointStateMachine
> -
>
> Key: HDDS-1476
> URL: https://issues.apache.org/jira/browse/HDDS-1476
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
>Reporter: Bharat Viswanadham
>Assignee: Siddharth Wagle
>Priority: Major
> Labels: newbie, pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java}
> public void E(Exception ex) {
> LOG.trace("Incrementing the Missed count. Ex : {}", ex);
> this.incMissed();
> if (this.getMissedCount() % getLogWarnInterval(conf) ==
> 0) {
> LOG.error(
> "Unable to communicate to SCM server at {} for past {} seconds.",
> this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
> TimeUnit.MILLISECONDS.toSeconds(
> this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
> }
> }{code}
> This method will be called when any exception occur in stateMachine to log an
> exception. But to not log aggresively we have this
> ozone.scm.heartbeat.log.warn.interval.count property to control logging.
>
> There is a small issue here, we don't log the exception first time when it
> occurred. So, we need to log for the first time and then increment the
> missingCount.
>
> Fix is to move the this.incMissed() to end of the method so that we log it
> for the first time exception occurred and after that every
> log.warn.interval.count exceptions happened.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-1476) Fix logIfNeeded logic in EndPointStateMachine
[
https://issues.apache.org/jira/browse/HDDS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Wagle updated HDDS-1476:
--
Status: Patch Available (was: Open)
Thanks [~bharatviswa] for creating a newbie Jira. Created a PR.
> Fix logIfNeeded logic in EndPointStateMachine
> -
>
> Key: HDDS-1476
> URL: https://issues.apache.org/jira/browse/HDDS-1476
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
>Reporter: Bharat Viswanadham
>Assignee: Siddharth Wagle
>Priority: Major
> Labels: newbie, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> public void E(Exception ex) {
> LOG.trace("Incrementing the Missed count. Ex : {}", ex);
> this.incMissed();
> if (this.getMissedCount() % getLogWarnInterval(conf) ==
> 0) {
> LOG.error(
> "Unable to communicate to SCM server at {} for past {} seconds.",
> this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
> TimeUnit.MILLISECONDS.toSeconds(
> this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
> }
> }{code}
> This method will be called when any exception occur in stateMachine to log an
> exception. But to not log aggresively we have this
> ozone.scm.heartbeat.log.warn.interval.count property to control logging.
>
> There is a small issue here, we don't log the exception first time when it
> occurred. So, we need to log for the first time and then increment the
> missingCount.
>
> Fix is to move the this.incMissed() to end of the method so that we log it
> for the first time exception occurred and after that every
> log.warn.interval.count exceptions happened.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-1476) Fix logIfNeeded logic in EndPointStateMachine
[
https://issues.apache.org/jira/browse/HDDS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-1476:
-
Labels: newbie pull-request-available (was: newbie)
> Fix logIfNeeded logic in EndPointStateMachine
> -
>
> Key: HDDS-1476
> URL: https://issues.apache.org/jira/browse/HDDS-1476
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
>Reporter: Bharat Viswanadham
>Assignee: Siddharth Wagle
>Priority: Major
> Labels: newbie, pull-request-available
>
> {code:java}
> public void E(Exception ex) {
> LOG.trace("Incrementing the Missed count. Ex : {}", ex);
> this.incMissed();
> if (this.getMissedCount() % getLogWarnInterval(conf) ==
> 0) {
> LOG.error(
> "Unable to communicate to SCM server at {} for past {} seconds.",
> this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
> TimeUnit.MILLISECONDS.toSeconds(
> this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
> }
> }{code}
> This method will be called when any exception occur in stateMachine to log an
> exception. But to not log aggresively we have this
> ozone.scm.heartbeat.log.warn.interval.count property to control logging.
>
> There is a small issue here, we don't log the exception first time when it
> occurred. So, we need to log for the first time and then increment the
> missingCount.
>
> Fix is to move the this.incMissed() to end of the method so that we log it
> for the first time exception occurred and after that every
> log.warn.interval.count exceptions happened.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-1476) Fix logIfNeeded logic in EndPointStateMachine
[
https://issues.apache.org/jira/browse/HDDS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-1476:
-
Component/s: Ozone Datanode
> Fix logIfNeeded logic in EndPointStateMachine
> -
>
> Key: HDDS-1476
> URL: https://issues.apache.org/jira/browse/HDDS-1476
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
>Reporter: Bharat Viswanadham
>Priority: Major
> Labels: newbie
>
> {code:java}
> public void E(Exception ex) {
> LOG.trace("Incrementing the Missed count. Ex : {}", ex);
> this.incMissed();
> if (this.getMissedCount() % getLogWarnInterval(conf) ==
> 0) {
> LOG.error(
> "Unable to communicate to SCM server at {} for past {} seconds.",
> this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
> TimeUnit.MILLISECONDS.toSeconds(
> this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
> }
> }{code}
> This method will be called when any exception occur in stateMachine to log an
> exception. But to not log aggresively we have this
> ozone.scm.heartbeat.log.warn.interval.count property to control logging.
>
> There is a small issue here, we don't log the exception first time when it
> occurred. So, we need to log for the first time and then increment the
> missingCount.
>
> Fix is to move the this.incMissed() to end of the method so that we log it
> for the first time exception occurred and after that every
> log.warn.interval.count exceptions happened.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDDS-1476) Fix logIfNeeded logic in EndPointStateMachine
[
https://issues.apache.org/jira/browse/HDDS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-1476:
-
Labels: newbie (was: )
> Fix logIfNeeded logic in EndPointStateMachine
> -
>
> Key: HDDS-1476
> URL: https://issues.apache.org/jira/browse/HDDS-1476
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Priority: Major
> Labels: newbie
>
> {code:java}
> public void E(Exception ex) {
> LOG.trace("Incrementing the Missed count. Ex : {}", ex);
> this.incMissed();
> if (this.getMissedCount() % getLogWarnInterval(conf) ==
> 0) {
> LOG.error(
> "Unable to communicate to SCM server at {} for past {} seconds.",
> this.getAddress().getHostString() + ":" + this.getAddress().getPort(),
> TimeUnit.MILLISECONDS.toSeconds(
> this.getMissedCount() * getScmHeartbeatInterval(this.conf)), ex);
> }
> }{code}
> This method will be called when any exception occur in stateMachine to log an
> exception. But to not log aggresively we have this
> ozone.scm.heartbeat.log.warn.interval.count property to control logging.
>
> There is a small issue here, we don't log the exception first time when it
> occurred. So, we need to log for the first time and then increment the
> missingCount.
>
> Fix is to move the this.incMissed() to end of the method so that we log it
> for the first time exception occurred and after that every
> log.warn.interval.count exceptions happened.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
