[jira] [Updated] (HDDS-377) Make the ScmClient closable and stop the started threads

2018-08-27 Thread Xiaoyu Yao (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HDDS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaoyu Yao updated HDDS-377:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thanks [~elek] for the contribution. The patch LGTM, +1. I've committed it to 
trunk.

> Make the ScmClient closable and stop the started threads
> 
>
> Key: HDDS-377
> URL: https://issues.apache.org/jira/browse/HDDS-377
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: SCM Client
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-377.001.patch
>
>
> Current ScmClient class opens additional threads which won't be closed. For 
> example SCMCLI can't stop because of this running thread:
> {code}
> "nioEventLoopGroup-2-1" #15 prio=10 os_prio=0 tid=0x7f1c84c74800 
> nid=0x77f4 runnable [0x7f1c52238000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method)
>   at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269)
>   at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x000771adf7b0> (a 
> org.apache.ratis.shaded.io.netty.channel.nio.SelectedSelectionKeySet)
>   - locked <0x000771ae12d8> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x000771ae1010> (a sun.nio.ch.EPollSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.SelectedSelectionKeySetSelector.select(SelectedSelectionKeySetSelector.java:62)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.NioEventLoop.select(NioEventLoop.java:753)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:409)
>   at 
> org.apache.ratis.shaded.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
>   at 
> org.apache.ratis.shaded.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
>   at java.lang.Thread.run(Thread.java:745)
> {code}
> (Note this is netty, but the Grpc based xceiver also have some special 
> threads).
> I propose to make ScmClient auto-closable and stop the XceiverClientManager 
> in case of close. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDDS-377) Make the ScmClient closable and stop the started threads

2018-08-27 Thread Elek, Marton (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HDDS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elek, Marton updated HDDS-377:
--
Status: Patch Available  (was: Open)

> Make the ScmClient closable and stop the started threads
> 
>
> Key: HDDS-377
> URL: https://issues.apache.org/jira/browse/HDDS-377
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: SCM Client
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-377.001.patch
>
>
> Current ScmClient class opens additional threads which won't be closed. For 
> example SCMCLI can't stop because of this running thread:
> {code}
> "nioEventLoopGroup-2-1" #15 prio=10 os_prio=0 tid=0x7f1c84c74800 
> nid=0x77f4 runnable [0x7f1c52238000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method)
>   at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269)
>   at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x000771adf7b0> (a 
> org.apache.ratis.shaded.io.netty.channel.nio.SelectedSelectionKeySet)
>   - locked <0x000771ae12d8> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x000771ae1010> (a sun.nio.ch.EPollSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.SelectedSelectionKeySetSelector.select(SelectedSelectionKeySetSelector.java:62)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.NioEventLoop.select(NioEventLoop.java:753)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:409)
>   at 
> org.apache.ratis.shaded.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
>   at 
> org.apache.ratis.shaded.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
>   at java.lang.Thread.run(Thread.java:745)
> {code}
> (Note this is netty, but the Grpc based xceiver also have some special 
> threads).
> I propose to make ScmClient auto-closable and stop the XceiverClientManager 
> in case of close. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDDS-377) Make the ScmClient closable and stop the started threads

2018-08-27 Thread Elek, Marton (JIRA) 


 [ 
https://issues.apache.org/jira/browse/HDDS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elek, Marton updated HDDS-377:
--
Attachment: HDDS-377.001.patch

> Make the ScmClient closable and stop the started threads
> 
>
> Key: HDDS-377
> URL: https://issues.apache.org/jira/browse/HDDS-377
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>  Components: SCM Client
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-377.001.patch
>
>
> Current ScmClient class opens additional threads which won't be closed. For 
> example SCMCLI can't stop because of this running thread:
> {code}
> "nioEventLoopGroup-2-1" #15 prio=10 os_prio=0 tid=0x7f1c84c74800 
> nid=0x77f4 runnable [0x7f1c52238000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method)
>   at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269)
>   at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x000771adf7b0> (a 
> org.apache.ratis.shaded.io.netty.channel.nio.SelectedSelectionKeySet)
>   - locked <0x000771ae12d8> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x000771ae1010> (a sun.nio.ch.EPollSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.SelectedSelectionKeySetSelector.select(SelectedSelectionKeySetSelector.java:62)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.NioEventLoop.select(NioEventLoop.java:753)
>   at 
> org.apache.ratis.shaded.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:409)
>   at 
> org.apache.ratis.shaded.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
>   at 
> org.apache.ratis.shaded.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138)
>   at java.lang.Thread.run(Thread.java:745)
> {code}
> (Note this is netty, but the Grpc based xceiver also have some special 
> threads).
> I propose to make ScmClient auto-closable and stop the XceiverClientManager 
> in case of close. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org