[jira] [Updated] (HDFS-10189) PacketResponder#toString should include the downstreams for PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE

[Colin Patrick McCabe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HDFS-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HDFS-10189:

  Resolution: Fixed
   Fix Version/s: 2.8.0
Target Version/s: 2.8.0
  Status: Resolved  (was: Patch Available)

committed to 2.8, thanks!

> PacketResponder#toString should include the downstreams for 
> PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE
> --
>
> Key: HDFS-10189
> URL: https://issues.apache.org/jira/browse/HDFS-10189
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: datanode
>Affects Versions: 2.7.1
>Reporter: Joe Pallas
>Assignee: Joe Pallas
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-10189.patch
>
>
> The constructor for {{BlockReceiver.PacketResponder}} says
> {code}
>   final StringBuilder b = new StringBuilder(getClass().getSimpleName())
>   .append(": ").append(block).append(", type=").append(type);
>   if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) {
> b.append(", downstreams=").append(downstreams.length)
> .append(":").append(Arrays.asList(downstreams));
>   }
> {code}
> So it includes the list of downstreams only when it has no downstreams.  The 
> {{if}} test should be for equality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-10189) PacketResponder#toString should include the downstreams for PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE

[Colin Patrick McCabe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HDFS-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HDFS-10189:

Summary: PacketResponder#toString should include the downstreams for 
PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE  (was: PacketResponder toString 
should include the downstreams for 
PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE)

> PacketResponder#toString should include the downstreams for 
> PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE
> --
>
> Key: HDFS-10189
> URL: https://issues.apache.org/jira/browse/HDFS-10189
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: datanode
>Affects Versions: 2.7.1
>Reporter: Joe Pallas
>Assignee: Joe Pallas
>Priority: Minor
> Attachments: HDFS-10189.patch
>
>
> The constructor for {{BlockReceiver.PacketResponder}} says
> {code}
>   final StringBuilder b = new StringBuilder(getClass().getSimpleName())
>   .append(": ").append(block).append(", type=").append(type);
>   if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) {
> b.append(", downstreams=").append(downstreams.length)
> .append(":").append(Arrays.asList(downstreams));
>   }
> {code}
> So it includes the list of downstreams only when it has no downstreams.  The 
> {{if}} test should be for equality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-10189) PacketResponder toString should include the downstreams for PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE

[Colin Patrick McCabe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HDFS-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colin Patrick McCabe updated HDFS-10189:

Summary: PacketResponder toString should include the downstreams for 
PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE  (was: PacketResponder toString 
is built incorrectly)

> PacketResponder toString should include the downstreams for 
> PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE
> --
>
> Key: HDFS-10189
> URL: https://issues.apache.org/jira/browse/HDFS-10189
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: datanode
>Affects Versions: 2.7.1
>Reporter: Joe Pallas
>Assignee: Joe Pallas
>Priority: Minor
> Attachments: HDFS-10189.patch
>
>
> The constructor for {{BlockReceiver.PacketResponder}} says
> {code}
>   final StringBuilder b = new StringBuilder(getClass().getSimpleName())
>   .append(": ").append(block).append(", type=").append(type);
>   if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) {
> b.append(", downstreams=").append(downstreams.length)
> .append(":").append(Arrays.asList(downstreams));
>   }
> {code}
> So it includes the list of downstreams only when it has no downstreams.  The 
> {{if}} test should be for equality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)