[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[
https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated HDFS-11416:
Attachment: HDFS-11416.006.patch
Also, attaching the committed patch, where I've fixed one checkstyle warning -
removed unused {{import org.apache.hadoop.test.GenericTestUtils}}.
> Refactor out system default erasure coding policy
> -
>
> Key: HDFS-11416
> URL: https://issues.apache.org/jira/browse/HDFS-11416
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Labels: hdfs-ec-3.0-nice-to-have
> Fix For: 3.0.0-alpha3
>
> Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch,
> HDFS-11416.003.patch, HDFS-11416.004.patch, HDFS-11416.005.patch,
> HDFS-11416.006.patch
>
>
> As discussed on HDFS-7859, the system default EC policy is mostly a relic
> from development when the system only supported a single global policy. Now,
> we support multiple policies, and the system default policy is mostly used by
> tests.
> We should refactor to remove this concept.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated HDFS-11416: Resolution: Fixed Fix Version/s: 3.0.0-alpha3 Status: Resolved (was: Patch Available) Thanks [~andrew.wang] for the contribution. Thanks [~jojochuang] for the reviews. Committed to trunk. > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Fix For: 3.0.0-alpha3 > > Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch, > HDFS-11416.003.patch, HDFS-11416.004.patch, HDFS-11416.005.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Attachment: HDFS-11416.005.patch Thanks for reviewing Rakesh, new patch attached to address your review comments. > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch, > HDFS-11416.003.patch, HDFS-11416.004.patch, HDFS-11416.005.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Attachment: HDFS-11416.004.patch Missed updating a different test case in that test class. > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch, > HDFS-11416.003.patch, HDFS-11416.004.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Attachment: HDFS-11416.003.patch Tiny rev to revert the change of Preconditions.checkArgument to checkNotNull, which caused the failing TestStripedINodeFile test. > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch, > HDFS-11416.003.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Attachment: HDFS-11416.002.patch I think this needed a slight rebase after HDFS-11382, attached. > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Status: Patch Available (was: Open) > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Status: Open (was: Patch Available) Forgot that this depends on HDFS-11428, which is why all the unit tests failed. Need to get that in first, though I think this is still ready for review. > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Status: Patch Available (was: Open) > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > Attachments: HDFS-11416.001.patch > > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[
https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-11416:
---
Attachment: HDFS-11416.001.patch
Patch attached. This just removes production usages of getSystemDefaultPolicy.
I'll file another JIRA to move this function to somewhere like {{DFSTestUtil}}
which will also update all the references in test code.
> Refactor out system default erasure coding policy
> -
>
> Key: HDFS-11416
> URL: https://issues.apache.org/jira/browse/HDFS-11416
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
>Affects Versions: 3.0.0-alpha1
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Labels: hdfs-ec-3.0-nice-to-have
> Attachments: HDFS-11416.001.patch
>
>
> As discussed on HDFS-7859, the system default EC policy is mostly a relic
> from development when the system only supported a single global policy. Now,
> we support multiple policies, and the system default policy is mostly used by
> tests.
> We should refactor to remove this concept.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-11416) Refactor out system default erasure coding policy
[ https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HDFS-11416: --- Labels: hdfs-ec-3.0-nice-to-have (was: ) > Refactor out system default erasure coding policy > - > > Key: HDFS-11416 > URL: https://issues.apache.org/jira/browse/HDFS-11416 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding >Affects Versions: 3.0.0-alpha1 >Reporter: Andrew Wang >Assignee: Andrew Wang > Labels: hdfs-ec-3.0-nice-to-have > > As discussed on HDFS-7859, the system default EC policy is mostly a relic > from development when the system only supported a single global policy. Now, > we support multiple policies, and the system default policy is mostly used by > tests. > We should refactor to remove this concept. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
