[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-10-03 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

  Resolution: Fixed
Hadoop Flags: Reviewed
   Fix Version/s: HDFS-7240
Target Version/s: HDFS-7240
  Status: Resolved  (was: Patch Available)

[~Weiwei Yang], [~msingh],[~ajayydv], [~xyao] Thanks for the reviews. I have 
committed this to the feature branch. I have fixed some checkstyle warnings 
while committing, and thanks to [~msingh] for taking care of 2 missing config 
entries in the ozone-default.xml, he will add them via HDFS-12572

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Fix For: HDFS-7240
>
> Attachments: HDFS-12568-HDFS-7240.001.patch, 
> HDFS-12568-HDFS-7240.002.patch, HDFS-12568-HDFS-7240.003.patch, 
> HDFS-12568-HDFS-7240.004.patch, HDFS-12568-HDFS-7240.005.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-10-02 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: HDFS-12568-HDFS-7240.005.patch

Cleanup some more, attached v5. Replaced /tmp with ${hadoop.tmp.dir}

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch, 
> HDFS-12568-HDFS-7240.002.patch, HDFS-12568-HDFS-7240.003.patch, 
> HDFS-12568-HDFS-7240.004.patch, HDFS-12568-HDFS-7240.005.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-10-02 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: HDFS-12568-HDFS-7240.004.patch

[~xyao] Thanks for the comments.

bq. Ozone-default.xml. Line 64: ozone->CBLOCK,PERFORMANCE?
Not able to locate this, skipping for now.
 
bq. Lin 126: can we change to dfs.cblock.container.size.gb to be consistent 
with other Ozone keys related to size.
Fixed.
 
bq. Line 138/251: Should we use ${hadoop.tmp.dir}/cblockCacheDB?
Fixed.
 
bq. Line 327: should we add a CONTAINER tag for dfs.container.ipc.random.port?
Fixed.
 
bq. Line 337: should we add a RATIS tag for 
dfs.container.ratis.datanode.storage.dir?
Fixed.

bq.Line 448: NIT: can you add xml comment to mark the beginning of the CLIENT 
related keys?
Fixed, Added a comment for client settings for ozone client. There is still SCM 
block client etc. which are used only by KSM.

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch, 
> HDFS-12568-HDFS-7240.002.patch, HDFS-12568-HDFS-7240.003.patch, 
> HDFS-12568-HDFS-7240.004.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-10-02 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: HDFS-12568-HDFS-7240.003.patch

[~cheersyang] and [~msingh] Thanks for the reviews. I have fixed the count 
mismatch test failure by removing that test. That test is hard to maintain and 
make little sense. For the Fs settings, I will let Mukul take care of them. 

So there will still be one test failure about a missing key, which will get 
fixed in ozone fs patches.


> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch, 
> HDFS-12568-HDFS-7240.002.patch, HDFS-12568-HDFS-7240.003.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-30 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: HDFS-12568-HDFS-7240.002.patch

[~cheersyang] Thanks for the comments. I have updated the patch.

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch, 
> HDFS-12568-HDFS-7240.002.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-29 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Status: Patch Available  (was: Open)

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-29 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: HDFS-12568-HDFS-7240.001.patch

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-29 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: (was: HDFS-12568-HDFS-7240.001.patch)

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-29 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Priority: Blocker  (was: Major)

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Blocker
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-29 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Attachment: HDFS-12568-HDFS-7240.001.patch

Here are the changes that are done in this patch.
# Sorted the key space, created a CBlock Section, Container, and Ozone section.
# Remove the following unused properties.{{dfs.container.ratis.server.id}}
# Renamed {{ozone.key.cache.size}} to {{ozone.container.cache.size}} and 
{{dfs.cblock.cache.cache.size.in.kb}} to {{dfs.cblock.cache.queue.size.in.kb}}
# Updated the tags for all keys.
# Fixed the description for most keys.
# Added a new tag type tp OzonePropertyTag.java called CBLOCK.

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-12568) Ozone: Cleanup the ozone-default.xml

2017-09-29 Thread Anu Engineer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-12568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12568:

Labels: ozoneMerge  (was: )

> Ozone: Cleanup the ozone-default.xml
> 
>
> Key: HDFS-12568
> URL: https://issues.apache.org/jira/browse/HDFS-12568
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>  Labels: ozoneMerge
> Attachments: HDFS-12568-HDFS-7240.001.patch
>
>
> This JIRA proposes to clean up the ozone-default.xml before the merge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org