[jira] [Updated] (HDFS-12805) Ozone: Redundant characters printed in exception log
[
https://issues.apache.org/jira/browse/HDFS-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaoyu Yao updated HDFS-12805:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: HDFS-7240
Status: Resolved (was: Patch Available)
Thanks [~linyiqun] for the contribution. I've committed the patch to the
feature branch.
> Ozone: Redundant characters printed in exception log
>
>
> Key: HDFS-12805
> URL: https://issues.apache.org/jira/browse/HDFS-12805
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Minor
> Labels: newbie
> Fix For: HDFS-7240
>
> Attachments: HDFS-12805-HDFS-7240.001.patch,
> HDFS-12805-HDFS-7240.002.patch
>
>
> Found some incorrect usage of sl4j in class
> {{Volume/Bucket/KeyProcessTemplate.class}}.
> For Example line100 in {{VolumeProcessTemplate#handleCall(}},
> We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It
> will invoke {{Logger.error(String msg, Throwable t)}} not
> {{Logger.debug(String format, Object arg1)}}.
> Redundant characters '{}' will be printed in exception log.
> The correct usage of this should be {{LOG.error("illegal argument. {}",
> ex.toString());}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12805) Ozone: Redundant characters printed in exception log
[
https://issues.apache.org/jira/browse/HDFS-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-12805:
-
Attachment: HDFS-12805-HDFS-7240.002.patch
Thanks for the review, [~xyao], Comment makes sense to me.
Attach the updated patch.
> Ozone: Redundant characters printed in exception log
>
>
> Key: HDFS-12805
> URL: https://issues.apache.org/jira/browse/HDFS-12805
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Minor
> Labels: newbie
> Attachments: HDFS-12805-HDFS-7240.001.patch,
> HDFS-12805-HDFS-7240.002.patch
>
>
> Found some incorrect usage of sl4j in class
> {{Volume/Bucket/KeyProcessTemplate.class}}.
> For Example line100 in {{VolumeProcessTemplate#handleCall(}},
> We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It
> will invoke {{Logger.error(String msg, Throwable t)}} not
> {{Logger.debug(String format, Object arg1)}}.
> Redundant characters '{}' will be printed in exception log.
> The correct usage of this should be {{LOG.error("illegal argument. {}",
> ex.toString());}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12805) Ozone: Redundant characters printed in exception log
[
https://issues.apache.org/jira/browse/HDFS-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-12805:
-
Attachment: HDFS-12805-HDFS-7240.001.patch
> Ozone: Redundant characters printed in exception log
>
>
> Key: HDFS-12805
> URL: https://issues.apache.org/jira/browse/HDFS-12805
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Minor
> Labels: newbie
> Attachments: HDFS-12805-HDFS-7240.001.patch
>
>
> Found some incorrect usage of sl4j in class
> {{Volume/Bucket/KeyProcessTemplate.class}}.
> For Example line100 in {{VolumeProcessTemplate#handleCall(}},
> We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It
> will invoke {{Logger.error(String msg, Throwable t)}} not
> {{Logger.debug(String format, Object arg1)}}.
> Redundant characters '{}' will be printed in exception log.
> The correct usage of this should be {{LOG.error("illegal argument. {}",
> ex.toString());}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12805) Ozone: Redundant characters printed in exception log
[
https://issues.apache.org/jira/browse/HDFS-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-12805:
-
Status: Patch Available (was: Open)
> Ozone: Redundant characters printed in exception log
>
>
> Key: HDFS-12805
> URL: https://issues.apache.org/jira/browse/HDFS-12805
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Yiqun Lin
>Assignee: Yiqun Lin
>Priority: Minor
> Labels: newbie
> Attachments: HDFS-12805-HDFS-7240.001.patch
>
>
> Found some incorrect usage of sl4j in class
> {{Volume/Bucket/KeyProcessTemplate.class}}.
> For Example line100 in {{VolumeProcessTemplate#handleCall(}},
> We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It
> will invoke {{Logger.error(String msg, Throwable t)}} not
> {{Logger.debug(String format, Object arg1)}}.
> Redundant characters '{}' will be printed in exception log.
> The correct usage of this should be {{LOG.error("illegal argument. {}",
> ex.toString());}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-12805) Ozone: Redundant characters printed in exception log
[
https://issues.apache.org/jira/browse/HDFS-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-12805:
-
Description:
Found some incorrect usage of sl4j in class
{{Volume/Bucket/KeyProcessTemplate.class}}.
For Example line100 in {{VolumeProcessTemplate#handleCall(}},
We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It will
invoke {{Logger.error(String msg, Throwable t)}} not {{Logger.debug(String
format, Object arg1)}}.
Redundant characters '{}' will be printed in exception log.
The correct usage of this should be {{LOG.error("illegal argument. {}",
ex.toString());}}
was:
Found some incorrect usage of sl4j in class
{{Volume/Bucket/KeyProcessTemplate.class}}.
For Example line100 in {{VolumeProcessTemplate#handleCall(}},
We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It will
invoke {{
Logger.error(String msg, Throwable t)}} not {{Logger.debug(String format,
Object arg1)}}.
Redundant characters '{}' will be printed in exception log.
The correct usage of this should be {{LOG.error("illegal argument. {}",
ex.toString());}}
> Ozone: Redundant characters printed in exception log
>
>
> Key: HDFS-12805
> URL: https://issues.apache.org/jira/browse/HDFS-12805
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Yiqun Lin
>Priority: Minor
> Labels: newbie
>
> Found some incorrect usage of sl4j in class
> {{Volume/Bucket/KeyProcessTemplate.class}}.
> For Example line100 in {{VolumeProcessTemplate#handleCall(}},
> We use {{LOG.error("illegal argument. {}", ex);}} to print error info. It
> will invoke {{Logger.error(String msg, Throwable t)}} not
> {{Logger.debug(String format, Object arg1)}}.
> Redundant characters '{}' will be printed in exception log.
> The correct usage of this should be {{LOG.error("illegal argument. {}",
> ex.toString());}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
