[jira] [Updated] (HDFS-13970) Use MultiMap for CacheManager Directives to simplify the code
[ https://issues.apache.org/jira/browse/HDFS-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HDFS-13970: - Resolution: Fixed Fix Version/s: 3.3.0 Status: Resolved (was: Patch Available) Committed this to trunk. Thanks [~belugabehr] for the contribution! > Use MultiMap for CacheManager Directives to simplify the code > - > > Key: HDFS-13970 > URL: https://issues.apache.org/jira/browse/HDFS-13970 > Project: Hadoop HDFS > Issue Type: Improvement > Components: caching, hdfs >Affects Versions: 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Fix For: 3.3.0 > > Attachments: HDFS-13970.1.patch, HDFS-13970.2.patch > > > # Use Guava Multimap to simplify code > ## Currently, code uses a mix of LinkedList and ArrayList - just pick one > ## Currently, {{directivesByPath}} structure is sorted but never used in a > sorted way, it only performs remove and add operations, no iteration - use a > {{Set}} instead of a {{List}} for values to support faster remove operation. > Use a {{HashSet}} instead of a {{TreeSet}} for keys since it doesn't appear > that order really matters. > # The {{CacheDirective}} class needs a better hashcode implementation since > it will be used in a Set. Do not instantiate a {{HashBuilder}} object every > time {{hashcode}} is called. Ouch. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-13970) Use MultiMap for CacheManager Directives to simplify the code
[ https://issues.apache.org/jira/browse/HDFS-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HDFS-13970: - Flags: (was: Patch) Hadoop Flags: Reviewed Summary: Use MultiMap for CacheManager Directives to simplify the code (was: CacheManager Directives Map) > Use MultiMap for CacheManager Directives to simplify the code > - > > Key: HDFS-13970 > URL: https://issues.apache.org/jira/browse/HDFS-13970 > Project: Hadoop HDFS > Issue Type: Improvement > Components: caching, hdfs >Affects Versions: 3.2.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HDFS-13970.1.patch, HDFS-13970.2.patch > > > # Use Guava Multimap to simplify code > ## Currently, code uses a mix of LinkedList and ArrayList - just pick one > ## Currently, {{directivesByPath}} structure is sorted but never used in a > sorted way, it only performs remove and add operations, no iteration - use a > {{Set}} instead of a {{List}} for values to support faster remove operation. > Use a {{HashSet}} instead of a {{TreeSet}} for keys since it doesn't appear > that order really matters. > # The {{CacheDirective}} class needs a better hashcode implementation since > it will be used in a Set. Do not instantiate a {{HashBuilder}} object every > time {{hashcode}} is called. Ouch. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org