[jira] [Updated] (HDFS-14494) Move Server logging of StatedId inside receiveRequestState()
[
https://issues.apache.org/jira/browse/HDFS-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Shvachko updated HDFS-14494:
---
Fix Version/s: 3.2.2
3.1.4
2.10.0
Just committed this to branches 3.2, 3.1, and 2.10. This is important because
otherwise HDFS-14822 fix is incomplete.
> Move Server logging of StatedId inside receiveRequestState()
>
>
> Key: HDFS-14494
> URL: https://issues.apache.org/jira/browse/HDFS-14494
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Konstantin Shvachko
>Assignee: Shweta
>Priority: Major
> Labels: newbie++
> Fix For: 2.10.0, 3.3.0, 3.1.4, 3.2.2
>
> Attachments: HDFS-14494.001.patch
>
>
> HDFS-14270 introduced logging of the client and server StateIds in trace
> level. Unfortunately one of the arguments
> {{alignmentContext.getLastSeenStateId()}} holds a lock on FSEdits, which is
> called even if trace logging level is disabled. I propose to move logging
> message inside {{GlobalStateIdContext.receiveRequestState()}} where
> {{clientStateId}} and {{serverStateId}} already calculated and can be easily
> printed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-14494) Move Server logging of StatedId inside receiveRequestState()
[
https://issues.apache.org/jira/browse/HDFS-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HDFS-14494:
---
Resolution: Fixed
Fix Version/s: 3.3.0
Status: Resolved (was: Patch Available)
Pushed to trunk.
Thanks [~shwetayakkali] for the patch and thanks [~shv] for reporting the issue!
> Move Server logging of StatedId inside receiveRequestState()
>
>
> Key: HDFS-14494
> URL: https://issues.apache.org/jira/browse/HDFS-14494
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Konstantin Shvachko
>Assignee: Shweta
>Priority: Major
> Labels: newbie++
> Fix For: 3.3.0
>
> Attachments: HDFS-14494.001.patch
>
>
> HDFS-14270 introduced logging of the client and server StateIds in trace
> level. Unfortunately one of the arguments
> {{alignmentContext.getLastSeenStateId()}} holds a lock on FSEdits, which is
> called even if trace logging level is disabled. I propose to move logging
> message inside {{GlobalStateIdContext.receiveRequestState()}} where
> {{clientStateId}} and {{serverStateId}} already calculated and can be easily
> printed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-14494) Move Server logging of StatedId inside receiveRequestState()
[
https://issues.apache.org/jira/browse/HDFS-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena updated HDFS-14494:
Status: Patch Available (was: Open)
> Move Server logging of StatedId inside receiveRequestState()
>
>
> Key: HDFS-14494
> URL: https://issues.apache.org/jira/browse/HDFS-14494
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Konstantin Shvachko
>Assignee: Shweta
>Priority: Major
> Labels: newbie++
> Attachments: HDFS-14494.001.patch
>
>
> HDFS-14270 introduced logging of the client and server StateIds in trace
> level. Unfortunately one of the arguments
> {{alignmentContext.getLastSeenStateId()}} holds a lock on FSEdits, which is
> called even if trace logging level is disabled. I propose to move logging
> message inside {{GlobalStateIdContext.receiveRequestState()}} where
> {{clientStateId}} and {{serverStateId}} already calculated and can be easily
> printed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-14494) Move Server logging of StatedId inside receiveRequestState()
[
https://issues.apache.org/jira/browse/HDFS-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shweta updated HDFS-14494:
--
Attachment: HDFS-14494.001.patch
> Move Server logging of StatedId inside receiveRequestState()
>
>
> Key: HDFS-14494
> URL: https://issues.apache.org/jira/browse/HDFS-14494
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Konstantin Shvachko
>Assignee: Shweta
>Priority: Major
> Labels: newbie++
> Attachments: HDFS-14494.001.patch
>
>
> HDFS-14270 introduced logging of the client and server StateIds in trace
> level. Unfortunately one of the arguments
> {{alignmentContext.getLastSeenStateId()}} holds a lock on FSEdits, which is
> called even if trace logging level is disabled. I propose to move logging
> message inside {{GlobalStateIdContext.receiveRequestState()}} where
> {{clientStateId}} and {{serverStateId}} already calculated and can be easily
> printed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
