[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HDFS-15579: Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk. Thanx [~Symious] for the contribution and [~elgoiri] for the review!!! > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Assignee: Janus Chow >Priority: Minor > Fix For: 3.4.0 > > Attachments: HDFS-15579-001.patch, HDFS-15579-002.patch, > HDFS-15579-003.patch, HDFS-15579-004.patch, HDFS-15579-005.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janus Chow updated HDFS-15579: -- Attachment: HDFS-15579-005.patch > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Assignee: Janus Chow >Priority: Minor > Attachments: HDFS-15579-001.patch, HDFS-15579-002.patch, > HDFS-15579-003.patch, HDFS-15579-004.patch, HDFS-15579-005.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janus Chow updated HDFS-15579: -- Attachment: HDFS-15579-004.patch > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Assignee: Janus Chow >Priority: Minor > Attachments: HDFS-15579-001.patch, HDFS-15579-002.patch, > HDFS-15579-003.patch, HDFS-15579-004.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janus Chow updated HDFS-15579: -- Attachment: HDFS-15579-003.patch > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Assignee: Janus Chow >Priority: Minor > Attachments: HDFS-15579-001.patch, HDFS-15579-002.patch, > HDFS-15579-003.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janus Chow updated HDFS-15579: -- Attachment: HDFS-15579-002.patch > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Assignee: Janus Chow >Priority: Minor > Attachments: HDFS-15579-001.patch, HDFS-15579-002.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri updated HDFS-15579: --- Status: Patch Available (was: Open) > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Priority: Minor > Attachments: HDFS-15579-001.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding
[ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janus Chow updated HDFS-15579: -- Attachment: HDFS-15579-001.patch > RBF: The constructor of PathLocation may got some misunderstanding > -- > > Key: HDFS-15579 > URL: https://issues.apache.org/jira/browse/HDFS-15579 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf >Reporter: Janus Chow >Priority: Minor > Attachments: HDFS-15579-001.patch > > > There is a constructor of PathLocation as follows, it's for creating a new > PathLocation with a prioritised nsId. > > {code:java} > public PathLocation(PathLocation other, String firstNsId) { > this.sourcePath = other.sourcePath; > this.destOrder = other.destOrder; > this.destinations = orderedNamespaces(other.destinations, firstNsId); > } > {code} > When I was reading the code of MultipleDestinationMountTableResolver, I > thought this constructor was to create a PathLocation with an override > destination. It took me a while before I realize this is a constructor to > sort the destinations inside. > Maybe I think this constructor can be more clear about its usage? > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org