[jira] [Updated] (HDFS-16042) DatanodeAdminMonitor scan should be delay based
[ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Brennan updated HDFS-16042: --- Fix Version/s: 3.3.2 3.2.3 2.10.2 Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the additional patches [~ahussein]! I have committed this to branch-3.3 - branch-2.10. > DatanodeAdminMonitor scan should be delay based > --- > > Key: HDFS-16042 > URL: https://issues.apache.org/jira/browse/HDFS-16042 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0, 2.10.2, 3.2.3, 3.3.2 > > Attachments: HDFS-16042-branch-2.10.001.patch, > HDFS-16042-branch-3.2.001.patch, HDFS-16042-branch-3.3.001.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a > fixed rate, ie. the period is from start1 -> start2. > {code:java} > executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs, >TimeUnit.SECONDS); > {code} > According to Java API docs for {{scheduleAtFixedRate}}, > {quote}If any execution of this task takes longer than its period, then > subsequent executions may start late, but will not concurrently > execute.{quote} > It should be a fixed delay so it's end1 -> start1. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16042) DatanodeAdminMonitor scan should be delay based
[ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated HDFS-16042: - Attachment: HDFS-16042-branch-2.10.001.patch > DatanodeAdminMonitor scan should be delay based > --- > > Key: HDFS-16042 > URL: https://issues.apache.org/jira/browse/HDFS-16042 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Attachments: HDFS-16042-branch-2.10.001.patch, > HDFS-16042-branch-3.2.001.patch, HDFS-16042-branch-3.3.001.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a > fixed rate, ie. the period is from start1 -> start2. > {code:java} > executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs, >TimeUnit.SECONDS); > {code} > According to Java API docs for {{scheduleAtFixedRate}}, > {quote}If any execution of this task takes longer than its period, then > subsequent executions may start late, but will not concurrently > execute.{quote} > It should be a fixed delay so it's end1 -> start1. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16042) DatanodeAdminMonitor scan should be delay based
[ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated HDFS-16042: - Attachment: HDFS-16042-branch-3.2.001.patch > DatanodeAdminMonitor scan should be delay based > --- > > Key: HDFS-16042 > URL: https://issues.apache.org/jira/browse/HDFS-16042 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Attachments: HDFS-16042-branch-3.2.001.patch, > HDFS-16042-branch-3.3.001.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a > fixed rate, ie. the period is from start1 -> start2. > {code:java} > executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs, >TimeUnit.SECONDS); > {code} > According to Java API docs for {{scheduleAtFixedRate}}, > {quote}If any execution of this task takes longer than its period, then > subsequent executions may start late, but will not concurrently > execute.{quote} > It should be a fixed delay so it's end1 -> start1. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16042) DatanodeAdminMonitor scan should be delay based
[ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated HDFS-16042: - Attachment: HDFS-16042-branch-3.3.001.patch Status: Patch Available (was: Reopened) no conflicts cherry-picking to branch-3.3 {code:bash} git cherry-pick -x a2a0283c7be8eac641a256f06731cb6e4bab3b09` {code} > DatanodeAdminMonitor scan should be delay based > --- > > Key: HDFS-16042 > URL: https://issues.apache.org/jira/browse/HDFS-16042 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Attachments: HDFS-16042-branch-3.3.001.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a > fixed rate, ie. the period is from start1 -> start2. > {code:java} > executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs, >TimeUnit.SECONDS); > {code} > According to Java API docs for {{scheduleAtFixedRate}}, > {quote}If any execution of this task takes longer than its period, then > subsequent executions may start late, but will not concurrently > execute.{quote} > It should be a fixed delay so it's end1 -> start1. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-16042) DatanodeAdminMonitor scan should be delay based
[ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDFS-16042: -- Labels: pull-request-available (was: ) > DatanodeAdminMonitor scan should be delay based > --- > > Key: HDFS-16042 > URL: https://issues.apache.org/jira/browse/HDFS-16042 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode >Reporter: Ahmed Hussein >Assignee: Ahmed Hussein >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a > fixed rate, ie. the period is from start1 -> start2. > {code:java} > executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs, >TimeUnit.SECONDS); > {code} > According to Java API docs for {{scheduleAtFixedRate}}, > {quote}If any execution of this task takes longer than its period, then > subsequent executions may start late, but will not concurrently > execute.{quote} > It should be a fixed delay so it's end1 -> start1. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org