[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2017-05-24 Thread Konstantin Shvachko (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konstantin Shvachko updated HDFS-6291:
--
Fix Version/s: 2.7.4

Just committed this to branch-2.7. Thank you [~elgoiri] for backport.

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Assignee: Sanghyun Yun
>Priority: Minor
> Fix For: 2.8.0, 2.7.4, 3.0.0-alpha1
>
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2015-05-07 Thread Vinayakumar B (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinayakumar B updated HDFS-6291:

   Resolution: Fixed
Fix Version/s: 2.8.0
 Assignee: Sanghyun Yun
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed to trunk and branch-2.
Thanks [~yunsh], [~ted_yu] and [~rakeshr]

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Assignee: Sanghyun Yun
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2015-05-07 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-6291:
--
Labels:   (was: BB2015-05-RFC)

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2015-05-07 Thread Rakesh R (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated HDFS-6291:
---
Labels: BB2015-05-RFC  (was: BB2015-05-TBR)

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-RFC
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2015-05-05 Thread Allen Wittenauer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HDFS-6291:
---
Labels: BB2015-05-TBR  (was: )

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2014-10-26 Thread Sanghyun Yun (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanghyun Yun updated HDFS-6291:
---
Attachment: HDFS-6291.2.patch

Thanks for your review, [~tedyu].
You are right. I removed image.close() in catch block.

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.2.patch, HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2014-08-19 Thread Sanghyun Yun (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanghyun Yun updated HDFS-6291:
---

Status: Patch Available  (was: Open)

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2014-08-19 Thread Sanghyun Yun (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanghyun Yun updated HDFS-6291:
---

Attachment: HDFS-6291.patch

I add image.close() in finally

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
> Attachments: HDFS-6291.patch
>
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun()

2014-05-11 Thread Ted Yu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HDFS-6291:
-

Component/s: ha

> FSImage may be left unclosed in BootstrapStandby#doRun()
> 
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: ha
>Reporter: Ted Yu
>Priority: Minor
>
> At around line 203:
> {code}
>   if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
>   }
> {code}
> If we return following the above check, image is not closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)