[jira] [Updated] (HDFS-9332) Fix Precondition failures from NameNodeEditLogRoller while saving namespace

2015-10-29 Thread Andrew Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HDFS-9332:
--
   Resolution: Fixed
Fix Version/s: 2.8.0
   Status: Resolved  (was: Patch Available)

Fixed, thanks for reviewing Yongjun and Mingliang!

> Fix Precondition failures from NameNodeEditLogRoller while saving namespace
> ---
>
> Key: HDFS-9332
> URL: https://issues.apache.org/jira/browse/HDFS-9332
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 2.3.0
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Fix For: 2.8.0
>
> Attachments: HDFS-9332.001.patch
>
>
> The check for the # of txns in the open edit log does not first check that an 
> edit log segment is open, leading to a Precondition failure. This surfaced at 
> HDFS-7871 which fixed that it was printing in a tight loop, but the cause of 
> the Precondition failure is still present.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-9332) Fix Precondition failures from NameNodeEditLogRoller while saving namespace

2015-10-28 Thread Andrew Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HDFS-9332:
--
Summary: Fix Precondition failures from NameNodeEditLogRoller while saving 
namespace  (was: Fix repeated Precondition failures from NameNodeEditLogRoller 
while saving namespace)

> Fix Precondition failures from NameNodeEditLogRoller while saving namespace
> ---
>
> Key: HDFS-9332
> URL: https://issues.apache.org/jira/browse/HDFS-9332
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 2.3.0
>Reporter: Andrew Wang
>Assignee: Andrew Wang
>
> The check for the # of txns in the open edit log does not first check that an 
> edit log segment is open, leading to a Precondition failure. This surfaced at 
> HDFS-7871 which fixed that it was printing in a tight loop, but the cause of 
> the Precondition failure is still present.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-9332) Fix Precondition failures from NameNodeEditLogRoller while saving namespace

2015-10-28 Thread Andrew Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HDFS-9332:
--
Status: Patch Available  (was: Open)

> Fix Precondition failures from NameNodeEditLogRoller while saving namespace
> ---
>
> Key: HDFS-9332
> URL: https://issues.apache.org/jira/browse/HDFS-9332
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 2.3.0
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Attachments: HDFS-9332.001.patch
>
>
> The check for the # of txns in the open edit log does not first check that an 
> edit log segment is open, leading to a Precondition failure. This surfaced at 
> HDFS-7871 which fixed that it was printing in a tight loop, but the cause of 
> the Precondition failure is still present.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (HDFS-9332) Fix Precondition failures from NameNodeEditLogRoller while saving namespace

2015-10-28 Thread Andrew Wang (JIRA)

 [ 
https://issues.apache.org/jira/browse/HDFS-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HDFS-9332:
--
Attachment: HDFS-9332.001.patch

Simple patch attached. FSNamesystem already has a method which does the correct 
validation, so just call that.

> Fix Precondition failures from NameNodeEditLogRoller while saving namespace
> ---
>
> Key: HDFS-9332
> URL: https://issues.apache.org/jira/browse/HDFS-9332
> Project: Hadoop HDFS
>  Issue Type: Bug
>Affects Versions: 2.3.0
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Attachments: HDFS-9332.001.patch
>
>
> The check for the # of txns in the open edit log does not first check that an 
> edit log segment is open, leading to a Precondition failure. This surfaced at 
> HDFS-7871 which fixed that it was printing in a tight loop, but the cause of 
> the Precondition failure is still present.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)