[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[ https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen updated HDFS-9408: -- Attachment: HDFS-9408.HDFS-8707.006.patch Thanks for testing the patch on MacOS and pointing out the issue. I don't have a machine / vm with MacOS handy. Hopefully, HDFS-9408.HDFS-8707.006.patch solves the issue. > extend the build system to produce static and dynamic libhdfspp libs > > > Key: HDFS-9408 > URL: https://issues.apache.org/jira/browse/HDFS-9408 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Stephen >Assignee: Stephen > Fix For: HDFS-8707 > > Attachments: HDFS-9408.HDFS-8707.001.patch, > HDFS-9408.HDFS-8707.002.patch, HDFS-9408.HDFS-8707.003.patch, > HDFS-9408.HDFS-8707.004.patch, HDFS-9408.HDFS-8707.005.patch, > HDFS-9408.HDFS-8707.006.patch > > > Generate static and dynamic libhdfspp libraries for use by other applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[
https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen updated HDFS-9408:
--
Attachment: HDFS-9408.HDFS-8707.005.patch
Thanks for the suggestions. Updated patch is attached.
{quote}It makes sense to play around with the order of the HDFSPP_SUBLIBS to
avoid the linker flags hacks.{quote}
I added a comment for this as well. It isn't about the order of the libs,
--whole-archive is required to link static libraries into a shared one.
> extend the build system to produce static and dynamic libhdfspp libs
>
>
> Key: HDFS-9408
> URL: https://issues.apache.org/jira/browse/HDFS-9408
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
>Reporter: Stephen
>Assignee: Stephen
> Fix For: HDFS-8707
>
> Attachments: HDFS-9408.HDFS-8707.001.patch,
> HDFS-9408.HDFS-8707.002.patch, HDFS-9408.HDFS-8707.003.patch,
> HDFS-9408.HDFS-8707.004.patch, HDFS-9408.HDFS-8707.005.patch
>
>
> Generate static and dynamic libhdfspp libraries for use by other applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[ https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen updated HDFS-9408: -- Attachment: HDFS-9408.HDFS-8707.004.patch Minor tweak for variable reuse. > extend the build system to produce static and dynamic libhdfspp libs > > > Key: HDFS-9408 > URL: https://issues.apache.org/jira/browse/HDFS-9408 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Stephen >Assignee: Stephen > Fix For: HDFS-8707 > > Attachments: HDFS-9408.HDFS-8707.001.patch, > HDFS-9408.HDFS-8707.002.patch, HDFS-9408.HDFS-8707.003.patch, > HDFS-9408.HDFS-8707.004.patch > > > Generate static and dynamic libhdfspp libraries for use by other applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[ https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen updated HDFS-9408: -- Attachment: HDFS-9408.HDFS-8707.003.patch Slight improvement to place empty.cc in the CMAKE_FILES_DIRECTORY. > extend the build system to produce static and dynamic libhdfspp libs > > > Key: HDFS-9408 > URL: https://issues.apache.org/jira/browse/HDFS-9408 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Stephen >Assignee: Stephen > Fix For: HDFS-8707 > > Attachments: HDFS-9408.HDFS-8707.001.patch, > HDFS-9408.HDFS-8707.002.patch, HDFS-9408.HDFS-8707.003.patch > > > Generate static and dynamic libhdfspp libraries for use by other applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[ https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen updated HDFS-9408: -- Attachment: HDFS-9408.HDFS-8707.002.patch HDFS-9408.HDFS-8707.002.patch will preserve the existing structure, of a lib per subdirectory. An alternative would be to provide a list of all subdirectory source files to add_library. Neither is perfect. I'm certainly open to suggestions. > extend the build system to produce static and dynamic libhdfspp libs > > > Key: HDFS-9408 > URL: https://issues.apache.org/jira/browse/HDFS-9408 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Stephen >Assignee: Stephen > Fix For: HDFS-8707 > > Attachments: HDFS-9408.HDFS-8707.001.patch, > HDFS-9408.HDFS-8707.002.patch > > > Generate static and dynamic libhdfspp libraries for use by other applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[ https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen updated HDFS-9408: -- Status: Patch Available (was: Open) No longer building a separate lib for each subdirectory, instead using OBJECT library type for those. The most interesting side effect is that each unit test executable now links against hdfspp, instead of a subset thereof. > extend the build system to produce static and dynamic libhdfspp libs > > > Key: HDFS-9408 > URL: https://issues.apache.org/jira/browse/HDFS-9408 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Stephen >Assignee: Stephen > Fix For: HDFS-8707 > > Attachments: HDFS-9408.HDFS-8707.001.patch > > > Generate static and dynamic libhdfspp libraries for use by other applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9408) extend the build system to produce static and dynamic libhdfspp libs
[ https://issues.apache.org/jira/browse/HDFS-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen updated HDFS-9408: -- Attachment: HDFS-9408.HDFS-8707.001.patch > extend the build system to produce static and dynamic libhdfspp libs > > > Key: HDFS-9408 > URL: https://issues.apache.org/jira/browse/HDFS-9408 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client >Reporter: Stephen >Assignee: Stephen > Fix For: HDFS-8707 > > Attachments: HDFS-9408.HDFS-8707.001.patch > > > Generate static and dynamic libhdfspp libraries for use by other applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
