[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=296662=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296662 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 16/Aug/19 23:39 Start Date: 16/Aug/19 23:39 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296662) Time Spent: 3h 20m (was: 3h 10m) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=296660=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296660 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 16/Aug/19 23:39 Start Date: 16/Aug/19 23:39 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-522181903 Test failures are not related to this patch. I will commit this to the trunk. Thank You @xiaoyuyao for the review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296660) Time Spent: 3h 10m (was: 3h) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=296659=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296659 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 16/Aug/19 23:39 Start Date: 16/Aug/19 23:39 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-522181903 Test failures are not related to this patch. I will commit this to the trunk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296659) Time Spent: 3h (was: 2h 50m) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=296533=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296533 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 16/Aug/19 20:06 Start Date: 16/Aug/19 20:06 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-522135167 /retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296533) Time Spent: 2h 50m (was: 2h 40m) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=296415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296415 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 16/Aug/19 16:45 Start Date: 16/Aug/19 16:45 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-522074978 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 82 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for branch | | +1 | mvninstall | 616 | trunk passed | | +1 | compile | 405 | trunk passed | | +1 | checkstyle | 73 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 962 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 188 | trunk passed | | 0 | spotbugs | 482 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 701 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 592 | the patch passed | | +1 | compile | 378 | the patch passed | | +1 | cc | 378 | the patch passed | | +1 | javac | 378 | the patch passed | | +1 | checkstyle | 74 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 775 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 188 | the patch passed | | +1 | findbugs | 739 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 372 | hadoop-hdds in the patch passed. | | -1 | unit | 2293 | hadoop-ozone in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 8674 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1257 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 22107f15db23 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 9b8359b | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/4/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/4/testReport/ | | Max. process+thread count | 4558 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/4/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296415) Time Spent: 2h 40m (was: 2.5h) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292390 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 10/Aug/19 02:00 Start Date: 10/Aug/19 02:00 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-520109012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 29 | Maven dependency ordering for branch | | +1 | mvninstall | 602 | trunk passed | | +1 | compile | 366 | trunk passed | | +1 | checkstyle | 72 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 983 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 223 | trunk passed | | 0 | spotbugs | 475 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 708 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for patch | | +1 | mvninstall | 643 | the patch passed | | +1 | compile | 413 | the patch passed | | +1 | cc | 413 | the patch passed | | +1 | javac | 413 | the patch passed | | +1 | checkstyle | 86 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 803 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 198 | the patch passed | | +1 | findbugs | 707 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 356 | hadoop-hdds in the patch passed. | | -1 | unit | 2145 | hadoop-ozone in the patch failed. | | +1 | asflicense | 42 | The patch does not generate ASF License warnings. | | | | 8671 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestKeyManagerImpl | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1257 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 5dd0fbb2f379 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / ce3c5a3 | | Default Java | 1.8.0_222 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/testReport/ | | Max. process+thread count | 4909 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 292390) Time Spent: 2.5h (was: 2h 20m) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 >
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292336=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292336 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 09/Aug/19 23:37 Start Date: 09/Aug/19 23:37 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-520095907 /retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 292336) Time Spent: 2h 10m (was: 2h) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292335=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292335
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 23:35
Start Date: 09/Aug/19 23:35
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1257:
HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312676316
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -388,7 +388,9 @@ public void deleteVolume(String volumeName) throws
IOException {
@Override
public void createBucket(String volumeName, String bucketName)
throws IOException {
-createBucket(volumeName, bucketName, BucketArgs.newBuilder().build());
+// Set acls of current user.
+createBucket(volumeName, bucketName,
+BucketArgs.newBuilder().setAcls(getAclList()).build());
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292335)
Time Spent: 2h (was: 1h 50m)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292334=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292334
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 23:27
Start Date: 09/Aug/19 23:27
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1257: HDDS-1913.
Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312675211
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java
##
@@ -134,17 +132,6 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
bucketInfoBuilder.addAllMetadata(KeyValueUtil
.getFromProtobuf(bucketArgs.getMetadataList()));
- //Check ACLs to update
- if (omBucketArgs.getAddAcls() != null ||
- omBucketArgs.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-omBucketArgs.getRemoveAcls(), omBucketArgs.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
We have a similar problem here because OMBucketArgs does not have acls, we
will need to rely on the oldBucketInfo.getAcls to avoid reset existing acl on
bucket.
bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292334)
Time Spent: 1h 50m (was: 1h 40m)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292333
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 23:27
Start Date: 09/Aug/19 23:27
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1257: HDDS-1913.
Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312675211
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketSetPropertyRequest.java
##
@@ -134,17 +132,6 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
bucketInfoBuilder.addAllMetadata(KeyValueUtil
.getFromProtobuf(bucketArgs.getMetadataList()));
- //Check ACLs to update
- if (omBucketArgs.getAddAcls() != null ||
- omBucketArgs.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-omBucketArgs.getRemoveAcls(), omBucketArgs.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
We have a similar problem here because OMBucketArgs does not have acls, we
will need to rely on the oldBucketInfo.getAcls to avoid reset existing acl on
bucket.
bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292333)
Time Spent: 1h 40m (was: 1.5h)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292332
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 23:20
Start Date: 09/Aug/19 23:20
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1257: HDDS-1913.
Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312674369
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -388,7 +388,9 @@ public void deleteVolume(String volumeName) throws
IOException {
@Override
public void createBucket(String volumeName, String bucketName)
throws IOException {
-createBucket(volumeName, bucketName, BucketArgs.newBuilder().build());
+// Set acls of current user.
+createBucket(volumeName, bucketName,
+BucketArgs.newBuilder().setAcls(getAclList()).build());
Review comment:
This will cause creator acls added twice into the final list because the
same list will be added again when the passin bucketArgs has a non-empty acl
list.
{code}
List listOfAcls = getAclList();
//ACLs from BucketArgs
if(bucketArgs.getAcls() != null) {
listOfAcls.addAll(bucketArgs.getAcls());
}
{code}
The list of acls are not merged properly when using List#addAll, which will
be fixed in HDDS-1927.
Let's file a separate JIRA for RpcClient#createBucket issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292332)
Time Spent: 1.5h (was: 1h 20m)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292235=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292235 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 09/Aug/19 20:17 Start Date: 09/Aug/19 20:17 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-520050278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 31 | Maven dependency ordering for branch | | +1 | mvninstall | 591 | trunk passed | | +1 | compile | 350 | trunk passed | | +1 | checkstyle | 61 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 794 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 152 | trunk passed | | 0 | spotbugs | 413 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 602 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 21 | Maven dependency ordering for patch | | +1 | mvninstall | 533 | the patch passed | | +1 | compile | 357 | the patch passed | | +1 | cc | 357 | the patch passed | | +1 | javac | 357 | the patch passed | | +1 | checkstyle | 68 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 648 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 148 | the patch passed | | +1 | findbugs | 678 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 288 | hadoop-hdds in the patch passed. | | -1 | unit | 1261 | hadoop-ozone in the patch failed. | | +1 | asflicense | 38 | The patch does not generate ASF License warnings. | | | | 6832 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.pipeline.TestNodeFailure | | | hadoop.ozone.om.TestKeyManagerImpl | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.web.TestOzoneWebAccess | | | hadoop.ozone.web.TestOzoneVolumes | | | hadoop.ozone.web.client.TestBuckets | | | hadoop.ozone.web.client.TestVolume | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler | | | hadoop.ozone.web.client.TestKeysRatis | | | hadoop.ozone.web.TestOzoneRestWithMiniCluster | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1257 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 01a93ff1f685 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 6ff0453 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/2/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/2/testReport/ | | Max. process+thread count | 3625 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/s3gateway hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 292235) Time Spent: 1h 20m (was: 1h 10m) > Fix OzoneBucket and RpcClient APIS for acl >
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292210 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 09/Aug/19 18:24 Start Date: 09/Aug/19 18:24 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-520017880 Thank You @xiaoyuyao for the review. Addressed review comments, and also fixed another issue when creating bucket in one API, not setting default ACL list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 292210) Time Spent: 1h (was: 50m) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292211 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 09/Aug/19 18:24 Start Date: 09/Aug/19 18:24 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-520017880 Thank You @xiaoyuyao for the review. Addressed review comments, and also fixed another issue when creating bucket in one API, not setting default ACL list. To fix find bug warning, removed ACLS from OzoneBucket. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 292211) Time Spent: 1h 10m (was: 1h) > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Blocker > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292208=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292208
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 18:23
Start Date: 09/Aug/19 18:23
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1257:
HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312597784
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##
@@ -272,16 +272,6 @@ public void setBucketProperty(OmBucketArgs args) throws
IOException {
.setBucketName(oldBucketInfo.getBucketName());
bucketInfoBuilder.addAllMetadata(args.getMetadata());
- //Check ACLs to update
- if (args.getAddAcls() != null || args.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-args.getRemoveAcls(), args.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
Thanks for catching fixed it, and also added a test to cover this scenario.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292208)
Time Spent: 40m (was: 0.5h)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292209
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 18:23
Start Date: 09/Aug/19 18:23
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1257:
HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312597784
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##
@@ -272,16 +272,6 @@ public void setBucketProperty(OmBucketArgs args) throws
IOException {
.setBucketName(oldBucketInfo.getBucketName());
bucketInfoBuilder.addAllMetadata(args.getMetadata());
- //Check ACLs to update
- if (args.getAddAcls() != null || args.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-args.getRemoveAcls(), args.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
Thanks for catching. Fixed it, and also added a test to cover this scenario.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292209)
Time Spent: 50m (was: 40m)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[
https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=292169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292169
]
ASF GitHub Bot logged work on HDDS-1913:
Author: ASF GitHub Bot
Created on: 09/Aug/19 16:57
Start Date: 09/Aug/19 16:57
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1257: HDDS-1913.
Fix OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312567041
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##
@@ -272,16 +272,6 @@ public void setBucketProperty(OmBucketArgs args) throws
IOException {
.setBucketName(oldBucketInfo.getBucketName());
bucketInfoBuilder.addAllMetadata(args.getMetadata());
- //Check ACLs to update
- if (args.getAddAcls() != null || args.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-args.getRemoveAcls(), args.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
We need to keep bucketInfoBuilder.setAcls(oldBucketInfo.getAcls()) otherwise
existing acls will be lost upon setBucketProperty. Can you add a unit test to
cover this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292169)
Time Spent: 0.5h (was: 20m)
> Fix OzoneBucket and RpcClient APIS for acl
> --
>
> Key: HDDS-1913
> URL: https://issues.apache.org/jira/browse/HDDS-1913
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's
> addAcl/removeAcl as part of HDDS-1739.
> Remove addBucketAcls, removeBucketAcls from RpcClient. We should use
> addAcl/removeAcl.
>
> And also fix @xiaoyu comment on HDDS-1900 jira.
> BucketManagerImpl#setBucketProperty() as they now require a different
> permission (WRITE_ACL instead of WRITE)?
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=291641=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291641 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 08/Aug/19 23:15 Start Date: 08/Aug/19 23:15 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257#issuecomment-519720318 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 85 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 8 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 26 | Maven dependency ordering for branch | | +1 | mvninstall | 642 | trunk passed | | +1 | compile | 391 | trunk passed | | +1 | checkstyle | 77 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 1059 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 238 | trunk passed | | 0 | spotbugs | 539 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 807 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 31 | Maven dependency ordering for patch | | +1 | mvninstall | 655 | the patch passed | | +1 | compile | 453 | the patch passed | | +1 | cc | 453 | the patch passed | | +1 | javac | 453 | the patch passed | | +1 | checkstyle | 109 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 868 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 205 | the patch passed | | -1 | findbugs | 551 | hadoop-ozone generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | -1 | unit | 395 | hadoop-hdds in the patch failed. | | -1 | unit | 3658 | hadoop-ozone in the patch failed. | | +1 | asflicense | 61 | The patch does not generate ASF License warnings. | | | | 10802 | | | Reason | Tests | |---:|:--| | FindBugs | module:hadoop-ozone | | | Unread field:OzoneBucket.java:[line 145] | | | Unwritten field:BucketArgs.java:[line 88] | | Failed junit tests | hadoop.hdds.scm.block.TestBlockManager | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.Test2WayCommitInRatis | | | hadoop.ozone.client.rpc.TestCommitWatcher | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.client.rpc.TestBlockOutputStream | | | hadoop.ozone.om.TestKeyManagerImpl | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1257 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 3b2f9bdfcadc 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 5840df8 | | Default Java | 1.8.0_212 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/1/artifact/out/new-findbugs-hadoop-ozone.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/1/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/1/testReport/ | | Max. process+thread count | 3877 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1257/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an
[jira] [Work logged] (HDDS-1913) Fix OzoneBucket and RpcClient APIS for acl
[ https://issues.apache.org/jira/browse/HDDS-1913?focusedWorklogId=291558=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291558 ] ASF GitHub Bot logged work on HDDS-1913: Author: ASF GitHub Bot Created on: 08/Aug/19 20:08 Start Date: 08/Aug/19 20:08 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl. URL: https://github.com/apache/hadoop/pull/1257 (cherry picked from commit b60d93b8b500f0ba97c027125401368d22028822) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 291558) Time Spent: 10m Remaining Estimate: 0h > Fix OzoneBucket and RpcClient APIS for acl > -- > > Key: HDDS-1913 > URL: https://issues.apache.org/jira/browse/HDDS-1913 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Fix addAcl,removeAcl in OzoneBucket to use newly added acl API's > addAcl/removeAcl as part of HDDS-1739. > Remove addBucketAcls, removeBucketAcls from RpcClient. We should use > addAcl/removeAcl. > > And also fix @xiaoyu comment on HDDS-1900 jira. > BucketManagerImpl#setBucketProperty() as they now require a different > permission (WRITE_ACL instead of WRITE)? -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
