[jira] [Work logged] (HDDS-2136) OM block allocation metric not paired with its failures
[ https://issues.apache.org/jira/browse/HDDS-2136?focusedWorklogId=314192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314192 ] ASF GitHub Bot logged work on HDDS-2136: Author: ASF GitHub Bot Created on: 18/Sep/19 08:25 Start Date: 18/Sep/19 08:25 Worklog Time Spent: 10m Work Description: adoroszlai commented on issue #1460: HDDS-2136. OM block allocation metric not paired with its failures URL: https://github.com/apache/hadoop/pull/1460#issuecomment-532577970 Thanks @bharatviswa504 for reviewing and merging it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314192) Time Spent: 1h (was: 50m) > OM block allocation metric not paired with its failures > --- > > Key: HDDS-2136 > URL: https://issues.apache.org/jira/browse/HDDS-2136 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Affects Versions: 0.4.1 >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Fix For: 0.5.0 > > Attachments: allocation_failures.png, allocations.png > > Time Spent: 1h > Remaining Estimate: 0h > > Block allocation count and block allocation failure count are shown in > separate graphs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2136) OM block allocation metric not paired with its failures
[ https://issues.apache.org/jira/browse/HDDS-2136?focusedWorklogId=314086=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314086 ] ASF GitHub Bot logged work on HDDS-2136: Author: ASF GitHub Bot Created on: 18/Sep/19 00:31 Start Date: 18/Sep/19 00:31 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1460: HDDS-2136. OM block allocation metric not paired with its failures URL: https://github.com/apache/hadoop/pull/1460#issuecomment-532466882 Thank You @adoroszlai for the contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314086) Time Spent: 50m (was: 40m) > OM block allocation metric not paired with its failures > --- > > Key: HDDS-2136 > URL: https://issues.apache.org/jira/browse/HDDS-2136 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Affects Versions: 0.4.1 >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Fix For: 0.5.0 > > Attachments: allocation_failures.png, allocations.png > > Time Spent: 50m > Remaining Estimate: 0h > > Block allocation count and block allocation failure count are shown in > separate graphs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2136) OM block allocation metric not paired with its failures
[ https://issues.apache.org/jira/browse/HDDS-2136?focusedWorklogId=314085=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314085 ] ASF GitHub Bot logged work on HDDS-2136: Author: ASF GitHub Bot Created on: 18/Sep/19 00:31 Start Date: 18/Sep/19 00:31 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #1460: HDDS-2136. OM block allocation metric not paired with its failures URL: https://github.com/apache/hadoop/pull/1460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314085) Time Spent: 40m (was: 0.5h) > OM block allocation metric not paired with its failures > --- > > Key: HDDS-2136 > URL: https://issues.apache.org/jira/browse/HDDS-2136 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Affects Versions: 0.4.1 >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Fix For: 0.5.0 > > Attachments: allocation_failures.png, allocations.png > > Time Spent: 40m > Remaining Estimate: 0h > > Block allocation count and block allocation failure count are shown in > separate graphs. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2136) OM block allocation metric not paired with its failures
[ https://issues.apache.org/jira/browse/HDDS-2136?focusedWorklogId=313731=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313731 ] ASF GitHub Bot logged work on HDDS-2136: Author: ASF GitHub Bot Created on: 17/Sep/19 14:50 Start Date: 17/Sep/19 14:50 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1460: HDDS-2136. OM block allocation metric not paired with its failures URL: https://github.com/apache/hadoop/pull/1460#issuecomment-532255847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 75 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | -1 | mvninstall | 30 | hadoop-ozone in trunk failed. | | -1 | compile | 19 | hadoop-ozone in trunk failed. | | +1 | checkstyle | 63 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 908 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 149 | trunk passed | | 0 | spotbugs | 172 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 23 | hadoop-ozone in trunk failed. | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 32 | hadoop-ozone in the patch failed. | | -1 | compile | 22 | hadoop-ozone in the patch failed. | | -1 | javac | 22 | hadoop-ozone in the patch failed. | | -0 | checkstyle | 31 | hadoop-ozone: The patch generated 2 new + 352 unchanged - 2 fixed = 354 total (was 354) | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 723 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 153 | the patch passed | | -1 | findbugs | 23 | hadoop-ozone in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 280 | hadoop-hdds in the patch failed. | | -1 | unit | 25 | hadoop-ozone in the patch failed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 3350 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1460 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 22d091fc3ff9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 7f90731 | | Default Java | 1.8.0_222 | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/branch-mvninstall-hadoop-ozone.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/branch-compile-hadoop-ozone.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/branch-findbugs-hadoop-ozone.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/patch-mvninstall-hadoop-ozone.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/patch-compile-hadoop-ozone.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/patch-compile-hadoop-ozone.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/diff-checkstyle-hadoop-ozone.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/patch-findbugs-hadoop-ozone.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1460/1/testReport/ | | Max. process+thread count | 400 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager | | Console output |
[jira] [Work logged] (HDDS-2136) OM block allocation metric not paired with its failures
[ https://issues.apache.org/jira/browse/HDDS-2136?focusedWorklogId=313624=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313624 ] ASF GitHub Bot logged work on HDDS-2136: Author: ASF GitHub Bot Created on: 17/Sep/19 11:05 Start Date: 17/Sep/19 11:05 Worklog Time Spent: 10m Work Description: adoroszlai commented on issue #1460: HDDS-2136. OM block allocation metric not paired with its failures URL: https://github.com/apache/hadoop/pull/1460#issuecomment-532173047 /label ozone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313624) Time Spent: 20m (was: 10m) > OM block allocation metric not paired with its failures > --- > > Key: HDDS-2136 > URL: https://issues.apache.org/jira/browse/HDDS-2136 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Affects Versions: 0.4.1 >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Attachments: allocation_failures.png, allocations.png > > Time Spent: 20m > Remaining Estimate: 0h > > Block allocation count and block allocation failure count are shown in > separate graphs. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-2136) OM block allocation metric not paired with its failures
[ https://issues.apache.org/jira/browse/HDDS-2136?focusedWorklogId=313623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313623 ] ASF GitHub Bot logged work on HDDS-2136: Author: ASF GitHub Bot Created on: 17/Sep/19 11:05 Start Date: 17/Sep/19 11:05 Worklog Time Spent: 10m Work Description: adoroszlai commented on pull request #1460: HDDS-2136. OM block allocation metric not paired with its failures URL: https://github.com/apache/hadoop/pull/1460 ## What changes were proposed in this pull request? Rename metric member variables for block allocation count and its failures to have the same prefix to ensure that they appear in the same chart. I think `BlockAllocations` is both a bit simpler than `BlockAllocateCalls` and more consistent with other metrics. https://issues.apache.org/jira/browse/HDDS-2136 ## How was this patch tested? Ran acceptance tests, checked OM Metrics web page. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313623) Remaining Estimate: 0h Time Spent: 10m > OM block allocation metric not paired with its failures > --- > > Key: HDDS-2136 > URL: https://issues.apache.org/jira/browse/HDDS-2136 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager >Affects Versions: 0.4.1 >Reporter: Doroszlai, Attila >Assignee: Doroszlai, Attila >Priority: Minor > Labels: pull-request-available > Attachments: allocation_failures.png, allocations.png > > Time Spent: 10m > Remaining Estimate: 0h > > Block allocation count and block allocation failure count are shown in > separate graphs. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
