[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323599=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323599
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 17:36
Start Date: 04/Oct/19 17:36
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on issue #1585: HDDS-2230. Invalid 
entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#issuecomment-538492308
 
 
   Thanks @xiaoyuyao and @elek for reviewing.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323599)
Time Spent: 2h  (was: 1h 50m)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323404=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323404
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 12:52
Start Date: 04/Oct/19 12:52
Worklog Time Spent: 10m 
  Work Description: elek commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323404)
Time Spent: 1h 50m  (was: 1h 40m)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323337=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323337
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 11:23
Start Date: 04/Oct/19 11:23
Worklog Time Spent: 10m 
  Work Description: elek commented on issue #1585: HDDS-2230. Invalid 
entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#issuecomment-538357881
 
 
   BTW we use very weak containers where we have passwordless sudo, we can add 
additional step after config generation and before startup to make the etc 
directory read only...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323337)
Time Spent: 1h 40m  (was: 1.5h)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323264
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 07:40
Start Date: 04/Oct/19 07:40
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#discussion_r331335642
 
 

 ##
 File path: 
hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml
 ##
 @@ -23,17 +23,23 @@ services:
   args:
 buildno: 1
 hostname: kdc
+networks:
+  - ozone
 
 Review comment:
   Default network does not work, since its name is `ozonesecure-mr_default`, 
which triggers `URISyntaxException` due to `_`.  Adding an explicit name avoids 
the `_default` suffix.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323264)
Time Spent: 1.5h  (was: 1h 20m)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-04 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323260=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323260
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 07:30
Start Date: 04/Oct/19 07:30
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on issue #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#issuecomment-538280533
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | 0 | yamllint | 0 | yamllint was not available. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | -1 | mvninstall | 33 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 36 | hadoop-ozone in trunk failed. |
   | -1 | compile | 24 | hadoop-hdds in trunk failed. |
   | -1 | compile | 18 | hadoop-ozone in trunk failed. |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 794 | branch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 27 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 25 | hadoop-ozone in trunk failed. |
   | -0 | patch | 893 | Used diff version of patch file. Binary files and 
potentially other changes not applied. Please rebase and squash commits if 
necessary. |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 40 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 42 | hadoop-ozone in the patch failed. |
   | -1 | compile | 29 | hadoop-hdds in the patch failed. |
   | -1 | compile | 24 | hadoop-ozone in the patch failed. |
   | -1 | javac | 29 | hadoop-hdds in the patch failed. |
   | -1 | javac | 24 | hadoop-ozone in the patch failed. |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 716 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 26 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 24 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 33 | hadoop-hdds in the patch failed. |
   | -1 | unit | 30 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 38 | The patch does not generate ASF License warnings. |
   | | | 2189 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1585 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient yamllint shellcheck shelldocs |
   | uname | Linux d730fd7431e9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / ec8f691 |
   | Default Java | 1.8.0_222 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/branch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/branch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/branch-javadoc-hadoop-ozone.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/patch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/2/artifact/out/patch-compile-hadoop-ozone.txt
 |
   | javac | 

[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323180=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323180
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 04:18
Start Date: 04/Oct/19 04:18
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#discussion_r331336022
 
 

 ##
 File path: 
hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml
 ##
 @@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-version: "3"
+version: "3.5"
 
 Review comment:
   Docker Compose file [version 
3.5](https://docs.docker.com/compose/compose-file/compose-versioning/#version-35)
 is the first to allow `name` for networks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323180)
Time Spent: 1h 10m  (was: 1h)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323179
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 04:15
Start Date: 04/Oct/19 04:15
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#discussion_r331335642
 
 

 ##
 File path: 
hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml
 ##
 @@ -23,17 +23,23 @@ services:
   args:
 buildno: 1
 hostname: kdc
+networks:
+  - ozone
 
 Review comment:
   Default network does not work, since it's name is `ozonesecure-mr_default`, 
which triggers `URISyntaxException` due to `_`.  Adding an explicit name avoids 
the `_default` suffix.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323179)
Time Spent: 1h  (was: 50m)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323147=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323147
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 02:24
Start Date: 04/Oct/19 02:24
Worklog Time Spent: 10m 
  Work Description: xiaoyuyao commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#discussion_r331321334
 
 

 ##
 File path: 
hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml
 ##
 @@ -23,17 +23,23 @@ services:
   args:
 buildno: 1
 hostname: kdc
+networks:
+  - ozone
 
 Review comment:
   Does default network work for this case? why do we explicitly change the 
network name?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323147)
Time Spent: 50m  (was: 40m)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=323145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323145
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 04/Oct/19 02:23
Start Date: 04/Oct/19 02:23
Worklog Time Spent: 10m 
  Work Description: xiaoyuyao commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#discussion_r331321174
 
 

 ##
 File path: 
hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml
 ##
 @@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-version: "3"
+version: "3.5"
 
 Review comment:
   Do we track the docker-compose versions for this change?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323145)
Time Spent: 40m  (was: 0.5h)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=322882=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322882
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 03/Oct/19 19:40
Start Date: 03/Oct/19 19:40
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on issue #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#issuecomment-538097009
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 601 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | yamllint | 0 | yamllint was not available. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | -1 | mvninstall | 65 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 50 | hadoop-ozone in trunk failed. |
   | -1 | compile | 23 | hadoop-hdds in trunk failed. |
   | -1 | compile | 19 | hadoop-ozone in trunk failed. |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 960 | branch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 30 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 23 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | -1 | mvninstall | 43 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 42 | hadoop-ozone in the patch failed. |
   | -1 | compile | 32 | hadoop-hdds in the patch failed. |
   | -1 | compile | 22 | hadoop-ozone in the patch failed. |
   | -1 | javac | 32 | hadoop-hdds in the patch failed. |
   | -1 | javac | 22 | hadoop-ozone in the patch failed. |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 844 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 25 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 21 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 32 | hadoop-hdds in the patch failed. |
   | -1 | unit | 29 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 39 | The patch does not generate ASF License warnings. |
   | | | 3090 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.2 Server=19.03.2 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1585 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient yamllint shellcheck shelldocs |
   | uname | Linux acf49af14521 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / a3fe404 |
   | Default Java | 1.8.0_222 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/branch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/branch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/branch-javadoc-hadoop-ozone.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/patch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/patch-compile-hadoop-ozone.txt
 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1585/1/artifact/out/patch-compile-hadoop-hdds.txt
 |
   | javac | 

[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=322863=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322863
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 03/Oct/19 18:48
Start Date: 03/Oct/19 18:48
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on issue #1585: HDDS-2230. Invalid 
entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585#issuecomment-538076287
 
 
   /label ozone
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 322863)
Time Spent: 20m  (was: 10m)

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDDS-2230) Invalid entries in ozonesecure-mr config

2019-10-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2230?focusedWorklogId=322860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322860
 ]

ASF GitHub Bot logged work on HDDS-2230:


Author: ASF GitHub Bot
Created on: 03/Oct/19 18:47
Start Date: 03/Oct/19 18:47
Worklog Time Spent: 10m 
  Work Description: adoroszlai commented on pull request #1585: HDDS-2230. 
Invalid entries in ozonesecure-mr config
URL: https://github.com/apache/hadoop/pull/1585
 
 
   ## What changes were proposed in this pull request?
   
   1. Fix invalid entries in `docker-config` of `ozonesecure-mr`.  These 
variables:
 * did not follow the naming convention of `envtoconf` (eg. missing `_`) 
and were ignored, or
 * had typos in the filename portion (eg. `YARN_SITE.XML` instead of 
`YARN-SITE.XML`), and so were generated into the wrong config files.
   2. Disable `LinuxContainerExecutor`, which requires `root` ownership of the 
config directory and does not work with the `hadoop-runner` image.
   3. Avoid `_` in hostname and domain name of Timeline History Server, because 
`URI` parsing fails in the client.  This is achieved by using a custom 
container name (for `jhs` only) and network name (for all services in the 
compose env).
   
   Thanks @xiaoyuyao for finding the cause and fix for (2).
   
   https://issues.apache.org/jira/browse/HDDS-2230
   
   ## How was this patch tested?
   
   Ran acceptance test in `ozonesecure-mr`.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 322860)
Remaining Estimate: 0h
Time Spent: 10m

> Invalid entries in ozonesecure-mr config
> 
>
> Key: HDDS-2230
> URL: https://issues.apache.org/jira/browse/HDDS-2230
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: docker
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Attachments: HDDS-2230.001.patch, HDDS-2230.002.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Some of the entries in {{ozonesecure-mr/docker-config}} are in invalid 
> format, thus they end up missing from the generated config files.
> {noformat}
> $ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozonesecure-mr
> $ ./test.sh # configs are generated during container startup
> $ cd ../..
> $ grep -c 'ozone.administrators' compose/ozonesecure-mr/docker-config
> 1
> $ grep -c 'ozone.administrators' etc/hadoop/ozone-site.xml
> 0
> $ grep -c 'yarn.timeline-service' compose/ozonesecure-mr/docker-config
> 5
> $ grep -c 'yarn.timeline-service' etc/hadoop/yarn-site.xml
> 2
> $ grep -c 'container-executor' compose/ozonesecure-mr/docker-config
> 3
> $ grep -c 'container-executor' etc/hadoop/yarn-site.xml
> 0
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org