[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=488996=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488996
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 23/Sep/20 04:26
Start Date: 23/Sep/20 04:26
Worklog Time Spent: 10m 
  Work Description: goiri commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-696913823


   @liuml07 any further comments?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 488996)
Time Spent: 2h 50m  (was: 2h 40m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=488869=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488869
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 23/Sep/20 04:15
Start Date: 23/Sep/20 04:15
Worklog Time Spent: 10m 
  Work Description: goiri merged pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 488869)
Time Spent: 2h 40m  (was: 2.5h)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=488786=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488786
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 23/Sep/20 04:09
Start Date: 23/Sep/20 04:09
Worklog Time Spent: 10m 
  Work Description: liuml07 commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-696915170


   +1
   
   Not sure why the QA is not coming back cleanly here...not related to the 
change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 488786)
Time Spent: 2.5h  (was: 2h 20m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=488576=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488576
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 22/Sep/20 20:23
Start Date: 22/Sep/20 20:23
Worklog Time Spent: 10m 
  Work Description: goiri merged pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 488576)
Time Spent: 2h 20m  (was: 2h 10m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=488515=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488515
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 22/Sep/20 18:55
Start Date: 22/Sep/20 18:55
Worklog Time Spent: 10m 
  Work Description: liuml07 commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-696915170


   +1
   
   Not sure why the QA is not coming back cleanly here...not related to the 
change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 488515)
Time Spent: 2h 10m  (was: 2h)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=488509=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488509
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 22/Sep/20 18:53
Start Date: 22/Sep/20 18:53
Worklog Time Spent: 10m 
  Work Description: goiri commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-696913823


   @liuml07 any further comments?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 488509)
Time Spent: 2h  (was: 1h 50m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=487737=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487737
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 22/Sep/20 03:31
Start Date: 22/Sep/20 03:31
Worklog Time Spent: 10m 
  Work Description: NickyYe commented on a change in pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#discussion_r491797152



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AtomicFileOutputStream.java
##
@@ -75,8 +76,13 @@ public void close() throws IOException {
 boolean renamed = tmpFile.renameTo(origFile);
 if (!renamed) {
   // On windows, renameTo does not replace.
-  if (origFile.exists() && !origFile.delete()) {
-throw new IOException("Could not delete original file " + 
origFile);
+  if (origFile.exists()) {
+try {
+  Files.delete(origFile.toPath());
+} catch (IOException e) {
+  throw new IOException("Could not delete original file " + 
origFile

Review comment:
   Fixed. Thanks.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 487737)
Time Spent: 1h 50m  (was: 1h 40m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=487626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487626
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 22/Sep/20 03:22
Start Date: 22/Sep/20 03:22
Worklog Time Spent: 10m 
  Work Description: goiri commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-696264939


   Not sure why the build came out so badly... let's see if we can retrigger.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 487626)
Time Spent: 1h 40m  (was: 1.5h)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=487467=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487467
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 22/Sep/20 03:04
Start Date: 22/Sep/20 03:04
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-695921398


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |  31m 11s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ trunk Compile Tests _ |
   | -1 :x: |  mvninstall  |  16m 16s |  root in trunk failed.  |
   | -1 :x: |  compile  |   0m 17s |  hadoop-hdfs in trunk failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 26s |  hadoop-hdfs in trunk failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  trunk passed  |
   | -1 :x: |  mvnsite  |   0m 25s |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |   1m 49s |  branch has no errors when 
building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   0m 26s |  hadoop-hdfs in trunk failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javadoc  |   0m 26s |  hadoop-hdfs in trunk failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | +0 :ok: |  spotbugs  |   3m  8s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   0m 25s |  hadoop-hdfs in trunk failed.  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m 22s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   0m 22s |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   0m 22s |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 21s |  hadoop-hdfs in the patch failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   0m 21s |  hadoop-hdfs in the patch failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -0 :warning: |  checkstyle  |   0m 20s |  The patch fails to run 
checkstyle in hadoop-hdfs  |
   | -1 :x: |  mvnsite  |   0m 23s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedclient  |   0m 21s |  patch has no errors when 
building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   0m 23s |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javadoc  |   0m 23s |  hadoop-hdfs in the patch failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  findbugs  |   0m 22s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 21s |  hadoop-hdfs in the patch failed.  |
   | +0 :ok: |  asflicense  |   0m 22s |  ASF License check generated no 
output?  |
   |  |   |  59m  1s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2274/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2274 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 62e70170050b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 7a6265ac425 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2274/4/artifact/out/branch-mvninstall-root.txt
 |
   | compile | 

[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=487119=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487119
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 21/Sep/20 17:40
Start Date: 21/Sep/20 17:40
Worklog Time Spent: 10m 
  Work Description: goiri commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-696264939


   Not sure why the build came out so badly... let's see if we can retrigger.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 487119)
Time Spent: 1h 20m  (was: 1h 10m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=486780=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486780
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 21/Sep/20 06:16
Start Date: 21/Sep/20 06:16
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-695921398


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |  31m 11s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ trunk Compile Tests _ |
   | -1 :x: |  mvninstall  |  16m 16s |  root in trunk failed.  |
   | -1 :x: |  compile  |   0m 17s |  hadoop-hdfs in trunk failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 26s |  hadoop-hdfs in trunk failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  trunk passed  |
   | -1 :x: |  mvnsite  |   0m 25s |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |   1m 49s |  branch has no errors when 
building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   0m 26s |  hadoop-hdfs in trunk failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javadoc  |   0m 26s |  hadoop-hdfs in trunk failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | +0 :ok: |  spotbugs  |   3m  8s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | -1 :x: |  findbugs  |   0m 25s |  hadoop-hdfs in trunk failed.  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m 22s |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   0m 22s |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javac  |   0m 22s |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  compile  |   0m 21s |  hadoop-hdfs in the patch failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  javac  |   0m 21s |  hadoop-hdfs in the patch failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -0 :warning: |  checkstyle  |   0m 20s |  The patch fails to run 
checkstyle in hadoop-hdfs  |
   | -1 :x: |  mvnsite  |   0m 23s |  hadoop-hdfs in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedclient  |   0m 21s |  patch has no errors when 
building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   0m 23s |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.  |
   | -1 :x: |  javadoc  |   0m 23s |  hadoop-hdfs in the patch failed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.  |
   | -1 :x: |  findbugs  |   0m 22s |  hadoop-hdfs in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 21s |  hadoop-hdfs in the patch failed.  |
   | +0 :ok: |  asflicense  |   0m 22s |  ASF License check generated no 
output?  |
   |  |   |  59m  1s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2274/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2274 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 62e70170050b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 7a6265ac425 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2274/4/artifact/out/branch-mvninstall-root.txt
 |
   | compile | 

[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-20 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=486765=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486765
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 21/Sep/20 05:16
Start Date: 21/Sep/20 05:16
Worklog Time Spent: 10m 
  Work Description: NickyYe commented on a change in pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#discussion_r491797152



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AtomicFileOutputStream.java
##
@@ -75,8 +76,13 @@ public void close() throws IOException {
 boolean renamed = tmpFile.renameTo(origFile);
 if (!renamed) {
   // On windows, renameTo does not replace.
-  if (origFile.exists() && !origFile.delete()) {
-throw new IOException("Could not delete original file " + 
origFile);
+  if (origFile.exists()) {
+try {
+  Files.delete(origFile.toPath());
+} catch (IOException e) {
+  throw new IOException("Could not delete original file " + 
origFile

Review comment:
   Fixed. Thanks.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 486765)
Time Spent: 1h  (was: 50m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=478927=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478927
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 04/Sep/20 04:21
Start Date: 04/Sep/20 04:21
Worklog Time Spent: 10m 
  Work Description: liuml07 commented on a change in pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#discussion_r483377105



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/util/AtomicFileOutputStream.java
##
@@ -75,8 +76,13 @@ public void close() throws IOException {
 boolean renamed = tmpFile.renameTo(origFile);
 if (!renamed) {
   // On windows, renameTo does not replace.
-  if (origFile.exists() && !origFile.delete()) {
-throw new IOException("Could not delete original file " + 
origFile);
+  if (origFile.exists()) {
+try {
+  Files.delete(origFile.toPath());
+} catch (IOException e) {
+  throw new IOException("Could not delete original file " + 
origFile

Review comment:
   Is it simpler
   ```
   throw new IOException("Could not delete original file " + origFile, e);
   ```
   
   Other than that, +1





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 478927)
Time Spent: 50m  (was: 40m)

> Log the reason why a storage log file can't be deleted
> --
>
> Key: HDFS-15557
> URL: https://issues.apache.org/jira/browse/HDFS-15557
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Ye Ni
>Assignee: Ye Ni
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Before
>  
> {code:java}
> 2020-09-02 06:48:31,983 WARN [IPC Server handler 206 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid{code}
>  
> After
>  
> {code:java}
> 2020-09-02 17:43:29,421 WARN [IPC Server handler 111 on 8020] 
> org.apache.hadoop.hdfs.server.common.Storage: writeTransactionIdToStorage 
> failed on Storage Directory root= K:\data\hdfs\namenode; location= null; 
> type= IMAGE; isShared= false; lock= 
> sun.nio.ch.FileLockImpl[0:9223372036854775807 exclusive valid]; storageUuid= 
> null java.io.IOException: Could not delete original file 
> K:\data\hdfs\namenode\current\seen_txid due to failure: 
> java.nio.file.FileSystemException: K:\data\hdfs\namenode\current\seen_txid: 
> The process cannot access the file because it is being used by another 
> process.{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=478920=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478920
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 04/Sep/20 03:29
Start Date: 04/Sep/20 03:29
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-686880097


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  28m  6s |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 16s |  trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |   1m 12s |  trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   0m 48s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 20s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m 25s |  branch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 52s |  trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 27s |  trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   3m  0s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 58s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 10s |  the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javac  |   1m 10s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  3s |  the patch passed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  javac  |   1m  3s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 39s |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m  8s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedclient  |  13m 54s |  patch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 45s |  the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 19s |  the patch passed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  findbugs  |   3m  4s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  94m 42s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 43s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 176m 26s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics |
   |   | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
   |   | hadoop.hdfs.TestReconstructStripedFile |
   |   | hadoop.hdfs.TestFileChecksumCompositeCrc |
   |   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
   |   | hadoop.hdfs.TestFileChecksum |
   |   | hadoop.hdfs.TestGetFileChecksum |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2274/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2274 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 68f01445e536 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 139a43e98e2 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 
/usr/lib/jvm/java-8-openjdk-amd64:Private 

[jira] [Work logged] (HDFS-15557) Log the reason why a storage log file can't be deleted

2020-09-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDFS-15557?focusedWorklogId=478886=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478886
 ]

ASF GitHub Bot logged work on HDFS-15557:
-

Author: ASF GitHub Bot
Created on: 04/Sep/20 01:52
Start Date: 04/Sep/20 01:52
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #2274:
URL: https://github.com/apache/hadoop/pull/2274#issuecomment-686852824


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |  28m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  28m 13s |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 17s |  trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  compile  |   1m 11s |  trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   0m 49s |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 18s |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  16m 15s |  branch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 51s |  trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 22s |  trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +0 :ok: |  spotbugs  |   2m 58s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 56s |  trunk passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  8s |  the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javac  |   1m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  the patch passed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  javac  |   1m  4s |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 40s |  hadoop-hdfs-project/hadoop-hdfs: 
The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)  |
   | +1 :green_heart: |  mvnsite  |   1m 12s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  shadedclient  |  13m 51s |  patch has no errors when 
building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 51s |  the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1  |
   | +1 :green_heart: |  javadoc  |   1m 25s |  the patch passed with JDK 
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01  |
   | +1 :green_heart: |  findbugs  |   3m  7s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  97m 52s |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 42s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 207m 42s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.TestFileChecksumCompositeCrc |
   |   | hadoop.hdfs.TestMultipleNNPortQOP |
   |   | hadoop.hdfs.TestFileAppend4 |
   |   | hadoop.hdfs.TestErasureCodingExerciseAPIs |
   |   | hadoop.hdfs.TestFileChecksum |
   |   | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier |
   |   | hadoop.hdfs.TestDFSStripedOutputStream |
   |   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure |
   |   | hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2274/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2274 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux c407a908478b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 139a43e98e2 |
   | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
   | Multi-JDK versions |