[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=692482=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692482
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 08/Dec/21 11:44
Start Date: 08/Dec/21 11:44
Worklog Time Spent: 10m
Work Description: aajisaka merged pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 692482)
Time Spent: 1h 40m (was: 1.5h)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
> Components: nfs
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-15862.001.patch, HDFS-15862.002.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=692483=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692483
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 08/Dec/21 11:44
Start Date: 08/Dec/21 11:44
Worklog Time Spent: 10m
Work Description: aajisaka commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-988740709
Merged. Thank you @lzx404243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 692483)
Time Spent: 1h 50m (was: 1h 40m)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
> Components: nfs
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-15862.001.patch, HDFS-15862.002.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=681181=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681181
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 13/Nov/21 23:56
Start Date: 13/Nov/21 23:56
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-968177161
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 40s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 21s | | trunk passed |
| +1 :green_heart: | compile | 0m 31s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 29s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 26s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 34s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 47s | | trunk passed |
| +1 :green_heart: | shadedclient | 19m 22s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 22s | | the patch passed |
| +1 :green_heart: | compile | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 21s | | the patch passed |
| +1 :green_heart: | compile | 0m 19s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 19s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 14s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 22s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 47s | | the patch passed |
| +1 :green_heart: | shadedclient | 19m 16s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 42s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 84m 5s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2724 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 9a28fb974821 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 6c75449ec743b967ecef200469655b30ba6a6fc9 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/3/testReport/ |
| Max. process+thread count | 549 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-nfs U:
hadoop-hdfs-project/hadoop-hdfs-nfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/3/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=681169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681169
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 13/Nov/21 22:31
Start Date: 13/Nov/21 22:31
Worklog Time Spent: 10m
Work Description: lzx404243 commented on a change in pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#discussion_r748772830
##
File path:
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestViewfsWithNfs3.java
##
@@ -316,6 +316,10 @@ public void testNfsRenameSingleNN() throws Exception {
nn1.getRpcServer().getFileInfo("/user1/renameSingleNN");
Assert.assertEquals(statusBeforeRename.isDirectory(), false);
+Path successFilePath = new Path("/user1/renameSingleNNSucess");
+if (hdfs1.exists(successFilePath)) {
+ hdfs1.delete(successFilePath, false);
+}
Review comment:
Thanks @aajisaka for pointing that out! Updated the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 681169)
Time Spent: 1h 20m (was: 1h 10m)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-15862.001.patch, HDFS-15862.002.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=645188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645188
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 01/Sep/21 09:48
Start Date: 01/Sep/21 09:48
Worklog Time Spent: 10m
Work Description: aajisaka commented on a change in pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#discussion_r700048007
##
File path:
hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestViewfsWithNfs3.java
##
@@ -316,6 +316,10 @@ public void testNfsRenameSingleNN() throws Exception {
nn1.getRpcServer().getFileInfo("/user1/renameSingleNN");
Assert.assertEquals(statusBeforeRename.isDirectory(), false);
+Path successFilePath = new Path("/user1/renameSingleNNSucess");
+if (hdfs1.exists(successFilePath)) {
+ hdfs1.delete(successFilePath, false);
+}
Review comment:
You don't need to check if the file exists. Just calling delete is
sufficient:
https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/filesystem/filesystem.html#boolean_delete.28Path_p.2C_boolean_recursive.29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 645188)
Time Spent: 1h 10m (was: 1h)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-15862.001.patch, HDFS-15862.002.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=644467=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644467
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 31/Aug/21 15:27
Start Date: 31/Aug/21 15:27
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-908942305
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 13m 8s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 27s | | trunk passed |
| +1 :green_heart: | compile | 0m 30s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 32s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 50s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 35s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 26s | | the patch passed |
| +1 :green_heart: | compile | 0m 24s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 24s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 15s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 51s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 50s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 58s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 93m 10s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2724 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 3441aa40f3c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 75d6bb6fe30634f905bab8bdadf1eb0e882d97a9 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/2/testReport/ |
| Max. process+thread count | 636 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-nfs U:
hadoop-hdfs-project/hadoop-hdfs-nfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=644364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644364
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 31/Aug/21 15:15
Start Date: 31/Aug/21 15:15
Worklog Time Spent: 10m
Work Description: lzx404243 commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-908901777
@aajisaka Thanks for the feedback! I've made the corresponding changes
following your suggestion. Please let me know what you think.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 644364)
Time Spent: 50m (was: 40m)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-15862.001.patch, HDFS-15862.002.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=643880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643880
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 31/Aug/21 06:36
Start Date: 31/Aug/21 06:36
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-908942305
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 13m 8s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 27s | | trunk passed |
| +1 :green_heart: | compile | 0m 30s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 27s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 32s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 50s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 35s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 26s | | the patch passed |
| +1 :green_heart: | compile | 0m 24s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 24s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 15s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 0m 51s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 50s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 58s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not
generate ASF License warnings. |
| | | 93m 10s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2724 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 3441aa40f3c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 75d6bb6fe30634f905bab8bdadf1eb0e882d97a9 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/2/testReport/ |
| Max. process+thread count | 636 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-nfs U:
hadoop-hdfs-project/hadoop-hdfs-nfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2724/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=643862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643862
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 31/Aug/21 05:05
Start Date: 31/Aug/21 05:05
Worklog Time Spent: 10m
Work Description: lzx404243 commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-908901777
@aajisaka Thanks for the feedback! I've made the corresponding changes
following your suggestion. Please let me know what you think.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 643862)
Time Spent: 0.5h (was: 20m)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-15862.001.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=637920=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637920
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 14/Aug/21 01:59
Start Date: 14/Aug/21 01:59
Worklog Time Spent: 10m
Work Description: lzx404243 commented on pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724#issuecomment-898793941
Hi @aajisaka , could you please help reviewing this change? It resolves
similar issues as https://github.com/apache/hadoop/pull/2499 . Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 637920)
Remaining Estimate: 0h
Time Spent: 20m (was: 10m)
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Attachments: HDFS-15862.001.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
>
> Link to PR: https://github.com/apache/hadoop/pull/2724
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-15862) Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
[
https://issues.apache.org/jira/browse/HDFS-15862?focusedWorklogId=558415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558415
]
ASF GitHub Bot logged work on HDFS-15862:
-
Author: ASF GitHub Bot
Created on: 26/Feb/21 06:54
Start Date: 26/Feb/21 06:54
Worklog Time Spent: 10m
Work Description: lzx404243 opened a new pull request #2724:
URL: https://github.com/apache/hadoop/pull/2724
The test
`org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN` is
not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
### Details
Running `TestViewfsWithNfs3.testNfsRenameSingleNN` twice would result in the
second run failing with the a NullPointer exception:
```
[ERROR] Errors:
[ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
```
The reason for this is that the `/user1/renameSingleNN` file is created in
`setup()`, but gets renamed in`testNfsRenameSingleNN`. When the second run of
`testNfsRenameSingleNN` tries to get info of the file by its original name, it
returns a NullPointer since the file no longer exists.
The fix for this is to rename the file back to the original when the test is
done.
With the proposed fix, the test does not pollute the shared state (and
passes when run twice in the same JVM).
Link to JIRA issue: https://issues.apache.org/jira/browse/HDFS-15862
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 558415)
Remaining Estimate: 0h
Time Spent: 10m
> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
>
>
> Key: HDFS-15862
> URL: https://issues.apache.org/jira/browse/HDFS-15862
> Project: Hadoop HDFS
> Issue Type: Test
>Reporter: Zhengxi Li
>Assignee: Zhengxi Li
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN'
> test is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR] TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN. When the
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its
> original name, it returns a NullPointer since the file no longer exists.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
