[jira] [Work logged] (HDFS-16194) Add a public method DatanodeID#getDisplayName

2021-09-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16194?focusedWorklogId=646096=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646096
 ]

ASF GitHub Bot logged work on HDFS-16194:
-

Author: ASF GitHub Bot
Created on: 02/Sep/21 23:51
Start Date: 02/Sep/21 23:51
Worklog Time Spent: 10m 
  Work Description: tasanuma commented on a change in pull request #3354:
URL: https://github.com/apache/hadoop/pull/3354#discussion_r701494232



##
File path: 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
##
@@ -255,6 +255,13 @@ public int getXferPort() {
 return xferPort;
   }
 
+  /**
+   * @return name useful for logging or display
+   */
+  public String getDisplayName() {

Review comment:
   `DatanodeID#getXferAddrWithHostname()` is the same method, isn't it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 646096)
Time Spent: 1h  (was: 50m)

> Add a public method DatanodeID#getDisplayName
> -
>
> Key: HDFS-16194
> URL: https://issues.apache.org/jira/browse/HDFS-16194
> Project: Hadoop HDFS
>  Issue Type: Wish
>Reporter: tomscut
>Assignee: tomscut
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Add a public method DatanodeID#getDisplayName to simplify the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16194) Add a public method DatanodeID#getDisplayName

2021-09-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16194?focusedWorklogId=645734=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645734
 ]

ASF GitHub Bot logged work on HDFS-16194:
-

Author: ASF GitHub Bot
Created on: 02/Sep/21 06:03
Start Date: 02/Sep/21 06:03
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3354:
URL: https://github.com/apache/hadoop/pull/3354#issuecomment-911232984


   > LGTM. +1
   
   Thanks @Hexiaoqiao for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 645734)
Time Spent: 50m  (was: 40m)

> Add a public method DatanodeID#getDisplayName
> -
>
> Key: HDFS-16194
> URL: https://issues.apache.org/jira/browse/HDFS-16194
> Project: Hadoop HDFS
>  Issue Type: Wish
>Reporter: tomscut
>Assignee: tomscut
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Add a public method DatanodeID#getDisplayName to simplify the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16194) Add a public method DatanodeID#getDisplayName

2021-09-01 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16194?focusedWorklogId=645713=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645713
 ]

ASF GitHub Bot logged work on HDFS-16194:
-

Author: ASF GitHub Bot
Created on: 02/Sep/21 04:58
Start Date: 02/Sep/21 04:58
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3354:
URL: https://github.com/apache/hadoop/pull/3354#issuecomment-911177574


   Hi @tasanuma @Hexiaoqiao , could you please review the code? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 645713)
Time Spent: 40m  (was: 0.5h)

> Add a public method DatanodeID#getDisplayName
> -
>
> Key: HDFS-16194
> URL: https://issues.apache.org/jira/browse/HDFS-16194
> Project: Hadoop HDFS
>  Issue Type: Wish
>Reporter: tomscut
>Assignee: tomscut
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add a public method DatanodeID#getDisplayName to simplify the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16194) Add a public method DatanodeID#getDisplayName

2021-08-29 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16194?focusedWorklogId=643199=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643199
 ]

ASF GitHub Bot logged work on HDFS-16194:
-

Author: ASF GitHub Bot
Created on: 29/Aug/21 13:42
Start Date: 29/Aug/21 13:42
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3354:
URL: https://github.com/apache/hadoop/pull/3354#issuecomment-907793751


   hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure
   
   This failed unit test is unrelated to the change. @jojochuang @ayushtkn 
@ferhui Could you please help review the code. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 643199)
Time Spent: 0.5h  (was: 20m)

> Add a public method DatanodeID#getDisplayName
> -
>
> Key: HDFS-16194
> URL: https://issues.apache.org/jira/browse/HDFS-16194
> Project: Hadoop HDFS
>  Issue Type: Wish
>Reporter: tomscut
>Assignee: tomscut
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Add a public method DatanodeID#getDisplayName to simplify the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16194) Add a public method DatanodeID#getDisplayName

2021-08-29 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16194?focusedWorklogId=643191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643191
 ]

ASF GitHub Bot logged work on HDFS-16194:
-

Author: ASF GitHub Bot
Created on: 29/Aug/21 12:02
Start Date: 29/Aug/21 12:02
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3354:
URL: https://github.com/apache/hadoop/pull/3354#issuecomment-907780535


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 55s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  11m 43s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 43s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   6m 20s |  |  trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  compile  |   5m 43s |  |  trunk passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 20s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 27s |  |  trunk passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   3m 18s |  |  trunk passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  spotbugs  |   8m  6s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  18m 33s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 26s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m  6s |  |  the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javac  |   6m  6s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 39s |  |  the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  javac  |   5m 39s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   1m 14s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 59s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 11s |  |  the patch passed with JDK 
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   2m 55s |  |  the patch passed with JDK 
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10  |
   | +1 :green_heart: |  spotbugs  |   8m 37s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  18m 25s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 28s |  |  hadoop-hdfs-client in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 337m 25s |  |  hadoop-hdfs in the patch 
passed.  |
   | -1 :x: |  unit  |  32m 37s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3354/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
 |  hadoop-hdfs-rbf in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 56s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 514m 32s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3354/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3354 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux 024829d4f93d 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 
16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk /

[jira] [Work logged] (HDFS-16194) Add a public method DatanodeID#getDisplayName

2021-08-28 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16194?focusedWorklogId=643149=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643149
 ]

ASF GitHub Bot logged work on HDFS-16194:
-

Author: ASF GitHub Bot
Created on: 29/Aug/21 03:26
Start Date: 29/Aug/21 03:26
Worklog Time Spent: 10m 
  Work Description: tomscut opened a new pull request #3354:
URL: https://github.com/apache/hadoop/pull/3354


   JIRA: [HDFS-16194](https://issues.apache.org/jira/browse/HDFS-16194)
   
   Add a public method DatanodeID#getDisplayName to simplify the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 643149)
Remaining Estimate: 0h
Time Spent: 10m

> Add a public method DatanodeID#getDisplayName
> -
>
> Key: HDFS-16194
> URL: https://issues.apache.org/jira/browse/HDFS-16194
> Project: Hadoop HDFS
>  Issue Type: Wish
>Reporter: tomscut
>Assignee: tomscut
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add a public method DatanodeID#getDisplayName to simplify the code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org