[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747739=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747739
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 25/Mar/22 11:27
Start Date: 25/Mar/22 11:27
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1078928108


   Thanks @tasanuma for your review and merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747739)
Time Spent: 2h 50m  (was: 2h 40m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.4.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747732=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747732
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 25/Mar/22 11:19
Start Date: 25/Mar/22 11:19
Worklog Time Spent: 10m 
  Work Description: tasanuma merged pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747732)
Time Spent: 2.5h  (was: 2h 20m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747733=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747733
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 25/Mar/22 11:19
Start Date: 25/Mar/22 11:19
Worklog Time Spent: 10m 
  Work Description: tasanuma commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1078922059


   Thanks for your contribution, @tomscut!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747733)
Time Spent: 2h 40m  (was: 2.5h)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747622=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747622
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 25/Mar/22 06:32
Start Date: 25/Mar/22 06:32
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1078703073


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 37s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  33m 35s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 27s |  |  trunk passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  compile  |   1m 21s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m  3s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 26s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m  3s |  |  trunk passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 33s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 13s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  22m 37s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 18s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 19s |  |  the patch passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javac  |   1m 19s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 12s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |   1m 12s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 54s | 
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/5/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 400 unchanged 
- 0 fixed = 402 total (was 400)  |
   | +1 :green_heart: |  mvnsite  |   1m 16s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 53s |  |  the patch passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 22s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 10s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  22m 21s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 229m 27s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 46s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 329m 39s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/5/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3915 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux e37feabffbe9 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / f3c5e66a6058dbcc51a9559dc05e0bce16f8121c |
   | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   |  Test Results |

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-24 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747555=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747555
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 25/Mar/22 01:04
Start Date: 25/Mar/22 01:04
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1078553976


   > #4064 added a new `namesystem.writeUnlock()`. Could you add the opname 
too? The others look good to me.
   
   Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747555)
Time Spent: 2h 10m  (was: 2h)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-24 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747554=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747554
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 25/Mar/22 01:03
Start Date: 25/Mar/22 01:03
Worklog Time Spent: 10m 
  Work Description: tomscut commented on a change in pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#discussion_r834869705



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminDefaultMonitor.java
##
@@ -158,7 +158,7 @@ public void run() {
   LOG.warn("DatanodeAdminMonitor caught exception when processing node.",
   e);
 } finally {
-  namesystem.writeUnlock();
+  namesystem.writeUnlock("datanodeAdminMonitorThread");

Review comment:
   Thanks @tasanuma for your review. I fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747554)
Time Spent: 2h  (was: 1h 50m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-24 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747311
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 24/Mar/22 16:21
Start Date: 24/Mar/22 16:21
Worklog Time Spent: 10m 
  Work Description: tasanuma commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1077804296


   #4064 added a new `namesystem.writeUnlock()`. Could you add the opname too? 
The others look good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747311)
Time Spent: 1h 50m  (was: 1h 40m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-24 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=747309=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747309
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 24/Mar/22 16:19
Start Date: 24/Mar/22 16:19
Worklog Time Spent: 10m 
  Work Description: tasanuma commented on a change in pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#discussion_r834081133



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminDefaultMonitor.java
##
@@ -158,7 +158,7 @@ public void run() {
   LOG.warn("DatanodeAdminMonitor caught exception when processing node.",
   e);
 } finally {
-  namesystem.writeUnlock();
+  namesystem.writeUnlock("datanodeAdminMonitorThread");

Review comment:
   ```suggestion
 namesystem.writeUnlock("DatanodeAdminMonitorThread");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 747309)
Time Spent: 1h 40m  (was: 1.5h)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-23 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=746633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746633
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 23/Mar/22 14:49
Start Date: 23/Mar/22 14:49
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1076462287


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 43s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  36m 53s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 35s |  |  trunk passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  compile  |   1m 31s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m 10s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m 11s |  |  trunk passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 35s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 36s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  25m 22s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 29s |  |  the patch passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javac  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 22s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |   1m 22s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m  2s | 
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/4/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 400 unchanged 
- 0 fixed = 402 total (was 400)  |
   | +1 :green_heart: |  mvnsite  |   1m 29s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 55s |  |  the patch passed with JDK 
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 34s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 42s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 46s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 270m 43s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | +0 :ok: |  asflicense  |   0m 35s |  |  ASF License check generated no 
output?  |
   |  |   | 382m 20s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.TestDFSInputStream |
   |   | hadoop.hdfs.server.balancer.TestBalancer |
   |   | hadoop.hdfs.TestHDFSFileSystemContract |
   |   | hadoop.hdfs.TestReadStripedFileWithMissingBlocks |
   |   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy |
   |   | hadoop.hdfs.TestLargeBlock |
   |   | hadoop.hdfs.TestStoragePolicyPermissionSettings |
   |   | hadoop.hdfs.TestRollingUpgrade |
   |   | hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy |
   |   | hadoop.hdfs.TestGetBlocks |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3915 |
   | Optional Tests |

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-23 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=746386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746386
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 23/Mar/22 07:43
Start Date: 23/Mar/22 07:43
Worklog Time Spent: 10m 
  Work Description: tomscut commented on a change in pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#discussion_r832946641



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
##
@@ -63,4 +63,16 @@
* directories. Create them if not.
*/
   void checkAndProvisionSnapshotTrashRoots();
+
+  /**
+   * Release read lock with operation name.
+   * @param opName
+   */
+  void readUnlock(String opName);
+
+  /**
+   * Release write lock with operation name.
+   * @param opName
+   */
+  void writeUnlock(String opName);

Review comment:
   Thanks @tasanuma for your review and comment. I agree with you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 746386)
Time Spent: 1h 20m  (was: 1h 10m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-03-23 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=746384=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746384
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 23/Mar/22 07:24
Start Date: 23/Mar/22 07:24
Worklog Time Spent: 10m 
  Work Description: tasanuma commented on a change in pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#discussion_r832926344



##
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
##
@@ -63,4 +63,16 @@
* directories. Create them if not.
*/
   void checkAndProvisionSnapshotTrashRoots();
+
+  /**
+   * Release read lock with operation name.
+   * @param opName
+   */
+  void readUnlock(String opName);
+
+  /**
+   * Release write lock with operation name.
+   * @param opName
+   */
+  void writeUnlock(String opName);

Review comment:
   How about moving the new methods to RwLock since it has all lock-related 
methods? Although RwLock is not `@InterfaceAudience.Private`, I think we can 
add new methods there if the target version is 3.4.0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 746384)
Time Spent: 1h 10m  (was: 1h)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-02-13 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=725998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725998
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 14/Feb/22 02:34
Start Date: 14/Feb/22 02:34
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1038532614


   Hi @tasanuma @ayushtkn @Hexiaoqiao , could you please take a look at this. 
Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 725998)
Time Spent: 1h  (was: 50m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-02-13 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=725864=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725864
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 14/Feb/22 01:31
Start Date: 14/Feb/22 01:31
Worklog Time Spent: 10m 
  Work Description: tomscut commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1038532614


   Hi @tasanuma @ayushtkn @Hexiaoqiao , could you please take a look at this. 
Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 725864)
Time Spent: 50m  (was: 40m)

> Add opname to read/write lock for remaining operations
> --
>
> Key: HDFS-16434
> URL: https://issues.apache.org/jira/browse/HDFS-16434
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: tomscut
>Assignee: tomscut
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In this issue at 
> [HDFS-10872|https://issues.apache.org/jira/browse/HDFS-10872], we add opname 
> to read and write locks. However, there are still many operations that have 
> not been completed. When analyzing some operations that hold locks for a long 
> time, we can only find specific methods through stack. I suggest that these 
> remaining operations be completed to facilitate later performance 
> optimization.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-02-08 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=722786=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-722786
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 08/Feb/22 12:48
Start Date: 08/Feb/22 12:48
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1032572323


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 50s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  32m 23s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 29s |  |  trunk passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  compile  |   1m 19s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m  4s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 31s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m  1s |  |  trunk passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 18s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  22m 36s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 22s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 21s |  |  the patch passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  javac  |   1m 21s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 14s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |   1m 14s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 53s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 53s |  |  the patch passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 26s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 25s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  22m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 226m 35s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 44s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 326m 32s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3915 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux b4059dba06a8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / ed92774a12a67bf4339c3b0903ff752806e6e13c |
   | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/3/testReport/ |
   | Max. process+thread count | 2911 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/3/console |
   | versions |

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-01-31 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=718177=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-718177
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 31/Jan/22 20:09
Start Date: 31/Jan/22 20:09
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1026163379


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 41s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  40m 47s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 47s |  |  trunk passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  compile  |   1m 31s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m 10s |  |  trunk passed  |
   | -1 :x: |  mvnsite  |   0m 23s | 
[/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  javadoc  |   1m 12s |  |  trunk passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | -1 :x: |  javadoc  |   0m 33s | 
[/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
 |  hadoop-hdfs in trunk failed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.  |
   | -1 :x: |  spotbugs  |   0m 32s | 
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in trunk failed.  |
   | +1 :green_heart: |  shadedclient  |   4m 58s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m 28s | 
[/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch failed.  |
   | -1 :x: |  compile  |   0m 23s | 
[/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt)
 |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.  |
   | -1 :x: |  javac  |   0m 23s | 
[/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt)
 |  hadoop-hdfs in the patch failed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.  |
   | -1 :x: |  compile  |   0m 23s | 
[/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
 |  hadoop-hdfs in the patch failed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.  |
   | -1 :x: |  javac  |   0m 23s | 
[/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/2/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
 |  hadoop-hdfs in the patch failed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |

[jira] [Work logged] (HDFS-16434) Add opname to read/write lock for remaining operations

2022-01-22 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDFS-16434?focusedWorklogId=713247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713247
 ]

ASF GitHub Bot logged work on HDFS-16434:
-

Author: ASF GitHub Bot
Created on: 22/Jan/22 19:27
Start Date: 22/Jan/22 19:27
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on pull request #3915:
URL: https://github.com/apache/hadoop/pull/3915#issuecomment-1019343751


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 39s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  32m 29s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 27s |  |  trunk passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  compile  |   1m 19s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  checkstyle  |   1m  4s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 27s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m  3s |  |  trunk passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 34s |  |  trunk passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 10s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  22m 15s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 17s |  |  the patch passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  javac  |   1m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 10s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  javac  |   1m 10s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 53s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 18s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 51s |  |  the patch passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04  |
   | +1 :green_heart: |  javadoc  |   1m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07  |
   | +1 :green_heart: |  spotbugs  |   3m 15s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  22m 11s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 227m 10s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  asflicense  |   0m 46s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 325m 45s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/3915 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell |
   | uname | Linux fc288401759d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 6c98d9f75db8cd348418ff419ee30fdc144cd178 |
   | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/1/testReport/ |
   | Max. process+thread count | 3173 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3915/1/console |
   | versions |