[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=719880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719880 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 03/Feb/22 04:26 Start Date: 03/Feb/22 04:26 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1028591406 Thanks @ayushtkn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 719880) Time Spent: 1h 50m (was: 1h 40m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=719843=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719843 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 03/Feb/22 02:51 Start Date: 03/Feb/22 02:51 Worklog Time Spent: 10m Work Description: ayushtkn commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1028553130 Sorry I forgot to merge. :-( Thanx @tomscut for the contribution & @sunchao for the review!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 719843) Time Spent: 1h 40m (was: 1.5h) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=719842=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719842 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 03/Feb/22 02:51 Start Date: 03/Feb/22 02:51 Worklog Time Spent: 10m Work Description: ayushtkn merged pull request #3912: URL: https://github.com/apache/hadoop/pull/3912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 719842) Time Spent: 1.5h (was: 1h 20m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=719811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719811 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 03/Feb/22 01:12 Start Date: 03/Feb/22 01:12 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1028509813 Hi @sunchao @ayushtkn , could you please merge this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 719811) Time Spent: 1h 20m (was: 1h 10m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=717067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717067 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 28/Jan/22 15:00 Start Date: 28/Jan/22 15:00 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1024303819 > LGTM. If no comments for a couple of days. I think we can go ahead and merge this Thanks @ayushtkn for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 717067) Time Spent: 1h 10m (was: 1h) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=716811=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716811 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 28/Jan/22 01:07 Start Date: 28/Jan/22 01:07 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1023788767 I wanted to implement this todo, but found the discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923) quite sensible. We did not think need to add a configuration to turn on/off observer reads. So I suggest removing the todo comment. @jojochuang @shvachko @xkrogen Could you please also take a look? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 716811) Time Spent: 1h (was: 50m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=716810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716810 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 28/Jan/22 01:02 Start Date: 28/Jan/22 01:02 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1023785767 > I think [HDFS-16435](https://issues.apache.org/jira/browse/HDFS-16435) added it. Haven't touched observer namenode for a while now so not sure if anybody still find a configuration useful. Thanks @sunchao for your review and comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 716810) Time Spent: 50m (was: 40m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=716119=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716119 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 27/Jan/22 00:27 Start Date: 27/Jan/22 00:27 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1022728568 > It makes sense to me, I honestly don't understand what was the intend of that TODO. > Can you loop in the actual author/reviewer of that code as well to confirm. Thanks @ayushtkn for your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 716119) Time Spent: 40m (was: 0.5h) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=715805=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715805 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 26/Jan/22 16:28 Start Date: 26/Jan/22 16:28 Worklog Time Spent: 10m Work Description: ayushtkn commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1022369045 It makes sense to me, I honestly don't understand what was the intend of that TODO. Can you loop in the actual author/reviewer of that code as well to confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 715805) Time Spent: 0.5h (was: 20m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=715478=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715478 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 26/Jan/22 07:22 Start Date: 26/Jan/22 07:22 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1021932343 Hi @sunchao , could you please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 715478) Time Spent: 20m (was: 10m) > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16435) Remove no need TODO comment for ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16435?focusedWorklogId=713533=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713533 ] ASF GitHub Bot logged work on HDFS-16435: - Author: ASF GitHub Bot Created on: 24/Jan/22 07:26 Start Date: 24/Jan/22 07:26 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3912: URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1019795282 > > Based on discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923), we don't think need to Add a configuration to turn on/off observer reads. > > So I suggest removing the `TODO comment` that are not needed. > > Hi @ayushtkn , I am sorry that I did not explain the reason in the PR description. > > Based on discussion in [HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923), we don't think need to Add a configuration to turn on/off observer reads. So I suggest removing the `TODO comment` that are not needed. > > I don't know if it is appropriate to change the title of the original ISSUE, this PR is just a suggestion. I created a new JIRA [HDFS-16435](https://issues.apache.org/jira/browse/HDFS-16435). @ayushtkn Please take a look. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 713533) Remaining Estimate: 0h Time Spent: 10m > Remove no need TODO comment for ObserverReadProxyProvider > - > > Key: HDFS-16435 > URL: https://issues.apache.org/jira/browse/HDFS-16435 > Project: Hadoop HDFS > Issue Type: Wish >Reporter: tomscut >Assignee: tomscut >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Based on discussion in > [HDFS-13923|https://issues.apache.org/jira/browse/HDFS-13923], we don't think > need to Add a configuration to turn on/off observer reads. > So I suggest removing the `TODO comment` that are not needed. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
